Bug 20484

Summary:	The "Media Selection (Configure Supplemental Installation Media)" screen has gone missing (during installs & upgrades).
Product:	Mageia	Reporter:	psyca <linux>
Component:	Installer	Assignee:	Frédéric "LpSolit" Buclin <LpSolit>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	release_blocker	CC:	LpSolit, lebarhon, marja11, thierry.vignaud, yvesbrungard
Version:	Cauldron	Keywords:	6RC
Target Milestone:	Mageia 6
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	drakx-installer-stage2	CVE:
Status comment:
Bug Depends on:
Bug Blocks:	20754
Attachments:	screenshot of the installer, Mageia 5 screenshot #2 of the installer, Mageia 5 report.bug.xz

Description psyca 2017-03-14 23:08:18 CET

Description of problem:
Theres no question if i want to add online media (repositorys) before starting the installation.

The errata says e.g. ( https://wiki.mageia.org/en/Mageia_6_Errata#Upgrading_a_system_that.27s_received_updates_since_the_iso_was_released ) that you need to activate online media, because it could occur errors if you have newer Mageia 5(.1) (packages) than are available on the Mageia 6 isos.

The menu : http://doc.mageia.org/installer/5/en/content/add_supplemental_media.html is missing.

Comment 1 Marja Van Waes 2017-03-15 11:01:43 CET

Ah, of course it's missing during an upgrade :-(

I've fixed the wrong wiki advice.

It would still be nice to have the "Media Selection (Configure Supplemental Installation Media)" screen available during install, though, even if it won't help when wlan doesn't work.

Keywords: (none) => 6sta2
CC: (none) => marja11
Assignee: bugsquad => mageiatools
Summary: sta2 - Cannot add online media with traditional installer => Please make the "Media Selection (Configure Supplemental Installation Media)" screen available during upgrades.
Source RPM: (none) => drakx-installer-stage2
Severity: normal => enhancement

Marja Van Waes 2017-03-29 08:15:54 CEST

Keywords: 6sta2 => 6RC

Comment 2 Marja Van Waes 2017-05-01 09:12:15 CEST

Bug #20750, comment #8 convinced me that this is a regression, so increasing from enhancement request to release blocker.

I understand now that the original wiki advice, to activate online media while upgrading, was made because that did really work, as LpSolit reports in Bug #20750, comment #8

However he also reports that the http://doc.mageia.org/installer/5/en/content/add_supplemental_media.html screen no longer appears in normal installs, either.

Btw, we need /root/drakx/report.bug.xz from a 6RC install (and maybe also from an upgrade) where that screen was skipped.

Severity: enhancement => critical
Keywords: (none) => NEEDINFO
Priority: Normal => release_blocker
Summary: Please make the "Media Selection (Configure Supplemental Installation Media)" screen available during upgrades. => The "Media Selection (Configure Supplemental Installation Media)" screen has gone missing (during installs & upgrades).
CC: (none) => lebarhon, LpSolit, yves.brungard_mageia

Comment 3 Frédéric "LpSolit" Buclin 2017-05-01 16:27:04 CEST

Created attachment 9254 [details]
screenshot of the installer, Mageia 5

I just tested with the Mageia 5 DVD, and the screen to ask remote media is present....

Comment 4 Frédéric "LpSolit" Buclin 2017-05-01 16:27:52 CEST

Created attachment 9255 [details]
screenshot #2 of the installer, Mageia 5

... and then you can see new media listed. So clearly a regression in the Mageia 6 installer.

Comment 5 André DESMOTTES 2017-05-01 18:47:20 CEST

I confirm, the add media screen was present with mga 5 and isn't any longer with Mga6, in both situations clean install or upgrade.

Comment 6 André DESMOTTES 2017-05-01 18:49:21 CEST

Created attachment 9257 [details]
report.bug.xz

(In reply to Marja van Waes from comment #2)

> 
> Btw, we need /root/drakx/report.bug.xz from a 6RC install (and maybe also
> from an upgrade) where that screen was skipped.

here is a report from an upgrade 5>6

Rémi Verschelde 2017-05-02 21:16:32 CEST

Keywords: NEEDINFO => (none)
CC: (none) => thierry.vignaud

Comment 7 Frédéric "LpSolit" Buclin 2017-05-05 22:55:43 CEST

I found what the problem is. Trivial to fix.

Status: NEW => ASSIGNED
Assignee: mageiatools => LpSolit
Target Milestone: --- => Mageia 6

Comment 8 Mageia Robot 2017-05-05 23:02:50 CEST

commit 5de74f5ec6dc3aaf9cfd204be0ec4ab366089d91
Author: Frédéric Buclin <LpSolit@...>
Date:   Fri May 5 22:58:56 2017 +0200

    Make sure 'supplmedia' is defined before using it (mga#20484)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=5de74f5ec6dc3aaf9cfd204be0ec4ab366089d91

Comment 9 Frédéric "LpSolit" Buclin 2017-05-05 23:07:25 CEST

Fixed!

This was a regression due to http://gitweb.mageia.org/software/drakx/commit/perl-install/install/install2.pm?id=560f9ca9

Resolution: (none) => FIXED
Status: ASSIGNED => RESOLVED

Comment 10 Rémi Verschelde 2017-05-05 23:24:37 CEST

Fixed included in drakx-installer-stage2-17.81-1.mga6, should be on next ISOs.

Frédéric "LpSolit" Buclin 2017-05-05 23:34:34 CEST

Blocks: (none) => 20754

Comment 11 Thierry Vignaud 2017-05-06 15:45:59 CEST

(In reply to Frédéric Buclin from comment #9)
> Fixed!

Thx for fixing that
 
> This was a regression due to
> http://gitweb.mageia.org/software/drakx/commit/perl-install/install/install2.
> pm?id=560f9ca9

Please say so in your commit chlog, that makes changes easier to understan by other & history easier to read.
You can use sg like "regression introduced in commit 560f9ca9" and one will get a nice link in gitk (sadly not in tig or gitg though)
Just my 2 cents