Bug 20445

Summary: syncthing fail to start; FATAL: Invalid version string "0.14.23";
Product: Mageia Reporter: Morgan Leijström <fri>
Component: RPM PackagesAssignee: Rémi Verschelde <rverschelde>
Status: RESOLVED FIXED QA Contact:
Severity: critical    
Priority: Normal CC: luis.daniel.lucio
Version: Cauldron   
Target Milestone: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Source RPM: syncthing-0.14.23-2.mga6.src.rpm CVE:
Status comment:

Description Morgan Leijström 2017-03-10 19:19:21 CET
Version-Release number of selected component (if applicable):
syncthing-0.14.23-1.mga6.src.rpm

Version 1.14.21-1 was running perfectly.
I was away for a couple week.
Now i updated the system (600 packages...)
and after reboot syncthinng fail to start:

$ /usr/bin/syncthing
19:06:55 FATAL: Invalid version string "0.14.23";
        does not match regexp ^v\d+\.\d+\.\d+(-[a-z0-9]+)*(\.\d+)*(\+\d+-g[0-9a-f]+)?(-[^\s]+)?$
Comment 1 Rémi Verschelde 2017-03-10 19:31:20 CET
Confirmed, looks like I should not have dropped the part of that patch that was fixing the regex. Weird that upstream doesn't seem to fix it..

Assignee: bugsquad => rverschelde

Comment 2 Rémi Verschelde 2017-03-10 19:41:00 CET
Fixed it in syncthing-0.14.23-2.mga6 and sent a patch upstream: https://github.com/syncthing/syncthing/pull/4036

Status: NEW => RESOLVED
CC: (none) => luis.daniel.lucio
Resolution: (none) => FIXED

Comment 3 Morgan Leijström 2017-03-11 09:32:19 CET
Thanks Rémi - that was quick
Maybe too quick ;) - i do not see a difference except package version...

bash-4.3$ /usr/bin/syncthing
09:29:08 FATAL: Invalid version string "0.14.23";
        does not match regexp ^v\d+\.\d+\.\d+(-[a-z0-9]+)*(\.\d+)*(\+\d+-g[0-9a-f]+)?(-[^\s]+)?$
bash-4.3$ rpm -q syncthing
syncthing-0.14.23-2.mga6

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)
Source RPM: syncthing-0.14.23-1.mga6.src.rpm => syncthing-0.14.23-2.mga6.src.rpm

Comment 4 Rémi Verschelde 2017-03-11 09:59:38 CET
Indeed, I had forgotten to apply the patch ;)

It should now be fixed in syncthing-0.14.23-3.mga6 as instead of patching the regex, I added the 'v' prefix that upstream requires, as discussed in https://github.com/syncthing/syncthing/pull/4036

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 5 Morgan Leijström 2017-03-11 14:29:12 CET
Thank you - I confirm it works :)
And nice to have the right fix now