| Summary: | Use DBus Menu (via StatusNotifier 1.0) for mgaapplet and net_applet | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Frédéric "LpSolit" Buclin <LpSolit> |
| Component: | RPM Packages | Assignee: | Frédéric "LpSolit" Buclin <LpSolit> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | mageia, rverschelde, thierry.vignaud |
| Version: | Cauldron | ||
| Target Milestone: | Mageia 6 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/jjk-jacky/statusnotifier/releases/tag/1.0.0 | ||
| Whiteboard: | Must be pushed at the same time as StatusNotifier 1.0 (not backward compatible) | ||
| Source RPM: | CVE: | ||
| Status comment: | |||
| Bug Depends on: | 20459 | ||
| Bug Blocks: | |||
| Attachments: |
Use DBus Menu from mgaapplet
Use DBus Menu from net_applet Use DBus Menu from net_applet, v2 Use DBus Menu from net_applet, v2 |
||
|
Description
Frédéric "LpSolit" Buclin
2017-03-07 14:53:20 CET
The maintainer of StatusNotifier just told me that 1.0 should be released this week-end if nothing goes wrong meanwhile. :) URL:
https://github.com/jjk-jacky/statusnotifier/tree/introspection =>
https://github.com/jjk-jacky/statusnotifier/tree/next
Thierry Vignaud
2017-03-08 19:23:51 CET
CC:
(none) =>
thierry.vignaud 1.0.0 released a few hours ago: https://github.com/jjk-jacky/statusnotifier/releases/tag/1.0.0 URL:
https://github.com/jjk-jacky/statusnotifier/tree/next =>
https://github.com/jjk-jacky/statusnotifier/releases/tag/1.0.0 Created attachment 9069 [details]
Use DBus Menu from mgaapplet
Here is the patch for mgaapplet. It requires StatusNotifier 1.0.
Some stats, for comparison, after a right-click on the status icon:
StatusNotifier without DBus Menu:
VIRT 922 MB
RES 98.1 MB
SHR 35.9 MB
StatusNotifier with DBus Menu: (without displaying the About dialog)
VIRT 637 MB
RES 91.1 MB
SHR 29.6 MB
GtkStatusIcon:
VIRT 918 MB
RES 99.6 MB
SHR 36.4 MB
Created attachment 9070 [details]
Use DBus Menu from net_applet
And here is the patch for net_applet. It also requires StatusNotifier 1.0.
Some more stats, after a right-click on the status icon:
StatusNotifier without DBus Menu:
VIRT 902 MB
RES 84.3 MB
SHR 30.0 MB
StatusNotifier with DBus Menu:
VIRT 546 MB
RES 77.6 MB
SHR 24.3 MB
GtkStatusIcon:
VIRT 824 MB
RES 84.5 MB
SHR 30.4 MB
Note that both patches are incompatible with the version of StatusNotifier currently in Cauldron (0.1). They both require 1.0, but compiled with the ./configure --enable-introspection=yes --enable-dbusmenu --enable-gtk-doc command, else DBus Menu won't be enabled. Also note the new --enable-introspection=yes argument which will let you clean the spec a bit. Also, the current mgaapplet and net_applet scripts in Cauldron won't work with StatusNotifier 1.0, so conflicts in the RPM spec files must be set accordingly. Please do not forget to include the fix for bug 20434 before pushing new RPMs. The dependency should ideally be put in a place where we don't need to worry about it again. CC:
(none) =>
mageia, rverschelde For some reason, the right-click doesn't trigger anything on a clean reboot. It looks like the DBus Menu is not working if net_applet is launched too early. Still investigating. Do not commit anything yet, please. Status comment:
(none) =>
Not ready for checkin, see comment 6! maybe you can do a branch in git this will be simpler and will be merged when ready ;) (In reply to Nicolas Lécureuil from comment #7) > maybe you can do a branch in git this will be simpler and will be merged > when ready ;) Nan, this won't help me find the problem. :)
Frédéric "LpSolit" Buclin
2017-03-12 16:42:02 CET
Depends on:
(none) =>
20459 (In reply to Frédéric Buclin from comment #6) > For some reason, the right-click doesn't trigger anything on a clean reboot. > It looks like the DBus Menu is not working if net_applet is launched too > early. Still investigating. If I put a sleep(3) early in net_applet, then things are working fine. I wonder if there is some latency with something else (what?) which is not ready yet when net_applet is called. Created attachment 9084 [details]
Use DBus Menu from net_applet, v2
With a timer, things are working fine on my machine. I kept the code for the context_menu signal, just in case there is something wrong with DBusMenu.
I will check if mgaapplet needs the same fix or not.
Attachment 9070 is obsolete:
0 =>
1 Created attachment 9085 [details]
Use DBus Menu from net_applet, v2
(rebased due to the release of 2.29)
Attachment 9084 is obsolete:
0 =>
1 Looks like mgaapplet doesn't need this fix, so we are good to go. :) commit 8baa7d8813dee41c9150ddb0a8139c8895cb1b93
Author: Frédéric Buclin <LpSolit@...>
Date: Sat Mar 11 19:52:30 2017 +0100
Use DBus Menu + StatusNotifier 1.0 (mga#20410)
---
Commit Link:
http://gitweb.mageia.org/software/drakx-net/commit/?id=8baa7d8813dee41c9150ddb0a8139c8895cb1b93
commit 74fafa20c2a11d9c59db1016342eca1d240d7ce7
Author: Frédéric Buclin <LpSolit@...>
Date: Sat Mar 11 19:45:14 2017 +0100
Use DBus Menu + StatusNotifier 1.0 (mga#20410)
---
Commit Link:
http://gitweb.mageia.org/software/mgaonline/commit/?id=74fafa20c2a11d9c59db1016342eca1d240d7ce7
Released and submitted drakx-net 2.30 and mgaonline 3.20, to go with statusnotifier 1.0.0. Status comment:
Not ready for checkin, see comment 6! =>
(none) |