Bug 19888

Summary:	Autopartitioner doesn't account for required BIOS boot partition for GPT MBR disks
Product:	Mageia	Reporter:	Neal Gompa <ngompa13>
Component:	Installer	Assignee:	Mageia tools maintainers <mageiatools>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	release_blocker	CC:	bequimao.de, marja11, pterjan
Version:	Cauldron	Keywords:	6sta2
Target Milestone:	---
Hardware:	All
OS:	Linux
See Also:	https://bugs.mageia.org/show_bug.cgi?id=19935
Whiteboard:
Source RPM:		CVE:
Status comment:

Description Neal Gompa 2016-12-04 13:50:15 CET

Description of problem:
When installing onto a disk that has an empty GPT table, the installer partitioner doesn't automatically create the appropriate BIOS boot partition along with the regular partitions.

The partitioner throws an error saying "You must have a BIOS boot partition for non-UEFI GPT-partitioned disks. Please create one before continuing.."

Version-Release number of selected component (if applicable):
DrakX v17.62

How reproducible:
Always

Steps to Reproduce:
1. Create an empty disk (virtual/physical) with a GPT table
2. Do BIOS boot of Mageia Cauldron netinstall ISO
3. Attempt to partition the disk with autopartitioning (use all free space option)

Neal Gompa 2016-12-04 13:50:27 CET

Priority: Normal => release_blocker

Neal Gompa 2016-12-04 13:51:45 CET

Assignee: bugsquad => mageiatools

Ulrich Beckmann 2016-12-06 09:07:11 CET

CC: (none) => bequimao.de

Neal Gompa 2016-12-06 12:09:42 CET

Keywords: (none) => 6sta2

Marja Van Waes 2017-01-03 13:49:11 CET

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=19935

Marja Van Waes 2017-01-03 13:49:40 CET

CC: (none) => marja11, pterjan

Comment 1 Mageia Robot 2017-02-12 16:01:26 CET

commit 02ba0f311a04e3fe93985bb75b6e7e99c6315b73
Author: Martin Whitaker <mageia@...>
Date:   Sat Feb 4 23:46:14 2017 +0000

    Fix auto-allocation of BIOS boot partitions (mga#20161, mga#19888).
    
    This adds a specific subroutine, fsedit::auto_allocate_boot_bios_parts
    that detects if a BIOS boot partition is needed and allocates it if so.
    This allows us to relax the rules in fs::any::is_boot_bios_part_needed
    to allow the user to manually allocate the BIOS boot partition on a
    different device if they so wish.
    
    In the normal case that installation is confined to a single disk,
    this will allocate a single BIOS boot partition on that disk. In
    the rare case that installation is spread over multiple disks, it
    will allocate a BIOS boot partition on every disk. Given that the
    BIOS boot partitions are very small and that this is not a normal
    use case (see mga#16055), this seems an acceptable quirk - and does
    allow the user to then choose any disk when installing the boot
    loader.
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=02ba0f311a04e3fe93985bb75b6e7e99c6315b73

 Bug links:
   Mageia
      https://bugs.mageia.org/16055
      https://bugs.mageia.org/20161
      https://bugs.mageia.org/19888

Comment 2 Neal Gompa 2017-02-23 21:49:12 CET

I just tested with the x86_64 sta2 ISO downloaded an hour ago, and this issue is now resolved.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 3 Mageia Robot 2017-02-25 15:16:06 CET

commit daf8670c08e54ac64407f7f209aaf9b460abdcc6
Author: Martin Whitaker <mageia@...>
Date:   Sat Feb 4 23:46:14 2017 +0000

    Fix auto-allocation of BIOS boot partitions (mga#20161, mga#19888).
    
    This adds a specific subroutine, fsedit::auto_allocate_boot_bios_parts
    that detects if a BIOS boot partition is needed and allocates it if so.
    This allows us to relax the rules in fs::any::is_boot_bios_part_needed
    to allow the user to manually allocate the BIOS boot partition on a
    different device if they so wish.
    
    In the normal case that installation is confined to a single disk,
    this will allocate a single BIOS boot partition on that disk. In
    the rare case that installation is spread over multiple disks, it
    will allocate a BIOS boot partition on every disk. Given that the
    BIOS boot partitions are very small and that this is not a normal
    use case (see mga#16055), this seems an acceptable quirk - and does
    allow the user to then choose any disk when installing the boot
    loader.
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=daf8670c08e54ac64407f7f209aaf9b460abdcc6

 Bug links:
   Mageia
      https://bugs.mageia.org/16055
      https://bugs.mageia.org/20161
      https://bugs.mageia.org/19888