Bug 19860

Summary: plymouth splash offset and partially off screen with hybrid graphics
Product: Mageia Reporter: Martin Whitaker <mageia>
Component: RPM PackagesAssignee: Donald <watersnowrock>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: release_blocker CC: alfred.kretschmer, ftg, ita84, mageia, marja11, thierry.vignaud
Version: Cauldron   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: mageia-theme-6.2-1.mga6 CVE:
Status comment: Potential fix pushed in mageia-theme 6.3
Attachments: log file created by plymouth:debug boot option
Output from lsipcidrake

Description Martin Whitaker 2016-11-28 22:42:27 CET
Created attachment 8707 [details]
log file created by plymouth:debug boot option

On a recent net install of cauldron, on a machine with hybrid nVidia/Intel graphics, when booting the bootsplash screen appears offset (down and to the right) and clipped leaving a blue border on top and to the left, as can be seen in this photograph:

https://photos.google.com/share/AF1QipOrsrgIzsahJjAr0ioocBI-b565WrGmErnI6ck1yq7hPZN95icfkMP2oB0ggpl04g/photo/AF1QipMsBgCG2u4NFrNmw6TASJJVPKDM5XtcdkF6zfIa?key=M0dBblZfeF9YeWMwSGR1TWhaZVdrN0c3bjhTaURB

It looks like the bootsplash is the correct size, just offset.

Plymouth debug log attached.
Comment 1 Martin Whitaker 2016-11-28 22:43:33 CET
Created attachment 8708 [details]
Output from lsipcidrake

Other logs available on request.
Comment 2 Marja Van Waes 2016-11-30 13:15:40 CET
I see the same, on another hybrid nVidia/Intel graphics system, where I have an extra monitor attached and xorg.conf removed. I only see it on the largest monitor, for the smaller one the correct offset is used, but the screen is assumed to be as large as the largest one.

I don't remember whether plymouth worked fine before I started seeing this issue, there's a chance another issue was hiding it. However, there have been no plymouth updates since I installed this cauldron, so, if plymouth is the culprit, then a change in another package triggered my seeing this.

Starting a kernel from a month ago doesn't make a difference, nor does temporarily removing "nouveau.modeset=0" at boot help (I do only use the intel card).

There have been x11* updates, though. I haven't tried whether creating a new xorg.conf helps

CC: (none) => marja11, thierry.vignaud

Comment 3 Marja Van Waes 2016-12-01 09:07:01 CET
(In reply to Marja van Waes from comment #2)

> 
> There have been x11* updates, though. I haven't tried whether creating a new
> xorg.conf helps

Tried that just now. It doesn't help for this issue. I removed xorg.conf again (because it made Plasma5 crash on my first [right-]click).

[marja@localhost ~]$ ls -al /usr/share/mga/backgrounds/
totaal 1308
drwxr-xr-x 2 root root   4096 dec  1  2016 ./
drwxr-xr-x 9 root root   4096 feb  8  2016 ../
lrwxrwxrwx 1 root root     11 okt  9 21:09 default.jpg -> default.png
lrwxrwxrwx 1 root root     55 dec  1  2016 default.png -> /usr/share/mga/backgrounds/Mageia-Default-3840x2160.png
-rw-r--r-- 1 root root  92367 okt  9 21:09 Mageia-Default-1024x600.png
-rw-r--r-- 1 root root 135306 okt  9 21:09 Mageia-Default-1280x1024.png
-rw-r--r-- 1 root root 127176 okt  9 21:09 Mageia-Default-1280x768.png
-rw-r--r-- 1 root root 178033 okt  9 21:09 Mageia-Default-1600x1200.png
-rw-r--r-- 1 root root 224953 okt  9 21:09 Mageia-Default-1920x1200.png
-rw-r--r-- 1 root root 557705 okt  9 21:09 Mageia-Default-3840x2160.png
[marja@localhost ~]$ 

I don't think for me the background should default to 3840x2160

My largest screen is 1920x1080
My smallest screen is 1600x900


Wildly assuming the default is wrong for Martin, too.

@ Martin

Is it? If not, then sorry for hijacking your report... in that case, I'll hide this comment


@ Donald

I guess, regardless of whether Martin has a wrong default, too, you're the one who knows most about our plymouth, so assigning to you. Please reassign if needed.

Assignee: bugsquad => watersnowrock

Comment 4 Marja Van Waes 2016-12-01 09:16:51 CET
(In reply to Marja van Waes from comment #3)
> (In reply to Marja van Waes from comment #2)
> 
> > 
> > There have been x11* updates, though. I haven't tried whether creating a new
> > xorg.conf helps
> 
> Tried that just now. It doesn't help for this issue. I removed xorg.conf
> again (because it made Plasma5 crash on my first [right-]click).
> 

<snip>

> in that case, I'll
> hide this comment
> 

Hiding it, anyway, because it was silly. Sorry for the noise!

@ Donald,

keeping the assignment to you, though :-)
Comment 5 Marja Van Waes 2016-12-01 12:44:36 CET
Alfred Kretschmer might be able to help, CC'ing him.

CC: (none) => alfred.kretschmer

Comment 6 Donald 2016-12-01 12:54:27 CET
This is a weird one.

What does ls -al /usr/share/mga/backgrounds/ and what is your screen resolution?

@Marja - in the hidden comment, all of that is correct - this isn't about resolution but aspect ratio, 1600/600=3840/2160

Status: NEW => ASSIGNED

Comment 7 Marja Van Waes 2016-12-01 14:47:27 CET
Yeah, that's why I hid that comment ;-)

I'll unhide my silly comment, because you're now asking for that information

Martin's plymouth debug file mentions 1920x1080 and 1024x768
(search for "pixel display")

Something I tried, too, (because we used to have both png and jpg backgrounds) was to create Mageia-Default-3840x2160.jpg, and let default.jpg link to it, but that didn't make a difference.

Comment 3 is private: 1 => 0

Comment 8 Donald 2016-12-01 15:09:03 CET
(In reply to Martin Whitaker from comment #0)
> Created attachment 8707 [details]
> log file created by plymouth:debug boot option
> 
> On a recent net install of cauldron, on a machine with hybrid nVidia/Intel
> graphics, when booting the bootsplash screen appears offset (down and to the
> right) and clipped leaving a blue border on top and to the left, as can be
> seen in this photograph:
> 
> https://photos.google.com/share/AF1QipOrsrgIzsahJjAr0ioocBI-
> b565WrGmErnI6ck1yq7hPZN95icfkMP2oB0ggpl04g/photo/
> AF1QipMsBgCG2u4NFrNmw6TASJJVPKDM5XtcdkF6zfIa?key=M0dBblZfeF9YeWMwSGR1TWhaZVdr
> N0c3bjhTaURB
> 
> It looks like the bootsplash is the correct size, just offset.
> 
> Plymouth debug log attached.

Was this just on the 1st boot or did it persist after multiple reboots?
Comment 9 Marja Van Waes 2016-12-01 15:32:07 CET
For me it persists, it happened in every boot since it started occurring (certainly more than 10 boots).
Comment 10 Frank Griffin 2016-12-01 15:34:47 CET
I see this too, since forever and also on Intel/nvidia using only Intel.  I just never had a clue how to report it meaningfully.  And default.png is also symlinked to the 3840x2160 file.

During install, I always allow the resolution to default to Auto or Plug and Play, but it's a 17"" laptop if that clarifies the aspect ratio.
Comment 11 Donald 2016-12-01 15:42:27 CET
I'll see what happens when I redo the theme for the more discrete
style requested

Donald 'Schultz' Stewart
Comment 12 Donald 2016-12-01 15:47:33 CET
(In reply to Frank Griffin from comment #10)
> I see this too, since forever and also on Intel/nvidia using only Intel.  I
> just never had a clue how to report it meaningfully.  And default.png is
> also symlinked to the 3840x2160 file.
> 
> During install, I always allow the resolution to default to Auto or Plug and
> Play, but it's a 17"" laptop if that clarifies the aspect ratio.

The aspect ratio is found from the screen's native resolution, it defaulting to 3840x2160 makes the screen 16:9, which includes 1920x1080 resolutions.

Something is rather broken here though, previously, all plymouth themes used 1920x1200 for the background and it was just scaled accordingly. All that I can think of here is that the background and the images being overlaid on it are different sizes causing problems.

Still, that doesn't explain why it is only occurring for a few people and not universally.
Comment 13 Donald 2016-12-01 15:58:50 CET
One other thing to test, is it actually our theme or plymouth itself that's causing the problem.

You'll need a different theme, we ship a few, I'd suggest solar as it colours the full screen.

View the installed themes with: 

plymouth-set-default-theme --list

If it's not there, install plymouth-theme-solar

Set the theme with:

plymouth-set-default-theme solar

After setting the theme, you need to rebuild init to have the new theme files included:

dracut -f

All of that needs root obviously.
Comment 14 Martin Whitaker 2016-12-01 19:20:26 CET
(In reply to Donald from comment #8)
> Was this just on the 1st boot or did it persist after multiple reboots?

It persists.

(In reply to Donald from comment #13)
> One other thing to test, is it actually our theme or plymouth itself that's
> causing the problem.
> 
> You'll need a different theme, we ship a few, I'd suggest solar as it
> colours the full screen.

The solar theme displays correctly.

I'd guess it's getting confused because the hybrid graphics is presented as two cards, with different resolutions (why different resolutions when they are connected to the same display is anyone's guess).
Comment 15 Frank Griffin 2016-12-02 02:25:00 CET
Interesting.  I installed and switched to solar and rebooted.  The shift of the background was still the same, but when I booted into Plasma I found some interesting differenced.  My Firefox bookmarks panel was now all colored icons rather than text, and Thunderbird displayed all mail messages as dark blue with no readable text.

When I switched back to Mageia-Default and rebooted, all was right again.

I may not be that observant, but I didn't really see that much of a difference between M-D and solar as far as the backdrop.

I'm really out of my depth here...

CC: (none) => ftg

Comment 16 Martin Whitaker 2017-03-20 21:55:43 CET
Any further ideas on this? I'd hate to see this turn up in a review of Mageia 6.
Comment 17 Donald 2017-03-25 14:20:09 CET
I have an idea of what is causing this. Testing some fixes now, but I don't have a working hybrid graphics systems anymore, so will need help testing.

I think that the issues is that we are dynamically linking the background in plymouth, for me this will switch between the 16:9 aspect ratio when I use nouveau with kms and 4:3 with the nvidia driver. However, the animation images don't change, as plymouth scaling is a pain, I made the animation images the same size as the background that was shipped with previous versions of Mageia, so 1920x1200. 

I'm hoping that plymouth trying to display 2 different image sizes is whats causing these issues, but not certain how likely this is.

The other option if that fails is to rebase the plymouth script off one that we know works - to that end if anyone is using a different theme thats working please let me know.
Comment 18 Martin Whitaker 2017-03-25 15:41:20 CET
(In reply to Donald from comment #17)
> I'm hoping that plymouth trying to display 2 different image sizes is whats
> causing these issues, but not certain how likely this is.
> 
Seems very likely to me. I can work round the bug by adding rd.driver.blacklist=nouveau on the boot command line, which prevents plymouth seeing and using the second display.

> The other option if that fails is to rebase the plymouth script off one that
> we know works - to that end if anyone is using a different theme thats
> working please let me know.

As noted above, the solar theme works for me.
Comment 19 Davide Nifosi 2017-03-31 11:06:29 CEST
Reporting that this happens to my system as well, a laptop with hybrid Intel/Radeon graphics connected to an external monitor, with the default Mageia theme. Last time I saw, on the laptop monitor the splash screen looks fine. The laptop and external monitor have different resolutions.

I will try the solar theme when I can and will let you know.

CC: (none) => ita84

Comment 20 Davide Nifosi 2017-03-31 19:28:13 CEST
I can confirm the solar theme does not have this problem for me either. The Mageia-Default theme is in the wrong position when on the external monitor, and in the right position but with the wrong size when on the laptop monitor
Comment 21 Donald 2017-04-01 14:13:25 CEST
As reported here: https://bugs.mageia.org/show_bug.cgi?id=18028

Does this still occur with sta2?

If so, I'll get a new theme to test this shortly.
Comment 22 Davide Nifosi 2017-04-01 15:06:57 CEST
It still does for my system (Intel/Radeon). Installed Plymouth packages are version 0.9.2-9.mga6
Comment 23 Martin Whitaker 2017-04-03 01:25:38 CEST
Still occurs with fully updated cauldron.
Comment 24 Martin Whitaker 2017-05-06 12:12:47 CEST
Ping. There's (hopefully!) not much time left to get this fixed.
Rémi Verschelde 2017-05-06 13:22:58 CEST

Summary: bootsplash offset and partially off screen => plymouth splash offset and partially off screen with hybrid graphics

Rémi Verschelde 2017-05-06 13:23:05 CEST

Priority: Normal => release_blocker

Comment 25 Rémi Verschelde 2017-05-06 13:24:39 CEST
As Martin mentioned, I believe the issue is specific to hybrid graphics. I can easily imagine plymouth getting confused by the discrete GPU, which is often incorrectly handled as a "secondary monitor". So if our theme tries to use some width and height values from the display, it might actually take into account both the physical display and a non-existent secondary display, hence an offset.
Comment 26 Alfred Kretschmer 2017-05-06 16:42:17 CEST
(In reply to Rémi Verschelde from comment #25)
> As Martin mentioned, I believe the issue is specific to hybrid graphics. I
> can easily imagine plymouth getting confused by the discrete GPU, which is
> often incorrectly handled as a "secondary monitor". 

I've never noticed this issue as i configure always only the integrated intel-graphic while install and install bumblebee after first reboot.  

(In reply to Martin Whitaker from comment #24)
> Ping. There's (hopefully!) not much time left to get this fixed.
I don't see this as a serious problem nor as a blocker. A respective hint in the errata/release notes would imo be sufficient.
Comment 27 Martin Whitaker 2017-05-06 16:50:27 CEST
(In reply to Alfred Kretschmer from comment #26)
> (In reply to Rémi Verschelde from comment #25)
> > As Martin mentioned, I believe the issue is specific to hybrid graphics. I
> > can easily imagine plymouth getting confused by the discrete GPU, which is
> > often incorrectly handled as a "secondary monitor". 
> 
> I've never noticed this issue as i configure always only the integrated
> intel-graphic while install and install bumblebee after first reboot.  

You don't have that option when booting a Live DVD.

And I only configure the Intel graphics when installing, and still see this on every boot. My hardware *requires* the nouveau driver to be loaded and enabled, otherwise I get no display.

> (In reply to Martin Whitaker from comment #24)
> > Ping. There's (hopefully!) not much time left to get this fixed.
> I don't see this as a serious problem nor as a blocker. A respective hint in
> the errata/release notes would imo be sufficient.

If you don't care about reviews, yes.
Comment 28 Donald 2017-05-06 16:53:42 CEST
I have a fix pretty much ready for this, will submit it tonight.
Rémi Verschelde 2017-05-06 18:18:07 CEST

Status comment: (none) => Donald should commit a fix soon.

Comment 29 Donald 2017-05-07 02:17:52 CEST
Should be fixed in mageia-theme-6.3, its waiting in Akiens inbox, my git access is still messed up.

This should make plymouth much prettier in general, no more squishing when the aspect ratio is wrong. Please report on how it works as I only have a single resolution non gpu switching laptop to test on.
Comment 30 Mageia Robot 2017-05-07 10:09:30 CEST
commit 35953190930d36d76c87f6ba92390d37db0afdb3
Author: Donald Stewart <watersnowrock@...>
Date:   Sun May 7 10:07:00 2017 +0200

    Plymouth: Improve scaling and aspect ratio handling
    
    Hopefully fixes mga#19860.
---
 Commit Link:
   http://gitweb.mageia.org/software/design/theme/commit/?id=35953190930d36d76c87f6ba92390d37db0afdb3
Comment 31 Rémi Verschelde 2017-05-07 10:15:49 CEST
Please test mageia-theme-6.3-1.mga6. If the updates does not trigger it automatically, you might have to rebuild the initrd with `dracut -f` to pick the theme changes.

Source RPM: (none) => mageia-theme-6.2-1.mga6
Status comment: Donald should commit a fix soon. => Potential fix pushed in mageia-theme 6.3

Comment 32 Martin Whitaker 2017-05-07 12:53:19 CEST
Sorry, still broken for me.
Comment 33 Donald 2017-05-07 20:16:59 CEST
Martin, can you hardlink a copy of the appropriate background.png from /usr/share.mga/background into /usr/share/plymouth/themes/Mageia-Default and rebuild initrd.

This was never an issue when we had a static image for the plymouth background, so the only thing I can think of is that something in the boot is changing the resolution.

Here is also a link to the OpenSUSE plymouth theme - it's *similar* to ours, unlike the Fedora and Solar themes, so giving it a shot won't hurt either.

Untar into /usr/share/plymouth/themes and set it with plymouth-set-default-theme OpenSUSE --rebuild-initrd
Comment 34 Donald 2017-05-07 20:22:12 CEST
https://drive.google.com/file/d/0B35tx4Q9SNELMXFJa0dRaTdpak0/view?usp=sharing

Link to OpenSUSE theme
Comment 35 Martin Whitaker 2017-05-07 21:09:39 CEST
(In reply to Donald from comment #33)
> Martin, can you hardlink a copy of the appropriate background.png from
> /usr/share.mga/background into /usr/share/plymouth/themes/Mageia-Default and
> rebuild initrd.

That gives the same result

> Here is also a link to the OpenSUSE plymouth theme - it's *similar* to ours,
> unlike the Fedora and Solar themes, so giving it a shot won't hurt either.

That works OK
Comment 36 Donald 2017-05-07 22:16:03 CEST
(In reply to Martin Whitaker from comment #35)
> (In reply to Donald from comment #33)
> > Martin, can you hardlink a copy of the appropriate background.png from
> > /usr/share.mga/background into /usr/share/plymouth/themes/Mageia-Default and
> > rebuild initrd.
> 
> That gives the same result
> 
> > Here is also a link to the OpenSUSE plymouth theme - it's *similar* to ours,
> > unlike the Fedora and Solar themes, so giving it a shot won't hurt either.
> 
> That works OK

I'll rebase on that script then, shouldn't be too hard to get it to work ok.

Could you do one more test for me, replace the background.png in the SUSE theme with a symlink to the default.png in /usr/share/mga/backgrounds, just want to make sure that that isn't interfering at all
Comment 37 Martin Whitaker 2017-05-07 22:35:11 CEST
(In reply to Donald from comment #36)
> Could you do one more test for me, replace the background.png in the SUSE
> theme with a symlink to the default.png in /usr/share/mga/backgrounds, just
> want to make sure that that isn't interfering at all

Yes, that works OK.
Comment 38 Nicolas Lécureuil 2017-05-13 16:53:09 CEST
can we close this bugreport ?

CC: (none) => mageia

Comment 39 Donald 2017-05-13 16:56:57 CEST
No, I'm still working on getting the theme looking right on the new script
Comment 40 Donald 2017-05-13 18:17:37 CEST
can someone with the above bug test this please

https://drive.google.com/file/d/0B35tx4Q9SNELcHR1bmFaNEVVRTA/view?usp=sharing

The Mageia logo and animation scaling are not where it should be. it's more about the background right now. If this has the bug then this will probably need to wait for after release as it will require reworking mga-bg-res system and the backgrounds we ship to have a version at each native resolution.
Comment 41 Martin Whitaker 2017-05-13 18:42:15 CEST
(In reply to Donald from comment #40)
> can someone with the above bug test this please
> 
> https://drive.google.com/file/d/0B35tx4Q9SNELcHR1bmFaNEVVRTA/view?usp=sharing
> 
> The Mageia logo and animation scaling are not where it should be. it's more
> about the background right now. If this has the bug then this will probably
> need to wait for after release as it will require reworking mga-bg-res
> system and the backgrounds we ship to have a version at each native
> resolution.

Works for me, apart from the bubbles. Looks like the cauldron's sprung a leak :-)
Comment 42 Donald 2017-05-13 18:48:27 CEST
(In reply to Martin Whitaker from comment #41)
> (In reply to Donald from comment #40)
> > can someone with the above bug test this please
> > 
> > https://drive.google.com/file/d/0B35tx4Q9SNELcHR1bmFaNEVVRTA/view?usp=sharing
> > 
> > The Mageia logo and animation scaling are not where it should be. it's more
> > about the background right now. If this has the bug then this will probably
> > need to wait for after release as it will require reworking mga-bg-res
> > system and the backgrounds we ship to have a version at each native
> > resolution.
> 
> Works for me, apart from the bubbles. Looks like the cauldron's sprung a
> leak :-)

Great, still at a complete loss as to why you're getting the bug, as this uses the old scaling for the background rather than the SUSE one. 

Just to confirm, the actual size of the image was correct?

I'll fix the placement and animation of the bubbles and upload tonight
Comment 43 Martin Whitaker 2017-05-13 18:52:28 CEST
Yes, the size and aspect ratio looks correct.
Comment 44 Donald 2017-05-16 22:13:14 CEST
Last one to test, should have fixed bubbles and so on.

https://drive.google.com/file/d/0B35tx4Q9SNELdHQwTUpfVVdzWjA/view?usp=sharing
Comment 45 Martin Whitaker 2017-05-16 22:55:35 CEST
That works well on the problem machine, and on my main desktop (with a 1920x1200 display). But the aspect ratio is wrong on an old machine with a 1280x1024 display, and the cauldron is clipped at the bottom of the screen. I can reproduce this in VirtualBox if you want a screenshot.
Comment 46 Martin Whitaker 2017-05-16 23:06:34 CEST
P.S. I assume the new bubble animation is intentional...
Comment 47 Donald 2017-05-16 23:10:11 CEST
Half intentional, it's more me not wanting to change a huge amount as I still have no idea what causes the bug.

Did the 1280x1024 have the correct aspect ratio before?

Will fix the clipping, that's just the new script using a different point fo anchoring the images on the y-axis.
Comment 48 Martin Whitaker 2017-05-16 23:24:28 CEST
(In reply to Donald from comment #47)
> Half intentional, it's more me not wanting to change a huge amount as I
> still have no idea what causes the bug.

Actually I think it works quite well - particularly for the Live DVDs, which with the old scheme generally sit at one bubble for a long time, then go straight to the language choice screen.

> Did the 1280x1024 have the correct aspect ratio before?

Yes. In the last release of mageia-theme, the animated cauldron got much larger, but the aspect ratio was still OK.
Comment 49 Donald 2017-05-16 23:31:01 CEST
(In reply to Martin Whitaker from comment #48)
> (In reply to Donald from comment #47)
> > Half intentional, it's more me not wanting to change a huge amount as I
> > still have no idea what causes the bug.
> 
> Actually I think it works quite well - particularly for the Live DVDs, which
> with the old scheme generally sit at one bubble for a long time, then go
> straight to the language choice screen.

yep, also for long boots with dkms builds and such it will look better.

> 
> > Did the 1280x1024 have the correct aspect ratio before?
> 
> Yes. In the last release of mageia-theme, the animated cauldron got much
> larger, but the aspect ratio was still OK.

Thats worrying that the aspect ration is wrong now, but was ok with the last - I just hope that it is me manually creating the symlink so that it is linking to 1920x1080 now - that won't really show much on 1920x1200.

Yeah the cauldron getting bigger is a side effect of not scaling it like previously, I will fix this for mga7 but it's too big now. Previously, the logo and bubbles were fixed on 1920x1200 images and scaled to fit, so the cauldron was distorted. Now it's not distorted, but increases in size relative to decreasing screen resolutions
Comment 50 Martin Whitaker 2017-05-16 23:38:05 CEST
(In reply to Donald from comment #49)
> Thats worrying that the aspect ration is wrong now, but was ok with the last
> - I just hope that it is me manually creating the symlink so that it is
> linking to 1920x1080 now - that won't really show much on 1920x1200.

Seems to be due to the symlink in the Mageia-test directory:

background.png -> /usr/share/mga/backgrounds/Mageia-Default-3840x2160.png

Changing this to

background.png -> /usr/share/mga/backgrounds/default.png

fixes it (and doesn't break it on the other machine).
Comment 51 Donald 2017-05-16 23:44:57 CEST
Thats a relief, and sorry for that, I must have manually made that link or something.

Will get Akien to commit as my git access is still a mess.

Marking as closed

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

Comment 52 Mageia Robot 2017-05-20 19:53:33 CEST
commit 2fa1b9cb85364c4898ca9fe2e7301e3674936746
Author: Donald Stewart <watersnowrock@...>
Date:   Sat May 20 19:52:47 2017 +0200

    Plymouth: Rework boot animation
    
    Fixes mga#19860 for real.
---
 Commit Link:
   http://gitweb.mageia.org/software/design/theme/commit/?id=2fa1b9cb85364c4898ca9fe2e7301e3674936746