| Summary: | Installer should not check for boot partitions when used to build Live ISOs | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Martin Whitaker <mageia> |
| Component: | Installer | Assignee: | Mageia tools maintainers <mageiatools> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | mageia, mageiatools, thierry.vignaud |
| Version: | Cauldron | Keywords: | PATCH |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | CVE: | ||
| Status comment: | |||
| Attachments: | Proposed fix. | ||
|
Rémi Verschelde
2016-10-03 22:10:49 CEST
Assignee:
bugsquad =>
mageiatools
Thierry Vignaud
2016-10-03 23:04:25 CEST
CC:
(none) =>
mageia, thierry.vignaud Looks good to me, Olivier, Thierry, can you check and potential apply the fix? You can go on Martin, bug please s/$match_all_hardware/$o_match_all_hardware/ The "o_" prefix is important for perl_checker to not warn about bogus bugs about missing parameters in other call sites since this is an optional parameter. commit d043433cefb6a98b2e039972f90398e9edd5d074
Author: Martin Whitaker <mageia@...>
Date: Fri Dec 2 21:02:51 2016 +0000
Skip check for boot partitions when building Live images (mga#19516).
---
Commit Link:
http://gitweb.mageia.org/software/drakx/commit/?id=d043433cefb6a98b2e039972f90398e9edd5d074
Pushed with requested change. Status:
NEW =>
RESOLVED |
Created attachment 8482 [details] Proposed fix. If the draklive script is run on a UEFI-booted system, the 'Partitioning' step fails with the error: "You must have a ESP FAT32 partition mounted in /boot/EFI at /usr/lib/libDrakX/fs/any.pm line 73." This check should not be performed because: a) At that stage, the ESP for the Live ISO has not yet been created. b) draklive should work the same, regardless of the system it is run on. As suggested by blino, this can be fixed by using $o->{match_all_hardware} to detect we are running draklive, and skip this check. Suggested patch attached.