Bug 19227

Summary: Cherrypick kernel commit 65ea11e (Ville Syrjälä - x86/hweight: Don't clobber %rdi) for 4.7.2 (or upgrade to 4.8.0 RCs)
Product: Mageia Reporter: Elmar Stellnberger <estellnb>
Component: RPM PackagesAssignee: Shlomi Fish <shlomif>
Status: RESOLVED FIXED QA Contact: Rémi Verschelde <rverschelde>
Severity: normal    
Priority: release_blocker CC: ennael1, fri, kernel, mageia, marja11, pterjan, shlomif
Version: CauldronKeywords: 6sta1.5
Target Milestone: Mageia 6   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Source RPM: kernel-4.7.2-1.mga6 CVE:
Status comment: We now ship 4.8.2.

Description Elmar Stellnberger 2016-08-21 08:59:33 CEST
I have seen that Mageia6-sta1 does not include commit 65ea11ec6a82b1d44aba62b59e9eb20247e57c6e (Ville Syrjälä - x86/hweight: Don't clobber %rdi), yet as it still ships with kernel 4.6.3. Perhaps it would be best to wait until kernel 4.8.0 is released as this recent commit seems to have resolved a lot of issues. Here are some of the issues reported by me that have been resolved by 65ea11e:

* FreeDesktop Bug 93887 - [NV96] Amilo Xi 3650: G96M [GeForce 9600M GT]: HDMI monitor stays black after s2ram (https://bugs.freedesktop.org/show_bug.cgi?id=93887)
* Kernel Bugs 153371, 153361, 117581 (crash on shutdown, other s2ram bugs).
(* Kernel Bug 88801 now gives a clean backtrace instead of bringing the whole machine down)

  These are just a few. Mark Asselstine has told me about many other issues resolved very likely by the same commit. - and I did not even have time yet to retest for all other issues reported by me.
Elmar Stellnberger 2016-08-21 08:59:46 CEST

Target Milestone: --- => Mageia 6

Comment 1 Marja Van Waes 2016-08-21 11:29:23 CEST
Changing Component to RPM Packages, because if kernel-4.8.0 doesn't get packaged, it won't be on the isos, and when it gets packaged, it'll be on the isos that are released afterwards.

Assigning to all packagers collectively, since the registered maintainer for this went MIA.

@ Shlomi, blino, pterjan

Do you think this should be a release blocker for, at least, the Live DVDs?

@ Shlomi

Can this bug be re-assigned to you?

CC: sysadmin-bugs => ennael1, mageia, marja11, pterjan, shlomif
Component: Release (media or process) => RPM Packages
Source RPM: (none) => kernel-4.7.0-2.mga6
Assignee: bugsquad => pkg-bugs
Keywords: (none) => 6RC

Comment 2 Shlomi Fish 2016-08-22 00:11:19 CEST
Hi all,

(In reply to Marja van Waes from comment #1)
> Changing Component to RPM Packages, because if kernel-4.8.0 doesn't get
> packaged, it won't be on the isos, and when it gets packaged, it'll be on
> the isos that are released afterwards.
> 
> Assigning to all packagers collectively, since the registered maintainer for
> this went MIA.
> 
> @ Shlomi, blino, pterjan
> 
> Do you think this should be a release blocker for, at least, the Live DVDs?
> 

no idea - it seems pretty serious.

> @ Shlomi
> 
> Can this bug be re-assigned to you?

I guess. Can we backport that commit into the 4.7.2 kernel?
Comment 3 Marja Van Waes 2016-08-22 09:47:32 CEST
(In reply to Shlomi Fish from comment #2)
> (In reply to Marja van Waes from comment #1)

> > @ Shlomi, blino, pterjan
> > 
> > Do you think this should be a release blocker for, at least, the Live DVDs?
> > 
> 
> no idea - it seems pretty serious.

Setting to release blocker to avoid missing one.... priority can be lowered later, if esteemed better.
> 
> > @ Shlomi
> > 
> > Can this bug be re-assigned to you?
> 
> I guess. Can we backport that commit into the 4.7.2 kernel?

Thanks a lot! Could you give it a try? (I haven't searched to see whether anyone already backported that commit, though)

Priority: Normal => release_blocker
Assignee: pkg-bugs => shlomif
Blocks: (none) => 15527

Rémi Verschelde 2016-08-29 11:22:36 CEST

Summary: Mageia6-sta1 does not include commit 65ea11e (Ville Syrjälä - x86/hweight: Don't clobber %rdi) => Cherrypick kernel commit 65ea11e (Ville Syrjälä - x86/hweight: Don't clobber %rdi) for 4.7.2 (or upgrade to 4.8.0 RCs)

Rémi Verschelde 2016-08-29 11:22:44 CEST

Source RPM: kernel-4.7.0-2.mga6 => kernel-4.7.2-1.mga6

Comment 4 Shlomi Fish 2016-09-07 16:06:56 CEST
Hi!

The problem fixed by the commit is not present below kernel 4.8-rc1 and we have kernel 4.7.x, see:

<rindolf> Hi all! Does the commit referenced in https://bugs.mageia.org/show_bug.cgi?id=19227 affect kernel 4.7.3? I don't see arch/x86/lib/hweight.S in "git checkout v4.7" or in the tarball, but the commit is older than the tag in the git log. Any help will be appreciated.
<peterz> rindolf: nope, v4.8-rc1
<rindolf> peterz: OK, thanks!

(OFTC, #kernelnewbies )

Closing as INVALID. Thanks!

Status: NEW => RESOLVED
Resolution: (none) => INVALID

Comment 5 Elmar Stellnberger 2016-09-07 16:16:53 CEST
  It has not fixed 'the issue' but rather than this a bunch of issues like also:
https://bugzilla.kernel.org/show_bug.cgi?id=88801
https://bugs.freedesktop.org/show_bug.cgi?id=93887

  At least these two issues have been here with 4.5.0-rc6 and likely also before. I do not know which other issues have been affected; - but obviously not just 'the issue' present since 4.8-rc1.

Resolution: INVALID => (none)
Status: RESOLVED => REOPENED

Comment 6 Elmar Stellnberger 2016-09-07 16:20:29 CEST
  It is correct that 4.8-rcX still has issues; nonetheless I`d still believe that waiting for 4.8.0 could be beneficial at least if you do not have any pressure to release quickly (see also: bug 19266).
Comment 7 Shlomi Fish 2016-09-08 14:56:30 CEST
Hi Elmar,
'
(In reply to Elmar Stellnberger from comment #5)
>   It has not fixed 'the issue' but rather than this a bunch of issues like
> also:
> https://bugzilla.kernel.org/show_bug.cgi?id=88801
> https://bugs.freedesktop.org/show_bug.cgi?id=93887
> 
>   At least these two issues have been here with 4.5.0-rc6 and likely also
> before. I do not know which other issues have been affected; - but obviously
> not just 'the issue' present since 4.8-rc1.

Reading the first link it seems the problem was not fixed by the particular patch in that particular commit directly, but rather was fixed by patches that were applied up to that point. The 65ea11ec6a82b1d44aba62b59e9eb20247e57c6e commit is a fix to an assembly routine that was introduce in 4.8-rc1 and references a file that is not present in the 4.7.x kernels, where a routine written in C was used instead. So we cannot "Cherrypick" it as is.

Please comment.
Comment 8 Elmar Stellnberger 2016-09-11 21:25:39 CEST
ok; if you can not cherrypick it then you can`t. Concerning the first bug (SCM PCMCIA reader) you may get a wrong impression by solely skimming through it as the main issue was in deed resolved by or before 65ea11ec6a...; the backtrace that took so long to be resolved did not cause any functional deficiencies though (and was resolved by a one liner replacing = by |= when setting the flags).
Samuel Verschelde 2016-09-12 15:07:18 CEST

CC: (none) => kernel

Samuel Verschelde 2016-09-12 16:29:24 CEST

Status comment: (none) => Reopened, OP wants us to upgrade to 4.8 when it's out to improve UltraHD support
QA Contact: (none) => rverschelde

Comment 9 Elmar Stellnberger 2016-09-12 17:56:19 CEST
  However I need to confess that I have mainly tested the UltraHD capabilities of kernel 4.7.2 with nouveau and my NVIDIA Corporation G96GLM [Quadro FX 770M]. It is possible that everything works fine with radeon based cards.

  Besides this, some new issues lately appeared to have arosen between 4.8.0-rc1 and 4.8.0-rc4:
* https://bugs.freedesktop.org/show_bug.cgi?id=97614  ... not resolved with rc5+, yet
* https://bugzilla.kernel.org/show_bug.cgi?id=156251  ... might already be resolved though I am not sure about this

  As a consequence I can not guarantee when so far kernel 4.8.x may become sufficiently stable to ship it.
Comment 10 Morgan Leijström 2016-10-15 16:11:46 CEST
Have you tried the 4.8.1 we now have?

CC: (none) => fri

Comment 11 Rémi Verschelde 2016-10-17 11:41:34 CEST
Fixed, we ship 4.8.2.

If it still doesn't work as expected, it should probably be further discussed upstream - we can of course still backport relevant patches when they exist.

Status comment: Reopened, OP wants us to upgrade to 4.8 when it's out to improve UltraHD support => We now ship 4.8.2.
Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Samuel Verschelde 2017-01-17 10:29:39 CET

Blocks: 15527 => (none)