Bug 19224

Summary:	Fish shell (/usr/bin/fish) should be added to /etc/shells
Product:	Mageia	Reporter:	Hook <matija>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	davidwhodgins, jani.valimaa, sysadmin-bugs, tarazed25
Version:	5	Keywords:	validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/fish-shell/fish-shell/issues/669
Whiteboard:	MGA5-64-OK advisory
Source RPM:	fish-2.1.1-2.mga5.src.rpm	CVE:
Status comment:

Description Hook 2016-08-20 23:01:15 CEST

Description of problem:

Fish shell currently cannot be selected as a default shell in either the Mageia Setting GUI nor `chsh`, because it does not exist in the "/etc/shells" file. This is a very annoying bug for a shell.

Upstream considers (rightfully so, I think) this as a downstream/packaging bug.


How reproducible:

Always


Steps to Reproduce:

1. urpmi fish
2. chsh -s `which fish`


Error output:

chsh: "/usr/bin/fish" is not listed in /etc/shells.
Use chsh -l to see list.


Desired outcome:

Be able to select the Fish as a default shell.


Steps to fix:

1. make sure the package adds "/usr/bin/fish" to "/etc/shells" when itâs installed (and removes it when itâs deleted)
2. thatâs it really

Comment 1 Jani Välimaa 2016-08-21 10:44:02 CEST

Pushed fixed fish-2.1.1-2.1.mga5 to core/updates_testing. Please test it.

Test case is very simple:
1. chsh -l and no fish in output
2. update fish
3. chsh -l and fish exists in output
4. remove fish
5. chsh -l and again no fish

CC: (none) => jani.valimaa
Assignee: bugsquad => qa-bugs

Comment 2 Len Lawrence 2016-08-22 08:19:35 CEST

Tested this on x86_64.  Can confirm that the update makes fish available.

CC: (none) => tarazed25

Len Lawrence 2016-08-22 08:20:03 CEST

Whiteboard: (none) => MGA5-64-OK

Dave Hodgins 2016-08-26 01:10:19 CEST

Keywords: (none) => validated_update
Whiteboard: MGA5-64-OK => MGA5-64-OK advisory
CC: (none) => davidwhodgins, sysadmin-bugs

Comment 3 Mageia Robot 2016-08-31 17:33:25 CEST

An update for this issue has been pushed to the Mageia Updates repository.

http://advisories.mageia.org/MGAA-2016-0111.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED