Bug 19172

Summary:	diskdrake no longer gives a "format" option
Product:	Mageia	Reporter:	Frank Griffin <ftg>
Component:	RPM Packages	Assignee:	Thierry Vignaud <thierry.vignaud>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	Normal	CC:	marja11, rbcourt, thierry.vignaud
Version:	Cauldron
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	drakxtools	CVE:
Status comment:

Description Frank Griffin 2016-08-10 20:46:54 CEST

Open diskdrake, select empty space on the drive, select "Create" and create a partition.  The GUI no longer offers a "Format" option in either normal or expert mode, but if you try to quit gives you a popup saying if you don't format it won't be added to fstab.

Marja Van Waes 2016-08-10 22:06:29 CEST

CC: (none) => marja11, thierry.vignaud
Assignee: bugsquad => pterjan
Source RPM: diskdrake => drakxtools

Comment 1 Thierry Vignaud 2016-08-11 17:25:58 CEST

What if you click on another partition tab, then switch back to the new partition?

Keywords: (none) => NEEDINFO

Comment 2 Frank Griffin 2016-08-11 17:35:54 CEST

No effect.  The listed choices are Mount Point, Type, Options, Label, Resize, Delete in expert mode, just Mount Point, Resize, Delete in normal mode.

Switching to a formatted/mounted partition replaces these with View, Unmount in normal mode, but switching back to the unformatted partition just repaints the ones shown above.

Keywords: NEEDINFO => (none)

Comment 3 Thierry Vignaud 2016-08-11 21:32:51 CEST

Probably a side effect of http://gitweb.mageia.org/software/drakx/commit/?id=b772247c03172617edb17f92d9b7b22c09ca9091
I'll check tomorrow

Status: NEW => ASSIGNED
Assignee: pterjan => thierry.vignaud

Comment 4 Frank Griffin 2016-08-16 18:37:52 CEST

If you preformat the partitons you want in a rescue system with mkfs.ext4, the installer accepts them and puts up the list of potential disks to format.  It then formats them correctly and proceeds with the install.

Comment 5 Robert Courtright 2016-11-13 23:54:34 CET

I closed down diskdrake and then used gparted to format the partition.
I then open diskdrake to label and mount it.

CC: (none) => rbcourt

Comment 6 Thierry Vignaud 2016-11-14 09:35:24 CET

*** Bug 19773 has been marked as a duplicate of this bug. ***

Comment 7 Thierry Vignaud 2016-11-14 17:49:44 CET

Indeed it's that commit.
Fixing in progress

Comment 8 Mageia Robot 2016-11-15 12:16:04 CET

commit 84405a3bde840a526b4bea650fbe69963a900ef5
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Mon Nov 14 16:41:25 2016 +0100

    warn when an action condition is bogus (mga#19172)
    
    thus showing we were using an unexported function for format test
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=84405a3bde840a526b4bea650fbe69963a900ef5

Comment 9 Mageia Robot 2016-11-15 12:16:06 CET

commit 1a0d446cbcb09c770ad9c341b8f88698bb7339ad
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Tue Nov 15 07:55:37 2016 +0100

    fix being unable to format a newly part (mga#19172)
    
    previous test was using an unexported function
    as a side effect, we now correctly offer to format a unmounted partition
    (eg: when using "noauto" option in /etc/fstab)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=1a0d446cbcb09c770ad9c341b8f88698bb7339ad

Comment 10 Thierry Vignaud 2016-11-15 12:18:53 CET

Fixed in git

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED