Bug 1849

Summary:	Submission fails if previous build is partially finished (i586 build is OK and x86_64 build failed)
Product:	Infrastructure	Reporter:	Jani Välimaa <jani.valimaa>
Component:	BuildSystem	Assignee:	Pascal Terjan <pterjan>
Status:	ASSIGNED ---	QA Contact:
Severity:	normal
Priority:	Normal	CC:	marja11, pterjan, sysadmin-bugs
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:		CVE:
Status comment:
Bug Depends on:
Bug Blocks:	858

Description Jani Välimaa 2011-06-19 09:35:52 CEST

Pkgsubmit site shows that build is failed, but actually it is only partially failed. i586 builds ok and x86_64 fails.

When trying to submit same package again with same rel, I'm getting this:

Submission errors, aborting:
- trustedqsl-1.13-1.mga2.src:
 - Newer revisions already exists for cauldron in upload queue: /var/lib/schedbot/uploads//done/cauldron/core/release/20110618214942.wally.valstar.14586_@109523:trustedqsl-1.13-1.mga2.src.rpm

Same happened twice yesterday (with packages tqsllib and trustedqsl).

Comment 1 Marja Van Waes 2011-10-21 12:22:10 CEST

ping?

CC: (none) => marja11

Nicolas Vigier 2012-01-13 23:11:10 CET

Status: NEW => ASSIGNED
CC: (none) => boklm

Nicolas Vigier 2012-01-13 23:12:08 CET

Blocks: (none) => 858

Comment 2 Pascal Terjan 2012-01-30 00:40:28 CET

ulri bug, built packages for that prefix should be moved from done to failed upon failure of the other arch.

CC: (none) => pterjan

Comment 3 Pascal Terjan 2012-01-30 00:54:22 CET

So, the code exists:
 
foreach my $rpm (@{$ent->{rpms}}) {
    my $file = "$done_dir/${prefix}_$rpm";
    plog('DEBUG', "moving built rpm $file to $fail_dir/${prefix}_$rpm");
    link $file, "$fail_dir/${prefix}_$rpm";
    unlink $file;
}

But $ent->{rpms} is always empty because it gets filled by looking at files named $prefix_*.rpm and built files don't have the prefix.

} elsif ($r =~ /(\d{14}\.\w+\.\w+\.\d+)_(.*\.([^.]+)\.rpm)$/) {
    my ($prefix, $rpm) = ($1, $2);
    plog('DEBUG', "found already built rpm $rpm ($prefix)");
    push @{$pkg_tree{$prefix}{rpms}} , $rpm;
}

Comment 4 Pascal Terjan 2012-01-30 00:58:54 CET

Actually I am wrong, they are correctly prefixed.
The bug is that it does not handle the src.rpm. Fixing.

Pascal Terjan 2012-01-30 00:59:05 CET

Assignee: sysadmin-bugs => pterjan

Comment 5 Pascal Terjan 2012-01-30 01:07:29 CET

Hmm the code to handle the src.rpm is broken and easy to fix, but it should  currently work as the src.rpm is listed as a built rpm (in $ent->{rpms}) so it should be moved...
There is probably another bug in addition to the two bugs I found so far which cancel each other.

Nicolas Vigier 2014-03-24 10:52:48 CET

CC: boklm => (none)