Bug 18316

Created attachment 7719 [details]
net installere introduction pagr

*** Bug 18636 has been marked as a duplicate of this bug. ***

CC: (none) => ftg

Anne & Thomas are the ones that plays most with that part

CC: (none) => ennael1
Assignee: thierry.vignaud => bugsquad

valid for 09 jun

I'm having a look at this one. Looks like a problem on syslinux stage

(In reply to Anne Nicolas from comment #5)
> I'm having a look at this one. Looks like a problem on syslinux stage

Thanks, Anne :-)

Assigning to you, then ;-)

CC: (none) => isobuild
Source RPM: (none) => syslinux

On IRC, Ady said the reason for this issue is there are isolinux/advanced.msg and isolinux/help.msg files (drakx-installer-images) that have color codes (pairs of digit values) that are missing an ASCII 15 character before them.

Those .msg files are generated from xml files (which themselves have not changed) by this script:
http://gitweb.mageia.org/software/drakx/tree/images/make_boot_img

I think this commit broke it:
http://gitweb.mageia.org/software/drakx/commit/images/make_boot_img?id=141b9c7439b8bcc926b640cd524c7d09733159f0

See the line 68 chunk.

Thierry,

Please see Comment 7.  Ady has confirmed that it was indeed your commit that caused this breakage.  Maybe there is something in the text editor you were using that stripped out non-printable ASCII characters from that file?

CC: (none) => thierry.vignaud

Alternatively, perhaps there is a more robust way in Perl to print a non-printable character, as opposed to embedding the character itself in the script.  In Python, I believe it would be chr(15).

commit faa380c2ed0ce9b5094750897db086e058225f2b
Author: Rémi Verschelde <rverschelde@...>
Date:   Thu Sep 8 19:19:49 2016 +0200

    Restore ascii 15 (<SI>) character in syslinux color codes
    
    This was a regression from 141b9c7439b8bcc926b640cd524c7d09733159f0
    which broke color codes in syslinux (mga#18316).
    
    Thanks to Ady and David Walser for finding the fix.
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=faa380c2ed0ce9b5094750897db086e058225f2b

Should be fixed by the above commit (but I did not make a new drakx release, so it won't be fixed in ISOs yet).

(In reply to David Walser from comment #8)
Yeah that line is very sensible and has already had the same very issue in the past.
We often have to patch -2 -R that change before committing....

Status: NEW => RESOLVED
Resolution: (none) => FIXED

drakx-installer-images builds are breaking lately with this "Disk full" error:
http://pkgsubmit.mageia.org/uploads/failure/cauldron/core/release/20160908191257.tv.duvel.45948/log/drakx-installer-images-2.39-1.mga6/build.0.20160908193320.log

Is this because of the disk space issue on rabbit?

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

1) no
2) this is a different issue so please don't reopen that one

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

(In reply to Thierry Vignaud from comment #14)

> 2) this is a different issue so please don't reopen that one

As long as a fix doesn't hit the mirrors, from a user pov it isn't fixed, even if to us it is ;-)

@ LpSolit
@ Stormi

Does it make any sense to open a bug report for an automated way to update a bug report from and to e.g. (when applicable):
   RESOLVED - FIX waits in git
   RESOLVED - FIX waits in svn
   RESOLVED - FIXED 
(and use the latter only when the fix hits the mirrors) ?

If technically possible, would it be worth the extra noise on bugs ml?

CC: (none) => LpSolit, stormi

(In reply to Marja van Waes from comment #15)
> If technically possible, would it be worth the extra noise on bugs ml?

Adding more resolutions brings more confusion IMO. Per https://bugs.mageia.org/page.cgi?id=fields.html, you should set the bug status to VERIFIED when the QA team confirms the fix is deployed and working fine. So the workflow would be:

RESOLVED FIXED -> VERIFIED FIXED

No, it is incorrect to mark a bug as fixed when a fix is only committed in git and not packaged and successfully built.  We've got to stop doing that.

commit fc255781e56bbddf3859e8941e4a3e93eee637fa
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Sep 9 09:41:24 2016 +0200

    add extra space b/c of build issue (mga#18316)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=fc255781e56bbddf3859e8941e4a3e93eee637fa

We have bug 19323 for the build issue, now

*** Bug 19923 has been marked as a duplicate of this bug. ***

CC: (none) => mkare

commit 8f904fa664b953e2f81759dd7597067c8a0a7242
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Mon Dec 12 10:08:41 2016 +0100

    make sure we won't again lost the special char
    
    The ascii 15 (<SI>) special character in syslinux color codes is
    regularly lost b/c of some commands (eg: diff/patch), which broke color
    codes in syslinux (mga#18316).
    
    Just use chr() so that it'll never happen again
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=8f904fa664b953e2f81759dd7597067c8a0a7242

commit 28ba5d2561fb982ccac1cc7bf10d4dc6298ecac2
Author: Thomas Backlund <tmb@...>
Date:   Thu Dec 22 18:57:10 2016 +0200

    Revert "add extra space b/c of build issue (mga#18316)"
    
    This reverts commit fc255781e56bbddf3859e8941e4a3e93eee637fa.
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=28ba5d2561fb982ccac1cc7bf10d4dc6298ecac2