Bug 1824

Summary:	coherence mediaserver must be separate package from python-coherence
Product:	Mageia	Reporter:	Hartmut Goebel <h.goebel>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	Normal	CC:	davidwhodgins, makowski.mageia, sysadmin-bugs, tmb
Version:	1	Keywords:	validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	python-coherence-0.6.6.2-3.mga1.i586.rpm	CVE:
Status comment:

Description Hartmut Goebel 2011-06-16 15:59:38 CEST

The package 'python-coherence' also installs the coherence mediaserver as a running server. This is a problem, since 'python-coherence' is also required by 'upnp-inspector' and 'rhythmbox-upnp'. So if somebody installs one of these packages, he automatically gets a running media server. While
upnp-inspector can bee seen as a developer package, rhythmbox-upnp definitely
is an end-user package. Thus the side-effect of installing a media server is
not desirable.

Having init-scripts and a complete setup for the coherence mediaserver is a very good thing. Thus I suggest to change the packaging like follows:

* 'python-coherence': coherence Python module + docs (/usr/lib/python2.6/site-packages/coherence)
* 'coherence' or 'coherence-mediaserver': everything else from the current package: /usr/bin/coherence, init-script, /etc/coherence/*, /usr/share/dbus-1/services/org.Coherence.service, coherence.conf.example

How to reproduces:

Variant 1 (theoretically):
  urpmq -il python-coherence  | grep -P '^/' | head
  urpmq -il python-coherence  | grep -P '^/' | tail
shows files beside the Python modules (site-packages), esp. init-scripts.

Variant 2 (practical):
  urpmi upnp-inspector # will install python-coherence, to
  rpm -q python-coherence # is installed
  service status coherence # will show coherence media server is running

Hartmut Goebel 2011-06-16 16:00:04 CEST

Target Milestone: --- => Mageia 2

Comment 1 Manuel Hiebel 2011-10-19 23:34:46 CEST

(add the maintainer)

Assignee: bugsquad => makowski.mageia

Philippe Makowski 2011-10-20 08:29:33 CEST

Status: NEW => ASSIGNED

Comment 2 Philippe Makowski 2011-10-20 10:04:02 CEST

hum
about /usr/share/dbus-1/services/org.Coherence.service
it seems that it is need for the Totem plugin 
so it should be in 'python-coherence', not in 'coherence' or 'coherence-mediaserver'


why not simply don't start the media server (service) by default ?

I see also that OpenSuse and Fedora don't provide applet-coherence
and we do, why ?

Comment 3 Philippe Makowski 2011-10-20 10:16:59 CEST

by the way it should be a Buildarch: noarch package

Comment 4 Hartmut Goebel 2011-10-20 11:00:32 CEST

org.Coherence.service starts the Coherence service, too. So this should either be yet another package or part of 'coherence-mediaserver'.

There has to be a clean cut between the library part and the server/service part.

Comment 5 Philippe Makowski 2011-10-21 16:00:17 CEST

as target was Mageia 2, I do not submit update
new packages are build in cauldron

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

Comment 6 Hartmut Goebel 2011-10-22 22:55:30 CEST

@phillipe: Just because somebody has set target ti "Mageia 2" does not imply the problem is solved.

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)
Target Milestone: Mageia 2 => ---

Comment 7 Philippe Makowski 2011-10-24 09:40:55 CEST

you want it as an update in Mageia 1 ?

Comment 8 Hartmut Goebel 2011-10-24 12:19:33 CEST

I personally do not need it in Mageia 1, since I already disabled the server and the dbus-service on my systems.

I'll leave the decicion, whether it's been backported to Mageia 1, to somebody more involded in the project.

Comment 9 Philippe Makowski 2011-10-24 17:48:49 CEST

Update is in testing python-coherence-0.6.6.2-4.mga1

Status: REOPENED => ASSIGNED
Assignee: makowski.mageia => qa-bugs

Comment 10 claire robinson 2011-10-24 18:55:05 CEST

What have you done to it : Advisory?

What should we test : Procedure?

Comment 11 claire robinson 2011-10-24 18:57:08 CEST

ping.. as you were not in CC.

CC: (none) => eeeemail

Comment 12 claire robinson 2011-10-24 18:58:30 CEST

..and ping again /o\ .. now I added the right email to CC!

CC: eeeemail => makowski.mageia

Comment 13 Philippe Makowski 2011-10-24 21:53:55 CEST

if you install 'upnp-inspector' or 'rhythmbox-upnp' you will not have service coherence installed as asked by the bug reporter

Comment 14 Dave Hodgins 2011-10-24 23:48:34 CEST

(In reply to comment #13)
> if you install 'upnp-inspector' or 'rhythmbox-upnp' you will not have service
> coherence installed as asked by the bug reporter

Testing on i586 for the srpm
python-coherence-0.6.6.2-4.mga1.src.rpm

For testing, I started with a minimal install, and then
installed both of the above packages from Core Release,
and /etc/init.d/coherence was created.
Added a local updates repository with just the packages
coherence-applet, coherence-mediaserver, and python-coherence.
Used mgaapplet to update the system, and only python-coherence
was updated.

I then restored the minimal environment, added the
local updates repository and then installed the two
packages.  /etc/init.d/coherence was not created.
I then installed coherence-mediaserver, to ensure it
could be installed.

Did minimal testing of coherence and rhytmbox to ensure they
still actually work.

CC: (none) => davidwhodgins

Comment 15 Hartmut Goebel 2011-10-27 18:53:22 CEST

Thanks for all the work.

I had a look at the packages and discovered that the install/uninstall scripts are still referring to service python-coherence.

Comment 16 Philippe Makowski 2011-10-27 19:02:12 CEST

Sorry ?
I don't understand 

http://svnweb.mageia.org/packages/cauldron/python-coherence/current/SPECS/python-coherence.spec?view=markup

and 

http://svnweb.mageia.org/packages/updates/1/python-coherence/current/SPECS/python-coherence.spec?view=markup

where ?

Comment 17 Hartmut Goebel 2011-10-27 19:15:52 CEST

Sorry, seams as I misunderstood the code:

$ rpm -qp --scripts coherence-mediaserver-0.6.6.2-4.mga1.noarch.rpm
postinstall scriptlet (using /bin/sh):
/usr/share/rpm-helper/add-service python-coherence $1 coherence
                                  ^^^^^^^^^^^^^^^^^
preuninstall scriptlet (using /bin/sh):
/usr/share/rpm-helper/del-service python-coherence $1 coherence
                                  ^^^^^^^^^^^^^^^^^

Comment 18 Philippe Makowski 2011-10-27 20:20:00 CEST

in what you see, python-coherence is the name of the main package
for what I see in the scriptlet, I think that it is not really a problem, since coherence-mediaserver can't be installed without python-coherence

Comment 19 claire robinson 2011-10-28 11:22:19 CEST

Testing x86_64

Before
------

# ls /etc/init.d/c*
/etc/init.d/crond*  /etc/init.d/cups*

# urpmi upnp-inspector
To satisfy dependencies, the following packages are going to be installed:
   Package                        Version      Release       Arch   
(medium "Core Release")
  lib64id3_3.8_3                 3.8.3        19.mga1       x86_64  
  pyid3lib                       0.5.1        12.mga1       x86_64  
  python-clientform              0.2.10       3.mga1        noarch  
  python-coherence               0.6.6.2      3.mga1        x86_64  
  python-epsilon                 0.6.0        2.mga1        noarch  
  python-mechanize               0.2.5        1.mga1        noarch  
  python-nose                    1.0.0        4.mga1        noarch  
  python-pkg-resources           0.6.14       7.mga1        noarch  
  python-sqlite2                 2.5.5        3.mga1        x86_64  
  python-twisted-conch           10.2.0       1.mga1        x86_64  
  python-twisted-core            10.2.0       1.mga1        x86_64  
  python-twisted-lore            10.2.0       1.mga1        x86_64  
  python-twisted-mail            10.2.0       1.mga1        x86_64  
  python-twisted-names           10.2.0       1.mga1        x86_64  
  python-twisted-news            10.2.0       1.mga1        x86_64  
  python-twisted-runner          10.2.0       1.mga1        x86_64  
  python-twisted-web             10.2.0       1.mga1        x86_64  
  python-twisted-words           10.2.0       1.mga1        x86_64  
  python-zope-interface          3.6.1        1.mga1        x86_64  
  upnp-inspector                 0.2.2        3.mga1        x86_64  
(medium "Core 32bit Release")
  pyasn1                         0.0.11a      1.mga1        noarch  
  python-axiom                   0.6.0        2.mga1        noarch  
  python-twisted                 10.2.0       2.mga1        noarch  
16MB of additional disk space will be used.

# ls /etc/init.d/c*
/etc/init.d/coherence*  /etc/init.d/crond*  /etc/init.d/cups*

# rpm -qa | grep coherence
python-coherence-0.6.6.2-3.mga1


After
-----

# ls /etc/init.d/c*
/etc/init.d/crond*  /etc/init.d/cups*

# urpmi upnp-inspector
To satisfy dependencies, the following packages are going to be installed:
   Package                        Version      Release       Arch   
(medium "Core Release")
  lib64id3_3.8_3                 3.8.3        19.mga1       x86_64  
  pyasn1                         0.0.11a      1.mga1        noarch  
  pyid3lib                       0.5.1        12.mga1       x86_64  
  python-epsilon                 0.6.0        2.mga1        noarch  
  python-mechanize               0.2.5        1.mga1        noarch  
  python-sqlite2                 2.5.5        3.mga1        x86_64  
  python-twisted-conch           10.2.0       1.mga1        x86_64  
  python-twisted-core            10.2.0       1.mga1        x86_64  
  python-twisted-lore            10.2.0       1.mga1        x86_64  
  python-twisted-mail            10.2.0       1.mga1        x86_64  
  python-twisted-names           10.2.0       1.mga1        x86_64  
  python-twisted-news            10.2.0       1.mga1        x86_64  
  python-twisted-runner          10.2.0       1.mga1        x86_64  
  python-twisted-web             10.2.0       1.mga1        x86_64  
  python-twisted-words           10.2.0       1.mga1        x86_64  
  python-zope-interface          3.6.1        1.mga1        x86_64  
  upnp-inspector                 0.2.2        3.mga1        x86_64  
(medium "Core Updates Testing")
  python-coherence               0.6.6.2      4.mga1        noarch  
(medium "Core 32bit Release")
  python-axiom                   0.6.0        2.mga1        noarch  
  python-clientform              0.2.10       3.mga1        noarch  
  python-nose                    1.0.0        4.mga1        noarch  
  python-pkg-resources           0.6.14       7.mga1        noarch  
  python-twisted                 10.2.0       2.mga1        noarch  
19MB of additional disk space will be used.

# ls /etc/init.d/c*
/etc/init.d/crond*  /etc/init.d/cups*

# rpm -qa | grep coherence
python-coherence-0.6.6.2-4.mga1

Testing complete x86_64

Comment 20 claire robinson 2011-10-28 11:33:20 CEST

Update validated.

Advisory
---------------
It was found that installing python-coherence, a dependency of upnp-inspector or rhythmbox-upnp, also installed a running coherence mediaserver which may not be desirable.

This update corrects the issue.
---------------

python-coherence-0.6.6.2-4.mga1.src.rpm


Could sysadmin please push from core/updates_testing to core/updates

Thankyou!

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs
Hardware: i586 => All

Comment 21 Thomas Backlund 2011-10-28 11:46:24 CEST

Update pushed.

Status: ASSIGNED => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED