| Summary: | Unable to enter boot password after update of memtest86 | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Nikita Krupenko <krnekit> |
| Component: | RPM Packages | Assignee: | Thierry Vignaud <thierry.vignaud> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | critical | ||
| Priority: | High | CC: | fri, ita84, marja11, thierry.vignaud, zen25000 |
| Version: | Cauldron | Keywords: | PATCH |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | drakxtools-17.28-1.mga6, memtest86+-5.01-9.mga6.src.rpm | CVE: | |
| Status comment: | |||
| Attachments: |
changes after update of memtest
do not overwrite GRUB_CMDLINE_LINUX_DEFAULT once it has been set a better fix a better fix? |
||
|
Description
Nikita Krupenko
2016-04-02 21:09:51 CEST
Assigning to all packagers collectively, since there is no maintainer for this package. CC:
(none) =>
marja11 I really cannot understand this as the only difference between memtest86+-5.01-8 and memtest86+-5.01-9 is two extra Conflicts: against old grub2 and grub2-efi versions that are in Mageia 5, to enable a smooth upgrade to Mageia 6. The package is otherwise unchanged. Were any other packages added or removed by the update transaction, and can you confirm that the versions involved are as above? CC:
(none) =>
zen25000 What boot loader are you using? grub legacy or grub2? Can you save the bootloader config before & after the upgrade (w/o rebooting of course)? For grub, copy /boot/grub/menu.lst For grub2, copy /boot/grub2/grub.cfg Obviously, if there's a password in, replace it with sg like XYZ Keywords:
(none) =>
NEEDINFO Created attachment 7626 [details]
changes after update of memtest
It use EFI boot, so it's grub2-efi. The password is on LVM, that contains root partition.
I attached diff of snapshots before and after package update. I removed from diff some data, that is not related (urpmi changes, logs, etc).
Comment on attachment 7626 [details]
changes after update of memtest
So the issue is that GRUB_CMDLINE_LINUX_DEFAULT disappeared in /etc/default/grub
Created attachment 7627 [details]
do not overwrite GRUB_CMDLINE_LINUX_DEFAULT once it has been set
Can you confirm this is an initial install, aka there was no kernel update before?
Does this patch helps?
You can try it by running the followings commands as root:
cd /usr/lib/libDrakX
patch -p2 < /where/it/was/downloaded/18112.diff
For the record we cannot apply this patch as is b/c grub2-common default to a value for this field, but that would pinpoint the issue. Created attachment 7628 [details]
a better fix
Once you've tested the first patch & reverted, could you test this one?
Thx
After updating memtest there was no kernel updates. After system install there was many kernel updates and no such problem. I'll try your patches. I tested - both patches works. OK, we'll need to do a install with 2nd patch in order it doesn't break initial install Keywords:
NEEDINFO =>
PATCH After recent updates this problem happened again. (In reply to Nikita Krupenko from comment #13) > After recent updates this problem happened again. Yeah, sorry, that was to be expected, the recent drakxtools update reverted the patch you added to /usr/lib/libDrakX/bootloader.pm I understand the patch couldn't be pushed, yet, because it first needs to be tested in installer. Line numbers have changed since Thierry created the patch in attachment 7629 [details] Assignee:
pkg-bugs =>
thierry.vignaud Ok, good to know, that it's known issue. So I should update drakxtools, apply patch and then update other packages? (In reply to Nikita Krupenko from comment #15) > Ok, good to know, that it's known issue. > > So I should update drakxtools, apply patch and then update other packages? You have already updated the drakxtools, that's what caused the issue to reoccur. You'll now have a new /usr/lib/libDrakX/bootloader.pm from ± 5 days ago without the patch. However, despite the changed line numbers, the patch applies cleanly, so I think you can safely use https://bugs.mageia.org/attachment.cgi?id=7628&action=diff&context=patch&collapsed=&headers=1&format=raw again (In reply to Marja van Waes from comment #16) > https://bugs.mageia.org/attachment. > cgi?id=7628&action=diff&context=patch&collapsed=&headers=1&format=raw again that one has the wrong number, I meant this one https://bugs.mageia.org/attachment.cgi?id=7629&action=diff&context=patch&collapsed=&headers=1&format=raw No, I've done rollback of my root system to earlier snapshot, so I update drakxtools and than patch it again. (In reply to Nikita Krupenko from comment #18) > No, I've done rollback of my root system to earlier snapshot, so I update > drakxtools and than patch it again. Ah, of course... you couldn't enter the boot password. Yep, I still didn't find time to test a grub2 initial installation then updates with that patch.
Thierry Vignaud
2016-05-31 14:31:35 CEST
Priority:
Normal =>
High commit da8422ff1d6448480f80f582eaae625c72bd4c26
Author: Thierry Vignaud <thierry.vignaud@...>
Date: Tue May 31 19:21:11 2016 +0200
only overwrite GRUB_CMDLINE_LINUX_DEFAULT on first install (mga#18112)
---
Commit Link:
http://gitweb.mageia.org/software/drakx/commit/?id=da8422ff1d6448480f80f582eaae625c72bd4c26
Fixed in git Status:
ASSIGNED =>
RESOLVED Um, for us affected on a production system, what to do to make it work? I think i should have read the notes on changed files after that update but i did not... and where are they now? compare /etc/grub/default with /etc/grub/default.old, restore your GRUB_CMDLINE_LINUX_DEFAULT, run update-grub2 Thank you Thierry for the quick reply However this system do not have an /etc/grub folder... It use grub, not grub2. It was upgraded from a mga5 system. |