Bug 18066

Summary: MCC main icon doesn't scale up nicely
Product: Mageia Reporter: Timothée Giet <animtim>
Component: RPM PackagesAssignee: Rémi Verschelde <rverschelde>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: marja11, zen25000
Version: Cauldron   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: CVE:
Status comment:
Bug Depends on:    
Bug Blocks: 18068    
Attachments: panel shot
new MCC icon on the right of the old one

Description Timothée Giet 2016-03-25 13:56:51 CET
Description of problem:

The application icon for the MCC is always small or pixelated scaled-up version.
(I'm not 100% sure but I think it uses the icon from control-center/pixmaps/default/splash_screen_about.png )

It should be changed to use an icon with several sizes available (like 24, 32, 48, 64, 128px, maybe 256 too).

The svg base is here:
control-center/pixmaps/svg/drakconf.svg

You can easily export the different sizes from it, or ask me if you really need some help for it.
Manuel Hiebel 2016-03-25 16:15:03 CET

Blocks: (none) => 18068

Comment 1 Barry Jackson 2016-03-28 13:48:57 CEST
This icon really does not work on a panel as it can be too small to understand.
I have tested many installations of cauldron using medium resolution displays and it was not until I expanded the panel height that I could tell what the icon was meant to represent.

When placed on a pale blue panel it is almost invisible as there are no contrasting elements within the icon itself. (The netapplet icon suffers the same when used on a blue or white panel)

Trying to fit the bubbles and the gear in one icon makes both elements too small to recognize.

Maybe this should be re-worked with a bolder symbol.

I thought that maybe something like the KDE 'K gear' icon but using the cauldron shape with gear teeth only on the lower half may work, possibly with two suitable shades of blue to aid contrast on various panel colours. 

WDYT?

Barry

CC: (none) => zen25000

Comment 2 Timothée Giet 2016-03-28 14:50:57 CEST
Ok I see indeed this icon is probably not very visible on a small light blue panel. I'll make a new version with more combined elements and dark + light blue.
Comment 3 Timothée Giet 2016-04-06 14:17:26 CEST
I've updated drakconf icon, and added large and mini versions:
http://gitweb.mageia.org/software/control-center/commit/?id=672056e6f33b2d15bccb4e3d9d8459ebbd757ce5

This should fix this bug.
Comment 4 Barry Jackson 2016-04-06 21:56:19 CEST
Does this now need a rebuild of drakconf?
Comment 5 Timothée Giet 2016-04-07 09:11:26 CEST
Yes, though I have a few more icons fix to do in drakconf, so rebuild can wait a little for those too. I'll try to finish work on it today.
Comment 6 Timothée Giet 2016-04-12 14:40:29 CEST
Fixed, see comment 3.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 7 Rémi Verschelde 2016-04-12 18:45:48 CEST
Just pushed drakconf 13.5 with the above mentioned changes in Cauldron.
Comment 8 Barry Jackson 2016-04-13 00:03:22 CEST
Created attachment 7661 [details]
panel shot

I see no change here did something get missed?

The panel icon is the same as before. :(

[baz@jackodesktop ~]$ rpm -q drakconf
drakconf-13.5-1.mga6

I deleted /var/tmp/kdecache-baz just to be sure it was not being cached.
Barry Jackson 2016-04-13 00:04:29 CEST

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 9 Marja Van Waes 2016-04-13 08:21:08 CEST
Created attachment 7662 [details]
new MCC icon on the right of the old one

Confirming that drakconf-icons-13.5-1.mga6.noarch.rpm does _not_ contain the new MCC icon.

It has been (or still is) in git, though: I had manually retrieved it from git and replaced the old icon with it, after Timothée pushed it to git, it is the one on the right of the old MCC icon (that is still used for manatools) in the attached screenshot.

After installing drakconf-icons-13.5-1.mga6.noarch.rpm and starting a new Plasma5 session, the old icon is back :-(

I haven't checked whether the new icon is still in git.

CC: (none) => marja11

Marja Van Waes 2016-04-13 08:21:30 CEST

Assignee: bugsquad => rverschelde

Comment 10 Marja Van Waes 2016-04-13 08:22:34 CEST
sorry for using the word "old" for both "older" and "oldest" :-/
Comment 11 Rémi Verschelde 2016-04-13 08:39:07 CEST
Yeah it looks like the icons are in git but without any instructions to install them.

@Timothée: Could you clarify which icons should go where? I see that there are icons in `pixmaps/default`, `pixmaps/svg` and `pixmaps/icons`, the latter with only the drakconf icons. Then there are also the `drakconf{16,32,48}.png` icons (which seem to be new).

I'll have a closer look when I have some time, the spec file for drakconf is a bit messy and does some of the work that the Makefiles are supposed to do.
Comment 12 Timothée Giet 2016-04-13 09:17:19 CEST
I added some infos in the related commit message, but here are some more instructions:

-pixmaps/default contains most of the icons used inside mcc (at least those for which the icon is not in a separate repo.). Those icons all are 48px and 128px png files.

-pixmaps/svg contains the sources for the icons in default. Note that those svg could be used directly instead of the .png files, though I leave it to someone more involved in the code and packaging part to change this.

-pixmaps/icons contains the new icon of drakconf, with several sizes and with the svg source. Here again, the svg can probably be used directly...

note: the old drakconf icon was the file splash_screen_about in default, I updated it too though this file can be removed if the drakconf icon can be directly used instead.
Comment 13 Barry Jackson 2016-04-13 12:45:03 CEST
(In reply to Marja van Waes from comment #9)
> Created attachment 7662 [details]
> new MCC icon on the right of the old one
> 
Hmm.. So it's a pretty blue flower in the wind, or on a pale blue panel it will be a small dark blue dot with white ears :(

I know icon design is not easy and I probably could do no better, but that is my first impression.

Offering support will now change from "click on the moustache icon" to "click on the blue flower", or the wonky bunny. :)

I really see no real reason to use the 'flat' style for a panel icon which is used alongside other 'traditional' icons.

Since we have no control over the background or display size in this use case then I think that some colour and real contrast is needed to make it more meaningful.

My 2 pence.

Barry
Comment 14 Timothée Giet 2016-04-14 16:36:33 CEST
Following Barry's comment, I've update again the icon in the sources.

http://gitweb.mageia.org/software/control-center/commit/?id=10d070e33ebe779e277dd400d30152506ba839c7

Please update the package
Comment 16 Barry Jackson 2016-04-14 18:10:04 CEST
Yes that is much better.
The background colour will be less troublesome now.
My only concern is that it is the same shape as Fedora's logo:
https://getfedora.org/

If only the cauldron shape could be incorporated somehow. :)

I had a little play - maybe something like:

http://mtf.no-ip.co.uk/pub/linux/barjac/tests/drakconf_barjac.png

The bubbles would vanish on a dark background, so maybe just lose the bubbles?

Not sure.
Comment 17 Timothée Giet 2016-04-14 18:54:49 CEST
Well, it is still different from Fedora's logo as the shape is on the other side.
Also, this is a quite common icon shape, not as common as circle or square but still..

About giving it a cauldron shape, since I already used the cauldron shape for all package-related entries in mcc, I'd prefer to have a different one to make things more clear. (and imho having a differently-styled cauldron shape there would also be bad for style consistency)
Comment 18 Barry Jackson 2016-04-15 00:16:51 CEST
(In reply to Timothée Giet from comment #17)
> Well, it is still different from Fedora's logo as the shape is on the other
> side.

Well only upside down - still instantly says Fedora to me...

> Also, this is a quite common icon shape, not as common as circle or square
> but still..

Which is why I think it should be uncommon and 'Mageia' shape.

> 
> About giving it a cauldron shape, since I already used the cauldron shape
> for all package-related entries in mcc, I'd prefer to have a different one
> to make things more clear.

How does different make it clearer?

> (and imho having a differently-styled cauldron
> shape there would also be bad for style consistency)

It's only differently styled in that it has been rotated a little - after all that's what the gear is for, and MCC, to adjust settings.

Ah well, it made sense to me :)
Comment 19 Timothée Giet 2016-04-15 18:24:23 CEST
Ok, can we have more opinions about this last version?
link reminder:
http://gitweb.mageia.org/software/control-center/plain/pixmaps/icons/large/drakconf.png?id=10d070e33ebe779e277dd400d30152506ba839c7

I personnally don't think about Fedora when looking at it, but if several other people do I'll change it.

I made a few experiments, and the other icon background that could work visually, besides current one, would be a simple square with rounded corners. That would also give the focus to the icon content (the gear and bubbles) rather than on the background shape.
Comment 20 Marja Van Waes 2016-04-16 10:05:27 CEST
I don't have a problem with the shape. It reminds me of the shapes of several icons on my phone, which isn't a Fedora phone ;-) 

That shape is apparently, just like many other shapes, used by several projects.
Comment 21 Manuel Hiebel 2016-04-16 20:17:31 CEST
Really nice, I did't see the fedora logo too :)
Comment 22 Timothée Giet 2016-04-19 20:10:30 CEST
Considering all the comments about it, I think we can keep this last version.
Comment 23 Barry Jackson 2016-05-11 12:39:07 CEST
So what happened to this?
Comment 24 Timothée Giet 2016-05-11 13:04:08 CEST
Hmm, the right icon is in drakconf master branch since a month,
and version 13.6 has been tagged and packaged since then.
However, it looks like the package still has the previous version.
There's something wrong there.

By the way on a side note, I noticed some icons are packaged in drakconf and others in drakconf-icons.. Shouldn't they all go in drakconf-icons?
Comment 25 Mageia Robot 2016-05-28 19:23:21 CEST
commit 99201be1aecae611417004b9c6a5be39b16be304
Author: Rémi Verschelde <rverschelde@...>
Date:   Sat May 28 18:09:10 2016 +0200

    Drop obsolete drakconf icons (mga#18066)
---
 Commit Link:
   http://gitweb.mageia.org/software/control-center/commit/?id=99201be1aecae611417004b9c6a5be39b16be304
Comment 26 Mageia Robot 2016-05-28 19:23:23 CEST
commit 9d4e41ec40f97ba21f7737191f83156384404020
Author: Rémi Verschelde <rverschelde@...>
Date:   Sat May 28 18:15:19 2016 +0200

    Install drakconf icon to hicolor (with SVG)
    
    Allows to use scalable graphics unlike icons/{,large,mini} (mga#18066)
---
 Commit Link:
   http://gitweb.mageia.org/software/control-center/commit/?id=9d4e41ec40f97ba21f7737191f83156384404020
Comment 27 Mageia Robot 2016-05-28 20:03:31 CEST
commit 0228ab606b3ecefcca3ec52def58d09b55a0d6ed
Author: Rémi Verschelde <rverschelde@...>
Date:   Sat May 28 19:54:10 2016 +0200

    Pack a 128px icon for the GTK+3 window (mga#18066)
    
    Use the SVG was tried but did not seem to work out of the box
    (icons were very pixelated). Thus adding a 128px icon as window
    icon, since it is used at least by Plasma for high-res previews.
    
    Also dropping the smaller 20x20 and 32x32 icons that nothing uses.
---
 Commit Link:
   http://gitweb.mageia.org/software/control-center/commit/?id=0228ab606b3ecefcca3ec52def58d09b55a0d6ed
Comment 28 Rémi Verschelde 2016-05-28 20:09:55 CEST
Should finally be fixed in drakconf-13.7-1.mga6.

Note that some DEs (at least Plasma) seem to cache icons, so you might have to wait a while/find out how to clean the cache to see the new icon (or try in a clean user environment).

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

Comment 29 Barry Jackson 2016-05-29 13:17:10 CEST
(In reply to Rémi Verschelde from comment #28)
....find out how to clean the cache...

Easier said than done! I tried removing the /var/tmp/ kde caches with no effect. After much digging I finally managed to get the new icon to display correctly everywhere by:-

switch to tty2
log in as root
systemctl stop prefdm
switch back to tty2 as the previous command switches to tty1
mv /home/<username>/.cache /home/<username>/.cache_old
systemctl restart prefdm

Maybe save someone else an hour of frustration!
I did not see any undesirable effects of doing this but WMMV ;)