Bug 17886

Summary: isodumper: Changing destination-dir resets filename
Product: Mageia Reporter: Hartmut Goebel <h.goebel>
Component: RPM PackagesAssignee: papoteur <yvesbrungard>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: geiger.david68210
Version: 5Keywords: Junior_job, PATCH
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: isodumper-0.44-1.mga5.src.rpm CVE:
Status comment:
Attachments: patch solving this isse

Description Hartmut Goebel 2016-03-06 12:40:59 CET 
Description of problem:

When clicking the button for selecting the destination of an image to backup a again, the filename is reset.

How reproducible: always

How to reprocude.

- Start isodumper
- Select some target device (you need o have on attached, of course)
  For this example, let's assume, the is a "SanDisk Cruzer Blade".
- in the "Backup in" area click the button "(None)" for selecting a destination
- In the upcoming requester:
  - The filename will be preset with "SanDiskCruzerBlade.img" (which is okay)
  - Select some destination (e.g. "/tmp/foo.img", the name does not matter here) and click "Select"
- The button in the "Backup in" is now labeled with the basename of the file (e.g. "foo.img")
- No click this button again.
- In the upcoming requester, the filename again is preset with "SanDiskCruzerBlade.img".

-> I'd expect the filename to be preset with "foo.img"

Interestingly, the *path*, which has been selected first, is kept.
Comment 1 Hartmut Goebel 2016-03-06 12:41:40 CET 
Created attachment 7518 [details]
patch solving this isse

This simple patch solved the issue.
Hartmut Goebel 2016-03-06 12:42:00 CET

Keywords: (none) => Junior_job, PATCH

Rémi Verschelde 2016-03-06 13:06:46 CET

CC: (none) => geiger.david68210
Assignee: bugsquad => yves.brungard_mageia

Comment 2 Mageia Robot 2016-03-06 17:20:21 CET 
commit 432fdc763ee774446baf3ae95a47e8fbe545fbe3
Author: Papoteur <papoteur@...>
Date:   Sun Mar 6 13:52:39 2016 +0100

    Keep the file name for backup when selecting it again (mga#17886)
---
 Commit Link:
   http://gitweb.mageia.org/software/isodumper/commit/?id=432fdc763ee774446baf3ae95a47e8fbe545fbe3
Comment 3 Hartmut Goebel 2016-03-06 18:49:07 CET 
Thanks for fixing that quick :-)
papoteur 2016-03-06 20:49:13 CET

Summary: isodumper: Changing destinaction-dir resets filename => isodumper: Changing destination-dir resets filename

Comment 4 Mageia Robot 2016-04-07 22:00:12 CEST 
commit b9cd8ba23897d215d507f9e096d072fd9d54de20
Author: Papoteur <papoteur@...>
Date:   Sun Mar 6 13:57:57 2016 +0100

    Keep the backup file name when defining it again (mga#17886)
---
 Commit Link:
   http://gitweb.mageia.org/software/isodumper/commit/?id=b9cd8ba23897d215d507f9e096d072fd9d54de20
Comment 5 papoteur 2016-07-23 09:49:17 CEST 
See previous comments

Status: NEW => RESOLVED
Resolution: (none) => FIXED