Bug 17617

Confirming, that in the "Set up autologin to automatically log in" screen, only "default" can be chosen.

CC: (none) => marja11
Assignee: bugsquad => thierry.vignaud
Source RPM: (none) => drakxtools

Created attachment 7451 [details]
A patch to modify chksession behaviour

Hi,

As chksession no longer needs to generate files from "/etc/X11/wmsession.d", I propose a patch to modify chksession behaviour:
- Remove all generation options.
- Modify how the list of possible sessions is created by using "/usr/share/xsessions" instead of "/etc/X11/wmsession.d" and putting IceWM as the last option.

Best regards,

Nico.

Putting IceWM looks incorrect.  According to the wmsession.d files in Mageia 5, it appears it should only be after the "main" DEs, but before all of the niche ones.

Does /usr/share/xsessions have any provision for specifying an ordering, or do we have to hardcode it into the chksession script?

For reference, here is the ordering from Mageia 5:

/etc/X11/wmsession.d/01KDE
/etc/X11/wmsession.d/02GNOME
/etc/X11/wmsession.d/02Plasma
/etc/X11/wmsession.d/03GNOME_CLASSIC
/etc/X11/wmsession.d/03WindowMaker
/etc/X11/wmsession.d/04LXDE
/etc/X11/wmsession.d/06Xfce
/etc/X11/wmsession.d/07IceWM
/etc/X11/wmsession.d/09fvwm2
/etc/X11/wmsession.d/10cinnamon
/etc/X11/wmsession.d/10fvwm-crystal
/etc/X11/wmsession.d/10MATE
/etc/X11/wmsession.d/11cinnamon2d
/etc/X11/wmsession.d/12swm
/etc/X11/wmsession.d/13LXQT
/etc/X11/wmsession.d/15afterstep
/etc/X11/wmsession.d/15Kodi
/etc/X11/wmsession.d/16fluxbox
/etc/X11/wmsession.d/19awesome
/etc/X11/wmsession.d/22Matchbox
/etc/X11/wmsession.d/23E18
/etc/X11/wmsession.d/26openbox
/etc/X11/wmsession.d/30pekwm
/etc/X11/wmsession.d/31i3
/etc/X11/wmsession.d/40dwm
/etc/X11/wmsession.d/41spectrwm
/etc/X11/wmsession.d/99MythFrontend

CC: (none) => luigiwalser

Regarding IceWM, I did that to also solve bug 17554 but that bug was solved without the need of that patch so I think that the patch could be stripped from the part corresponding to IceWM.

*** Bug 18681 has been marked as a duplicate of this bug. ***

commit 0a47f2c60d821432a22c3c4eb0df1022bc92d32a
Author: Nicolas Salguero <nicolas.salguero@...>
Date:   Sat Aug 13 01:00:01 2016 +0200

    stop generating session files (mga#17617)
---
 Commit Link:
   http://gitweb.mageia.org/software/desktop/common-data/commit/?id=0a47f2c60d821432a22c3c4eb0df1022bc92d32a

commit a8aec7a0e6f505ed750ce61991012d6d47cc7bda
Author: Nicolas Salguero <nicolas.salguero@...>
Date:   Sat Aug 13 01:02:31 2016 +0200

    use sessions from /usr/share/xsessions/ (mga#17617)
    
    instead of from /etc/X11/wmsession.d/
    v2 (Thierry Vignaud):
    - prune useless stuff (removed by earlier perl_checker commit)
    - do not reparse twice the directory, just keep the existing order logic
      (which is slowly going towards /dev/null)
---
 Commit Link:
   http://gitweb.mageia.org/software/desktop/common-data/commit/?id=a8aec7a0e6f505ed750ce61991012d6d47cc7bda

Fixed in git.
I've:
- split your changes in 2 logical commits
- remove useless variables
- kept the previous logic
- excluded the icewm sort

Resolution: (none) => FIXED
Status: ASSIGNED => RESOLVED

Installing this update has broken IceWM completely.  When logging into it, it immediately sends me back to the login screen (xdm in this case).

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)
Severity: normal => critical

I just built desktop-common-data 6.1 locally and confirmed that reverting to that makes IceWM runnable again.

Created attachment 8348 [details]
patch to fix chksession

I attached a patch that fixes chksession.  It restores the -x option and setting the $script{$xession} variable, which is needed as /etc/X11/Xsession still makes use of these.

Once that's applied, /etc/X11/xinit.d/xdg-autostart needs to be fixed to say IceWM instead of icewm, and it will work.

The only thing left that hasn't been handled correctly here as far as I can tell is the ordering.

Various display managers also support wayland sessions; they're in a different directory.

CC: (none) => olav

Just commit your fix and ask for a freeze exception...

Sorry, I don't know how to commit for software.

commit 46e66c480c4447e014c51e7283f24186e4978a62
Author: daviddavid <geiger.david68210@...>
Date:   Tue Aug 23 17:59:40 2016 +0200

    fix chksession from David Walser (mga#17617)
---
 Commit Link:
   http://gitweb.mageia.org/software/desktop/common-data/commit/?id=46e66c480c4447e014c51e7283f24186e4978a62

desktop-common-data and xdg-compliance updates submitted, which should fix some issues and IceWM should work correctly.

The only remaining issue here that I know of is that we no longer have a mechanism for ordering, which is used to choose a correct default when multiple desktops are installed but no preferred one is listed in /etc/sysconfig/desktop.

(In reply to David Walser from comment #16)
> The only remaining issue here that I know of is that we no longer have a
> mechanism for ordering, which is used to choose a correct default when
> multiple desktops are installed but no preferred one is listed in
> /etc/sysconfig/desktop.

That would be bug 19234 (so maybe this one could be closed and  bug 19234 upgraded to release blocker, or the other way around, as you prefer).

Yeah let's make each bug report target a specific issue.
This one was about chksession no more listing sessions

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED