Bug 17616

After more tests:

1) It appears that autologin succeeds but the user's session is closed just after (from what I see with the command "journalctl -b -0 -o verbose").

2) The problem does not seem to come from the Cauldron version of LXDM because, in a Mga5 VM, I rebuilt and installed the package coming from Cauldron and I had no problem with autologin.

So I think that it may be a side effect of bug 17617.

Created attachment 7399 [details]
A patch to add support for configuring /etc/lxdm/lxdm.conf

I saw this in /var/log/autologin.log:
"""
X: Only console users are allowed to run the X server
xinit: giving up
xinit: unable to connect to X server: Connection refused
xinit: server error
Impossible d'obtenir le descripteur de fichier faisant référence à la console
"""

This is why the "direct method" using startx is not working anymore.

But, with the file /etc/lxdm/lxdm.conf, it is possible to configure autologin so I wrote a patch that add support for configuring /etc/lxdm/lxdm.conf in drakautologin.

Created attachment 7405 [details]
Improved version of the patch

I improved the patch:
- lxdm is removed from "is_standalone_autologin_needed"
- lxdm use, for autologin, the session which was chosen in drakautologin

Attachment 7399 is obsolete: 0 => 1

Created attachment 7406 [details]
Real improved version

I forgot a correction in "get_autologin()"

Attachment 7405 is obsolete: 0 => 1

Created attachment 8342 [details]
rebased on master + pass perl_checker

Attachment 7406 is obsolete: 0 => 1

Created attachment 8343 [details]
same as previous but use find ()

Can you test those patches?

I guess lxdm expect the filename of the desktop file in /usr/share/xsessions, without the extension?

Note that I wrongly commented one line
BTW why do you set lang=?

Sadly, whereas it works fine for Plasma & GNOME, it doesn't for GNOME Classic

GNOME Classic might be a chksession issue (we probably have to release a 6.3 bugfix to the pending 6.2 release)

commit 11ae13b95669baae4bff3364bcd53a3dd05a75a8
Author: Nicolas Salguero <nicolas.salguero@...>
Date:   Sat Aug 13 02:58:42 2016 +0200

    add support for LXDM (mga#17616)
    
    need desktop-common-data-6.2+
    perl_checker cleanups by Thierry Vignaud
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=11ae13b95669baae4bff3364bcd53a3dd05a75a8

Fixed in git.
Note that the bug really is that the autologin package doesn't work anymore (for unsupported DMs)...

Source RPM: drakxtools => autologin
Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

Hi,

I found that disabling autologin does not work for LXDM because this code :
"""
    eval { update_gnomekderc($lxdm_conffile, 'base' => (
	if_($autologin->{user}, 'autologin' => '@' . $autologin->{user})
    ));
"""
lacks an "else" piece of code that should set autologin to an empty string, as in this code :
"""
    eval { update_gnomekderc($lxdm_conffile, 'base' => (
	'autologin' => $autologin->{user} ? '@' . $autologin->{user} : $autologin->{user}
    ));
"""

Best regards,

Nico.

Resolution: FIXED => (none)
Status: RESOLVED => REOPENED

can you provide a patch so thierry can review it please.

CC: (none) => mageia

I proposed a solution for that problem in comment 12 (but I am not an expert of Perl so, even if it works, it may need to be reworked).

can you checkout http://gitweb.mageia.org/software/drakx and provide a real git patch please ?

Created attachment 8632 [details]
A patch to allow disabling autologin in LXDM

(In reply to Nicolas Lécureuil from comment #15)
> can you checkout http://gitweb.mageia.org/software/drakx and provide a real
> git patch please ?

Here it is

thierry, can you review it please ?

CC: (none) => thierry.vignaud

Comment on attachment 8632 [details]
A patch to allow disabling autologin in LXDM

The following looks saner:
'autologin' => $autologin->{user} ? '@' . $autologin->{user} : ''

If I understand correctly all we need now is to apply the patch. Let's do it?

commit b2b7472f3279ce50c5be7590522715782ad4313c
Author: Nicolas Salguero <nicolas.salguero@...>
Date:   Thu Dec 1 16:37:34 2016 +0100

    allow disabling autologin on LXDM (mga#17616)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=b2b7472f3279ce50c5be7590522715782ad4313c

I've not received any test on the reviewed patch in one month but here it goes

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

(In reply to Thierry Vignaud from comment #21)
> I've not received any test on the reviewed patch in one month but here it
> goes

In this case I'll leave the bug report open until someone confirms that the new version works. Do you plan to push a new version of drakxtools soon?

Status comment: Patch being reviewed => Fixed, needs testing
Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Please don't reopen.
The suggested change is small and the fix is in git.
As we're discussing, it would be better to add a next step such as VERIFIED in the bz life cycle

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

(In reply to Thierry Vignaud from comment #23)
> Please don't reopen.
> The suggested change is small and the fix is in git.
> As we're discussing, it would be better to add a next step such as VERIFIED
> in the bz life cycle

Well, for most bugs I would agree with not reopening and just letting users confirm but since here it's one of the release blockers (although arguably could have been demoted) it made sense to keep the bug report open and let either testers or those who review the blockers close it once made sure. When you close it, it disappears from the list of blockers, so I would have appreciated if we could have kept it open for a few days. I would have personnally made sure it's closed quickly. However I'll not start a fight so I leave it closed.

Testers, please test and confirm or reopen if it doesn't work.