Bug 16906

Summary:	Cherry-picking broken when sorting updates by version number in drakrpm-update
Product:	Mageia	Reporter:	Rémi Verschelde <rverschelde>
Component:	RPM Packages	Assignee:	Mageia tools maintainers <mageiatools>
Status:	NEW ---	QA Contact:
Severity:	major
Priority:	High	CC:	fri, jyri2000, marja11, ouaurelien, thierry.vignaud
Version:	Cauldron	Keywords:	USABILITY
Target Milestone:	Mageia 7
Hardware:	All
OS:	Linux
Whiteboard:	MGA5TOO MGA6TOO
Source RPM:	rpmdrake-6.20-1.mga5	CVE:
Status comment:

Description Rémi Verschelde 2015-10-05 09:53:14 CEST

I think I've had this bug since at least Mageia 4, maybe earlier (could be a fallback of the GTK+3 port).

When sorting packages by version in drakrpm-update / MageiaUpdate, cherry-picking does not work reliably. If you click on a specific package that has dependencies to install, it will notify you about it, but clicking OK won't select the mentioned dependencies.

If you manage in the end to select all packages that you want to cherry-pick, clicking install will propose only a subset of what you actually selected (and maybe even random other updates that you did not select IIRC).

Maybe the backend does not know that the list is sorted by version, and tries to match positions in the list with the list sorted by name or something like that?


To reproduce, in current mga5:
1. Activate and update testing repos, and mark them as update media (drakrpm-editmedia)
2. Start MageiaUpdate
3. Unselect everything
4. Click on "Version" to sort by versions
5. Try to select all packages of a given version and install them (e.g. systemd 217 in current mga5).

Reproducible: 

Steps to Reproduce:

Comment 1 Rémi Verschelde 2015-10-05 09:55:35 CEST

I'm assuming that the issue is also valid in Cauldron as there haven't been many changes to rpmdrake in git since version 6.20.

Setting as a release_blocker for now to make sure we try to fix it for Mageia 6.

Blocks: (none) => 15527
Whiteboard: (none) => MGA5TOO
Keywords: (none) => USABILITY
Priority: Normal => release_blocker
Version: 5 => Cauldron

Comment 2 David Walser 2015-10-13 23:18:39 CEST

Really there is a fundamental flaw in the design of MageiaUpdate, as it should not allow you to cherry pick some subpackages but not others that are built from the same SRPM.  The checkboxes it should show you should only be for the *SRPM* names of the updateable packages, allowing you to select or deselect those, and for the selected ones, it'll upgrade all subpackages built from that selected package that are installed.  If deemed desirable, when you click on one of the SRPM rows, it could in the interface display a list of the actual RPM names it will be updating if chosen.

Comment 3 Jüri Ivask 2015-11-09 09:09:51 CET

Yes, it is valid in Cauldron also.
When you for example unselect some package for updating a message is displayed that it's dependencies are unselected too, but this is not reflected by removing their tickmarks - they remain displayed as selected for update.

CC: (none) => jyri2000

Comment 4 Marja Van Waes 2016-07-12 17:47:39 CEST

Moving to a mga7 tracker (it is still allowed to fix this bug now, though ;-) )

Blocks: 15527 => 18932
CC: (none) => marja11

Comment 5 Samuel Verschelde 2016-09-12 16:49:49 CEST

Not a release blocker since it can be fixed afterwards, although would be nice to get finally fixed.

Assignee: thierry.vignaud => mageiatools
Priority: release_blocker => High
CC: (none) => thierry.vignaud

Samuel Verschelde 2016-10-10 23:25:09 CEST

Whiteboard: MGA5TOO => MGA5TOO MGA6TOO
Target Milestone: --- => Mageia 7

Samuel Verschelde 2016-11-10 10:36:01 CET

Blocks: 18932 => (none)

Comment 6 Aurelien Oudelet 2020-09-19 18:09:00 CEST

Hi,
This is High priority bug for a good reason.

Making Mageia even better than ever is best direction.
In order to do right thing, this bug should be examined and fixed as soon as possible.

Packagers, please make the status to Assigned when you are working on this.
Feel free to reassign the bug if bad-triaged. Also, if bug is old, please close it.

On October 1st 2020, we will drop priority to normal.

Comment 7 Aurelien Oudelet 2020-12-13 12:06:19 CET

Reproduced. This is totally broken. The checkbox are still selected.

Sometimes, when the list of proposed updates is not too long, cherry-picking seems OK and the proposed list is updated when clicking on "Update".

When you want to un-select too many packages, this is broken and clicking "Update" selects all available updates even the ones you previously un-selected.

When I do want to exclude Libreoffice to be updated, clicking on checkbox to unselect give me alerts on needing to unselect other packages in order to satisfy dependencies (which is expected beahviour) but right after, named packages in previous dialog are still selected. So, continuously click to unselect packages results in dialog to select/unselect automatically to satisfy dependencies.

CC: (none) => ouaurelien

Morgan Leijström 2020-12-13 20:38:03 CET

CC: (none) => fri