Bug 16888

Summary:	userdrake shows UID=500 by default when creating new users
Product:	Mageia	Reporter:	papoteur <yvesbrungard>
Component:	RPM Packages	Assignee:	Mageia tools maintainers <mageiatools>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	Normal	CC:	anaselli, doktor5000, thierry.vignaud
Version:	Cauldron	Keywords:	6sta1
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	MGA5TOO
Source RPM:	drakxtools	CVE:
Status comment:

Description papoteur 2015-10-03 20:56:44 CEST

Description of problem:
Create a user says "500" (in grey) as UID after "Specify user ID manually". If we check this line, 500 is set by default too.
However, when not set manually, the new user is 1001.



Reproducible: 

Steps to Reproduce:

Rémi Verschelde 2015-10-03 21:35:00 CEST

Assignee: bugsquad => thierry.vignaud
Source RPM: (none) => drakxtools

Comment 1 Florian Hubold 2015-10-10 21:51:08 CEST

Verified here, seems it does not respect UID_MIN from /etc/login.defs ... ?

In /etc/libuser.conf are also only the defaults:

$ sudo grep -B1 LU_UIDNUMBER /etc/libuser.conf
# This is better imported from /etc/login.defs:
# LU_UIDNUMBER = 500

/etc/sysconfig/userdrake only contains FILTER=true


Problem also occurs in current cauldron with userdrake-2.10-3.mga6

CC: (none) => doktor5000
Hardware: i586 => All
Version: 5 => Cauldron
Summary: Creating a new user display by default 500 => userdrake shows UID=500 by default when creating new users
Whiteboard: (none) => MGA5TOO

Comment 2 Dick Gevers 2016-05-26 18:37:14 CEST

Valid for 6sta1

Keywords: (none) => 6sta1

Comment 3 Samuel Verschelde 2016-09-12 14:40:10 CEST

I can confirm it's still valid.

CC: (none) => thierry.vignaud
Assignee: thierry.vignaud => mageiatools

Comment 4 Angelo Naselli 2016-09-12 15:38:33 CEST

IIRC it was hardcoded... and i seem to have fixed it in manauser

CC: (none) => anaselli

Comment 5 Angelo Naselli 2016-09-12 16:12:42 CEST

hmm i changed manauser code a bit, anyway I think problem is in lines

$us->{o}{uid} = Gtk3::SpinButton->new(Gtk3::Adjustment->new(500, 1, 65000, 1, 10, 10), 1, 0);

and

$us->{o}{gid} = Gtk3::SpinButton->new(Gtk3::Adjustment->new(500, 1, 65000, 1, 10, 10), 1, 0);

But I'm not a gtk expert

Comment 6 Mageia Robot 2016-09-12 16:14:59 CEST

commit 8d4d0a2e083e42a1dc1b30ef4f6a4d4b9dc3288f
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Mon Sep 12 16:14:53 2016 +0200

    fix minimal [GU]ID (mga#16888)
---
 Commit Link:
   http://gitweb.mageia.org/software/userdrake/commit/?id=8d4d0a2e083e42a1dc1b30ef4f6a4d4b9dc3288f

Comment 7 Thierry Vignaud 2016-09-12 16:15:50 CEST

Looks like we were looking at that one at the same time :-)

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 8 Angelo Naselli 2016-09-12 16:17:05 CEST

but you were quicker in fixing it than me :D