| Summary: | network monitor does not display graph of traffic data (python3 regression) | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Ben McMonagle <westel> |
| Component: | RPM Packages | Assignee: | Thierry Vignaud <thierry.vignaud> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | thierry.vignaud, yvesbrungard |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | net_monitor-0.21, python3-cairo | CVE: | |
| Status comment: | |||
| Bug Depends on: | 16748 | ||
| Bug Blocks: | |||
| Attachments: |
image of network monitor with no graph shown
fix shebang fix import warnings with latest gi fix "argument for 's' must be a bytes object" fix "ord() expected string of length 1, but int found" do not unset IP if we can't retrieve the MAC one fix "ord() expected string of length 1, but int found" use six for queue/Queue in order to ease python[23] run comparaisons |
||
|
Description
Ben McMonagle
2015-09-28 09:49:08 CEST
Created attachment 7060 [details]
image of network monitor with no graph shown
Does it work in other Desktop Environments? Does it output errors when started from console? Source RPM:
(none) =>
net_monitor Is vnstat installed? Is the vnstat service running? (In reply to Samuel VERSCHELDE from comment #2) > Does it work in other Desktop Environments? affected desktops: xfce, lxde, mate, cinnamon,Kde plasma. >Does it output errors when started from console? response from terminal: *****@localhost ~]$ net_monitor /bin/net_monitor:4: PyGIWarning: Gdk was imported without specifying a version first. Use gi.require_version('Gdk', '3.0') before import to ensure that the right version gets loaded. from gi.repository import Gdk /bin/net_monitor:6: PyGIWarning: Gtk was imported without specifying a version first. Use gi.require_version('Gtk', '3.0') before import to ensure that the right version gets loaded. from gi.repository import Gtk (In reply to David Walser from comment #3) > Is vnstat installed? vnstat 1.14-1.mga6 is installed > Is the vnstat service running? please advise terminal query, thanks This is a regression from the switch from python2 to python3 Downgrading to python3 works fine Draw signal is no more fired, which is very strange... BTW I've noted some defects in the python3 switch that I'll push later. CC:
(none) =>
thierry.vignaud, yves.brungard_mageia
Thierry Vignaud
2015-09-29 10:41:47 CEST
Source RPM:
net_monitor-0 =>
net_monitor-0.21 Created attachment 7065 [details]
fix shebang
Created attachment 7066 [details]
fix import warnings with latest gi
Created attachment 7067 [details]
fix "argument for 's' must be a bytes object"
Created attachment 7068 [details]
fix "ord() expected string of length 1, but int found"
Created attachment 7069 [details]
do not unset IP if we can't retrieve the MAC one
Created attachment 7070 [details]
fix "ord() expected string of length 1, but int found"
better fix (previous patch would display a bogus MAC address)
Attachment 7068 is obsolete:
0 =>
1 LoadGUI.update does run queue_draw_aread() regularly but the handler for the "draw" signal is never called. There's nothing obvious in diff between 0.20 & 0.21
Thierry Vignaud
2015-09-29 11:44:52 CEST
Whiteboard:
NEEDINFO =>
(none) All patches were applied. With next patch, it's easy to see that python2 net_monitor/net_monitor does display graphes, whereas it doesn't with python3 This it's a fallout of python3 conversion (aka bug #16748) Depends on:
(none) =>
16748 Created attachment 7073 [details]
use six for queue/Queue in order to ease python[23] run comparaisons
(NOT TO BE COMMIT)
With the gtk inspector, the only difference I saw is that there's no unmap signal handler with python3, which means the drawingarea is not realized IMHO Though, on exit with python3, there's the following warnings: TypeError: can't convert return value to desired type net_monitor/net_monitor:884: Warning: g_value_get_boolean: assertion 'G_VALUE_HOLDS_BOOLEAN (value)' failed Gtk.main() net_monitor/net_monitor:884: Warning: g_value_reset: assertion 'G_IS_VALUE (value)' failed Gtk.main() net_monitor/net_monitor:884: Warning: g_value_unset: assertion 'G_IS_VALUE (value)' failed Gtk.main() thanks for looking into this Thierry. I found out what's the issue. The real issue is within python3-cairo: __init__.py is wrongly in a src/ subdirectory... Assignee:
bugsquad =>
thierry.vignaud Fixed in package Status:
NEW =>
RESOLVED todays update has fixed issue. thanks again Thierry. |