| Summary: | dhcpd fails to start at boot due to trying to start too early | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Giuseppe Ghibò <ghibomgx> |
| Component: | RPM Packages | Assignee: | QA Team <qa-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | luigiwalser, mageia, sysadmin-bugs, wilcal.int |
| Version: | 5 | Keywords: | validated_update |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | advisory MGA5-32-OK MGA5-64-OK | ||
| Source RPM: | dhcp-4.3.2-1.mga5.src.rpm | CVE: | |
| Status comment: | |||
|
Description
Giuseppe Ghibò
2015-08-24 19:11:43 CEST
We discussed this on IRC and determined that network.target was not active on his machine for some reason. I checked in Fedora, and they changed the After to be on network-online.target instead of network.target (and added a Wants for it): http://pkgs.fedoraproject.org/cgit/dhcp.git/tree/dhcpd.service?h=f22 This fixed it for Giuseppe, but I don't understand why network.target wasn't active on his system. I guess we should change it to network-online.target, but it'd be nice to know why and what this all means. Whatever fix we make for this can be included in the next dhcp security update. Assigning to Colin to get some advice on this. CC:
(none) =>
luigiwalser Here is the fix (note that Fedora had a similar problem, see: https://bugzilla.redhat.com/show_bug.cgi?id=1120656) --- dhcpd-4.3.2-old/dhcpd6.service 2012-03-12 23:23:08.000000000 +0100 +++ dhcpd-4.3.2-new/dhcpd6.service 2015-08-24 18:40:44.000000000 +0200 @@ -1,6 +1,7 @@ [Unit] Description=DHCPv6 Server Daemon -After=syslog.target network.target +After=syslog.target network-online.target +Wants=network-online.target [Service] Environment=CONFIGFILE=/etc/dhcpd6.conf LEASEFILE=/var/lib/dhcp/dhcpd6.leases diff -w -uN dhcpd-4.3.2-old/dhcpd.service dhcpd-4.3.2-new/dhcpd.service --- dhcpd-4.3.2-old/dhcpd.service 2013-03-28 09:39:54.000000000 +0100 +++ dhcpd-4.3.2-new/dhcpd.service 2015-08-24 18:40:59.000000000 +0200 @@ -1,6 +1,7 @@ [Unit] Description=DHCPv4 Server Daemon -After=syslog.target network.target ldap.service +After=syslog.target network-online.target ldap.service +Wants=network-online.target [Service] Environment=CONFIGFILE=/etc/dhcpd.conf LEASEFILE=/var/lib/dhcpd/dhcpd.leases diff -w -uN dhcpd-4.3.2-old/dhcrelay.service dhcpd-4.3.2-new/dhcrelay.service --- dhcpd-4.3.2-old/dhcrelay.service 2011-09-05 11:03:33.000000000 +0200 +++ dhcpd-4.3.2-new/dhcrelay.service 2015-08-24 18:41:10.000000000 +0200 @@ -1,6 +1,7 @@ [Unit] Description=DHCP Relay Agent Daemon -After=syslog.target network.target +After=syslog.target network-online.target +Wants=network-online.target [Service] EnvironmentFile=/etc/sysconfig/dhcrelay OK, your patch is submitted in Cauldron and committed in Mageia 5 SVN. For users upgrading from Mageia 4 to Mageia 5, this is a non-obvious and unpleasant surprise, so let's fix this now. Advisory: ----------------------------------------- The dhcpd service in dhcp-server was not correctly waiting for the network to be up before attempting to start, causing it to fail to start at boot time. ----------------------------------------- Updated packages in core/updates_testing: ----------------------------------------- dhcp-common-4.3.2-1.1.mga5 dhcp-doc-4.3.2-1.1.mga5 dhcp-server-4.3.2-1.1.mga5 dhcp-client-4.3.2-1.1.mga5 dhcp-relay-4.3.2-1.1.mga5 dhcp-devel-4.3.2-1.1.mga5 from dhcp-4.3.2-1.1.mga5.src.rpm CC:
(none) =>
mageia I can verify that the updated service file fixes the issue on Mageia 5 i586. Whiteboard:
(none) =>
MGA5-32-OK In VirtualBox, M5, KDE, 64-bit Package(s) under test: dhcp-common dhcp-client default install of dhcp-common & dhcp-client [root@localhost wilcal]# urpmi dhcp-common Package dhcp-common-4.3.2-1.mga5.x86_64 is already installed [root@localhost wilcal]# urpmi dhcp-client Package dhcp-client-4.3.2-1.mga5.x86_64 is already installed Connects to my network at startup install dhcp-common & dhcp-client from updates_testing reboot system [root@localhost wilcal]# urpmi dhcp-common Package dhcp-common-4.3.2-1.1.mga5.x86_64 is already installed [root@localhost wilcal]# urpmi dhcp-client Package dhcp-client-4.3.2-1.1.mga5.x86_64 is already installed Connects to my network at startup CC:
(none) =>
wilcal.int This update works fine. Testing complete for MGA5, 32-bit & 64-bit Validating the update. Could someone from the sysadmin team push to updates. Thanks Keywords:
(none) =>
validated_update Advisory uploaded. Whiteboard:
MGA5-32-OK MGA5-64-OK =>
advisory MGA5-32-OK MGA5-64-OK An update for this issue has been pushed to Mageia Updates repository. http://advisories.mageia.org/MGAA-2015-0127.html Status:
NEW =>
RESOLVED |