| Summary: | msec: unable to add an exception (TypeError: pack_start() takes exactly 5 arguments (2 given)) | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | papoteur <yvesbrungard> |
| Component: | RPM Packages | Assignee: | QA Team <qa-bugs> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | andr999, geiger.david68210, jim, sysadmin-bugs, thierry.vignaud, unruh, yvesbrungard |
| Version: | 5 | Keywords: | PATCH, validated_update |
| Target Milestone: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | advisory MGA5-64-OK | ||
| Source RPM: | msec | CVE: | |
| Status comment: | |||
| Bug Depends on: | |||
| Bug Blocks: | 11778 | ||
| Attachments: | Syntax corrections | ||
In msecgui.py, these lines should be modified in:
l 1445: hbox.pack_start(Gtk.Label(_("Check: ")), True, True, 0)
l 1460: hbox.pack_start(Gtk.Label(_("Exception: ")), True, True, 0)
I will prepare a patch.
Created attachment 6923 [details]
Syntax corrections
Correction in the parathensis repartition in pack_start command
Another fallout from the autoconversion :-( Please commit & release a new msec Keywords:
(none) =>
PATCH
Thierry Vignaud
2015-08-24 10:52:13 CEST
Summary:
msec: unable to add an exception =>
msec: unable to add an exception (TypeError: pack_start() takes exactly 5 arguments (2 given))
Thierry Vignaud
2015-08-24 10:52:35 CEST
Blocks:
(none) =>
11778 commit 12b1f5d8b2ecdb1a5d4b99a03e0a119f3228c45f
Author: SARL ENR 68 <david@...>
Date: Fri Aug 28 20:26:24 2015 +0200
Correction bug 16574 unable to add an exception (mga#16574)
- by papoteur: https://bugs.mageia.org/attachment.cgi?id=6923
---
Commit Link:
http://gitweb.mageia.org/software/msec/commit/?id=12b1f5d8b2ecdb1a5d4b99a03e0a119f3228c45f
@ Thierry: All changes from papoteur are now committed, so I guess we go now on a "2.0" version of msec? What is the command that you use for create a new tag/release on mageia git? $ git tag -a 2.0 -m 'release 2.0' 12b1f5d8b2ecdb1a5d4b99a03e0a119f3228c45f $ git push origin 2.0 CC:
(none) =>
geiger.david68210 The bug had erased all my exceptions. The patch works nicely. (although the error msg was misleading, saying "2 arguments instead of 5", whereas it was 1 argument instead of 4.) If ever the lines 1308 1313 1318 and/or 1333 are uncommented, hbox.pack_start(button, False, 0) s/b hbox.pack_start(button, False, False, 0) CC:
(none) =>
andre999mga Still broken almost a year later. msec-1.15-1.mga5.x86_64.rpm CC:
(none) =>
unruh Ie, the patch works, but the patch is not included in 1.15 released Apr 2016. commit e04b7e22dd52cbb8c6e1d910b55f2927a4c47984
Author: Papoteur <papoteur@...>
Date: Mon Jul 4 09:03:37 2016 +0200
Correction unable to add an exception (mga#16574)
---
Commit Link:
http://gitweb.mageia.org/software/msec/commit/?id=e04b7e22dd52cbb8c6e1d910b55f2927a4c47984
msec 1.16 submitted and uploaded on mga5 Core/Updates_testing repo. See the comment 1 to know how to try the update. Advisory The feature "Add an exception" didn't work. The update gives a solution to this bug. x86_64 msec-1.16-1.mga5.x86_64.rpm msec-gui-1.16-1.mga5.x86_64.rpm i586 msec-1.16-1.mga5.i586.rpm msec-gui-1.16-1.mga5.i586.rpm SRPMS msec-gui-1.16-1.mga5.src.rpm Assignee:
bugsquad =>
qa-bugs Testing on mga5-64 Installed from testing: msec-gui-1.16-1.mga5 msec-1.16-1.mga5 Created a rule and verified that it was correctly added to /etc/security/msec/exceptions OK for mga5-64 CC:
(none) =>
jim Validating
claire robinson
2016-07-08 16:52:17 CEST
Keywords:
(none) =>
validated_update An update for this issue has been pushed to the Mageia Updates repository. http://advisories.mageia.org/MGAA-2016-0102.html Status:
NEW =>
RESOLVED |
Description of problem: Adding an exception have no effect. In console, I get: Traceback (most recent call last): File "/usr/share/msec/msecgui.py", line 1417, in add_exception return self.exception_changed(None, None, None, model) File "/usr/share/msec/msecgui.py", line 1445, in exception_changed hbox.pack_start(Gtk.Label(_("Check: "), True, True, 0)) TypeError: pack_start() takes exactly 5 arguments (2 given) Version-Release number of selected component (if applicable): msec-gui-1.13 How reproducible: Launch msecgui Tabs "Security settings"/"Exceptions" Click button "Add a rule" Nothing happens in interface. Get the error in console. Reproducible: Steps to Reproduce: