Bug 16362

Summary: mgarepo could suggest to svn ci in appropriate cases
Product: Infrastructure Reporter: Bruno Cornec <bruno>
Component: OthersAssignee: Sysadmin Team <sysadmin-bugs>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: Normal CC: anaselli, doktor5000, sysadmin-bugs
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: Linux   
See Also: https://bugs.mageia.org/show_bug.cgi?id=3435
Whiteboard:
Source RPM: mgarepo-1.10.6-5.mga5 CVE:
Status comment:

Description Bruno Cornec 2015-07-12 23:27:47 CEST 
Description of problem:

When doing a mgarepo submit and that there is a svn diff/status in your environment, a warning could be emitted to allow the user to check in before submitting as this is generally what you want to do.



Reproducible: 

Steps to Reproduce:
Comment 1 Florian Hubold 2015-12-19 14:31:08 CET 
So each time a svn diff exists, mgarepo should issue a warning that a diff exists when you run mgarepo ci?

You are required to check what you commit with svn diff beforehand, so this pretty much makes no real sense if you want to reverse this. Otherwise we end up with more "do you really want to do this" and "are you really sure" dialogs like in windows vista or later with raised UAC ...

Do you have some actual example for this - and how do you define appropriate cases where such a warning should be issued by mgarepo?

CC: (none) => doktor5000

Florian Hubold 2015-12-19 14:32:07 CET

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=3435

Comment 2 Bruno Cornec 2015-12-22 11:48:02 CET 
The major use case I had for this was when you update a package following an upstream update (you move say from 1.0 to 1.1), you update the spec file accordingly, do mgarepo sync -d to get the content in sync, you build with bm and then you do mgarepo submit, forgetting to do a svn ci before. I'd like mgarepo to be able to detect it and propose to me to do the svn/mgarepo ci if I validate it.
Comment 3 Angelo Naselli 2015-12-22 13:42:22 CET 
@Florian iiuc the case is before submitting. So if there are differences magarepo should prevent the submission. The svn diff/status case should be easy to test,
but I'm not sure that is also easy if a patch or a source pacakge has not been
added though... But managing at least the easier tasks should be done anyway...

CC: (none) => anaselli