Bug 16116

Summary: diskdrake percentage numbers for partition size not documented
Product: Mageia Reporter: Florian Hubold <doktor5000>
Component: RPM PackagesAssignee: Thierry Vignaud <thierry.vignaud>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: Low CC: doc-bugs, doktor5000, lebarhon, marja11
Version: CauldronKeywords: Junior_job, PATCH, USABILITY
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Source RPM: mageia-doc, drakx-installer-help CVE:
Status comment:

Description Florian Hubold 2015-06-14 15:03:38 CEST
Description of problem:

diskdrake shows percentages behind the absolute size for partitions. Those percentages are not explained in the documentation, and we had one case where a user assumed that those show filesystem usage, and assumed a bug in diskdrake as it showed wrong numbers.

This is not the case, applying simple math shows that those percentages are the relative size of that partition compared to the underlying volume.
This should be added to http://doc.mageia.org/mcc/5/en/content/drakdisk.html and also for the installer documentation in http://doc.mageia.org/installer/5/en/content/diskdrake.html

Reproducible: 

Steps to Reproduce:
Marja Van Waes 2015-06-14 15:44:52 CEST

CC: (none) => marja11
Source RPM: drakxtools-curses => mageia-doc, drakx-installer-help

Comment 1 André DESMOTTES 2015-06-14 16:17:54 CEST
Not sure people have a look into documentation for such details. We can of course add an explanation in the documentation but I think it should be better to also modify the interface.
Instead of 
Size: 8.1 GB (21%)
Write
Absolute (relative) size: 8.1 GB (21%)

CC: (none) => lebarhon

Comment 2 Florian Hubold 2015-06-14 16:39:09 CEST
(In reply to André DESMOTTES from comment #1)
> but I think it should be better to also modify the interface.
> Instead of 
> Size: 8.1 GB (21%)
> Write
> Absolute (relative) size: 8.1 GB (21%)

Yep that sounds like a good idea, although it does also not show to what the relative size compares (but that's a minor nitpick).

Thierry, WDYT? Add some explanation for that value or simply omit it for normal mode, and only show it in expert mode with some added string like André proposed?

Priority: Normal => Low
CC: (none) => doc-bugs, doktor5000
Assignee: doc-bugs => thierry.vignaud

Comment 3 Samuel Verschelde 2015-06-15 10:26:37 CEST
I had to read it twice before I understood what "Absolute (relative) size:" meant, and I would certainly not have understood if I hadn't known the context. It's not obvious that "(relative)" means "the percentage between parenthesis is a relative percentage". I think it's worse than just "Size:"

It's also not obvious to all users what an "Absolute size" is.

why not simply: "Size: 8.1 GB (21% of disk)"? (if disk is OK, because not all media are "disks").
Comment 4 Rémi Verschelde 2015-06-15 10:31:08 CEST
(In reply to Samuel VERSCHELDE from comment #3)
> why not simply: "Size: 8.1 GB (21% of disk)"? (if disk is OK, because not
> all media are "disks").

+1, I also find "Absolute (relative) size" misleading. For me a parenthesis usually gives context about what comes before, i.e. here "relative" would extend the meaning of "absolute"? Quite antinomic ;).
Comment 5 Thierry Vignaud 2015-06-15 11:07:12 CEST
Yep, "Size: 8.1 GB (21% of disk)" is quite a lot better.
Thierry Vignaud 2015-06-15 11:11:15 CEST

Keywords: (none) => Junior_job, USABILITY

Comment 6 André DESMOTTES 2015-06-15 11:32:35 CEST
Using parenthesis to give an alternative is very common in documentation, for example:
Click on the up (down) arrow to increase (decrease).
But, no problem for me, it is as you like, the important is the % meaning being clear.
Comment 7 Florian Hubold 2015-06-15 21:57:20 CEST
(In reply to Samuel VERSCHELDE from comment #3)
> why not simply: "Size: 8.1 GB (21% of disk)"?

Unambiguous and understandable :)
Comment 8 Thierry Vignaud 2015-06-16 06:55:26 CEST
Fix queued for mga6 in my local git

Keywords: (none) => PATCH
Status: NEW => ASSIGNED

Comment 9 Florian Hubold 2015-10-27 09:08:36 CET
(In reply to Thierry Vignaud from comment #8)
> Fix queued for mga6 in my local git

Hi Thierry, did you commit it yet? Then we could close this one, thanks in advance :)
Comment 10 Mageia Robot 2016-02-09 00:40:45 CET
commit fe1fff1dc82d008a6b811513a1809f379ea5a0b9
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Tue Jun 16 06:52:26 2015 +0200

    better understandable percentage (mga#16116)
    
    as a side note, this is friendler to translators (instead of joining
    two strings...)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=fe1fff1dc82d008a6b811513a1809f379ea5a0b9
Comment 11 Thierry Vignaud 2016-02-09 06:23:56 CET
Done

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

Comment 12 Florian Hubold 2016-02-09 11:21:12 CET
(In reply to Thierry Vignaud from comment #11)
> Done

Thanks a lot :)