Bug 16073

Summary:	Simple partitioning scheme checks for max disk size instead of available space
Product:	Mageia	Reporter:	Rémi Verschelde <rverschelde>
Component:	Installer	Assignee:	Mageia tools maintainers <mageiatools>
Status:	NEW ---	QA Contact:	Rémi Verschelde <rverschelde>
Severity:	critical
Priority:	High	CC:	ouaurelien, pkg-bugs, pterjan, thierry.vignaud
Version:	Cauldron
Target Milestone:	Mageia 8
Hardware:	All
OS:	Linux
URL:	http://www.mageialinux-online.org/forum/topic-20244+mageia-5-rc-erreurs-lors-du-partitionning.php
Whiteboard:
Source RPM:		CVE:
Status comment:	Nasty bug but corner case for small disks. Needs decision from Mageia tools group on whether to keep as release blocker or not.

Description Rémi Verschelde 2015-06-03 10:10:06 CEST

Following this topic on the MLO forum [1], I realised that there might be a flaw in the "simple" partitioning scheme that we now use [2], though the flaw was likely already there before but less critical.

The partitioner checks for "min_hd_size => MB(51200)" to determine whether it should split / and /home. The problem described on the MLO forum is that when resizing a Windows partition of a 64 GB disk (thus freeing 20 GB for Mageia), the split partitioning was used, which does not make sense in 20 GB of disk space.

Initial partitioning:
- S: réservé au SystÃ¨me : 100 M
- C: Windows : 64 G
- D: DATA : 84 G

Proposed partitioning by the installer:
- sda2: C: Windows : 44 G
- sda5: linux native : 6.4 G (/)
- sda6: swap : 1.2 G
- sda7: linux native : 12 G (/home)

We need to ensure that the split partitioning is used when the free disk space is => MB(51200), not the overall hard disk size.

[1] http://www.mageialinux-online.org/forum/topic-20244+mageia-5-rc-erreurs-lors-du-partitionning.php
[2] http://gitweb.mageia.org/software/drakx/commit/?id=f699804e6f9f0e28c39f6ef258e5a0e16d6a0580

Reproducible: 

Steps to Reproduce:

Comment 1 Rémi Verschelde 2015-06-03 10:12:38 CEST

Not putting as a release blocker so close to the release, so it will probably have to do with errata.

Priority: Normal => High
Whiteboard: (none) => FOR_ERRATA

Comment 2 Samuel Verschelde 2015-06-05 14:55:45 CEST

Rémi, could you write the Errata entry if you think it's worth one?

Comment 3 Rémi Verschelde 2016-01-13 11:48:58 CET

As it's been a long time since the release and I don't plan to write an errata entry for Mageia 5 now, I remove the corresponding tag (I admit it's mostly due to laziness and not to the fact that the issue is not relevant ;) though it is kind of a corner case).

Setting as release blocker for Mageia 6 though.

Priority: High => release_blocker
Whiteboard: FOR_ERRATA => (none)

Rémi Verschelde 2016-01-13 11:49:43 CET

Blocks: (none) => 15527

Thierry Vignaud 2016-06-17 15:01:18 CEST

CC: (none) => pterjan, thierry.vignaud

Comment 4 Samuel Verschelde 2016-07-15 11:34:44 CEST

Pascal, Thierry or other developers, is it a bug you think you can fix for Mageia 6? It's quite a nasty one although a corner case so should happen rarely.

CC: (none) => pkg-bugs

Samuel Verschelde 2016-09-12 15:26:58 CEST

Assignee: pterjan => mageiatools

Samuel Verschelde 2016-09-12 16:27:28 CEST

QA Contact: (none) => rverschelde
Status comment: (none) => Nasty bug but corner case for small disks. Needs decision from Mageia tools group on whether to keep as release blocker or not.

Comment 5 Rémi Verschelde 2016-10-17 14:18:18 CEST

(In reply to Samuel Verschelde from comment #4)
> Pascal, Thierry or other developers, is it a bug you think you can fix for
> Mageia 6? It's quite a nasty one although a corner case so should happen
> rarely.

Ping. If we don't plan to work on it right now, the priority could be decreased and the milestone set to Mageia 7.

Target Milestone: --- => Mageia 6

Samuel Verschelde 2017-01-17 10:29:39 CET

Blocks: 15527 => (none)

Comment 6 Samuel Verschelde 2017-03-05 14:28:47 CET

No answer from anyone, lowering priority.

Priority: release_blocker => High

Aurelien Oudelet 2020-09-09 21:30:21 CEST

CC: (none) => ouaurelien
Target Milestone: Mageia 6 => Mageia 8

Comment 7 Aurelien Oudelet 2020-09-19 18:09:12 CEST

Hi,
This is High priority bug for a good reason.

Making Mageia even better than ever is best direction.
In order to do right thing, this bug should be examined and fixed as soon as possible.

Packagers, please make the status to Assigned when you are working on this.
Feel free to reassign the bug if bad-triaged. Also, if bug is old, please close it.

On October 1st 2020, we will drop priority to normal.