Bug 15904

Summary:	Gwenview defaults JPEG quality to 75% and does not let the user change that
Product:	Mageia	Reporter:	Rémi Verschelde <rverschelde>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	etienne15000, lmenut, neoclust, olivier.delaune, sysadmin-bugs
Version:	4	Keywords:	PATCH, UPSTREAM, validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
URL:	https://bugs.kde.org/show_bug.cgi?id=294594
Whiteboard:	has_procedure MGA4-64-OK advisory
Source RPM:	gwenview	CVE:
Status comment:

Description Rémi Verschelde 2015-05-11 12:05:11 CEST

As pointed out in this old and yet unresolved upstream bug report [1], gwenvien defaults the JPEG quality to 75%, and it does not provide a feature to modify this setting.

A patch has been proposed upstream [2] to change this default to 95%, but it has not been upstreamed yet as upstream would prefer to add a quality slider to select the compression quality.

For the time being, the lack of action is pretty damageable for our users IMO since 75% is a really low quality setting for JPEG.

As discussed on IRC with neoclust, I'll backport the proposed patch for the time being.

[1] https://bugs.kde.org/show_bug.cgi?id=294594
[2] https://bugs.kde.org/attachment.cgi?id=80024

Reproducible: 

Steps to Reproduce:

Rémi Verschelde 2015-05-11 12:05:29 CEST

CC: (none) => lmenut, neoclust

Rémi Verschelde 2015-05-11 12:05:46 CEST

Keywords: (none) => PATCH, UPSTREAM
Hardware: i586 => All

Rémi Verschelde 2015-05-11 12:09:12 CEST

Whiteboard: (none) => MGA4TOO

Comment 1 Rémi Verschelde 2015-05-11 12:12:52 CEST

Submitted gwenview-4.12.5-1.1.mga4 with the mentioned patch. Freeze push request sent to the dev ML for Mageia 5.

Comment 2 Rémi Verschelde 2015-05-11 12:16:08 CEST

SRPM:
=====
 - gwenview-4.12.5-1.1.mga4

RPMs:
=====
gwenview-4.12.5-1.1.mga4
gwenview-devel-4.12.5-1.1.mga4
gwenview-handbook-4.12.5-1.1.mga4.noarch
lib(64)gwenviewlib4-4.12.5-1.1.mga4

Comment 3 Rémi Verschelde 2015-05-11 12:21:03 CEST

Advisory:
=========

Updated gwenview packages increase JPEG compression quality

  By default, gwenview uses a compression quality of 75% when saving JPEG images
  (bko#294594). This setting is hardcoded in the application and therefore can't
  be modified to fit each user's needs.

  The Mageia 4 gwenview package has been patched to increase this compression
  quality to 95%, which would be a more acceptable value for most users.


References:
===========
 - https://bugs.kde.org/show_bug.cgi?id=294594
 - https://bugs.kde.org/attachment.cgi?id=80024
 - https://bugs.mageia.org/show_bug.cgi?id=15904

Comment 4 Rémi Verschelde 2015-05-11 12:29:22 CEST

Testing procedure:
==================

- Find or prepare a JPEG image of high quality (for example by saving a PNG file in GIMP as a JPEG file with quality 95)
- Check the quality of the original file, using e.g.:
  $ identify -verbose $filename.jpg | grep -i quality
(The "identify" command is part of ImageMagick)
- Open the file in gwenview, modify it a bit (e.g. crop it off some pixels), and save it as JPEG
- Check the quality of the modified file with the same command

Before the update, the quality of the modified file should be 75.

After the update, it should be 95.

Rémi Verschelde 2015-05-11 12:29:32 CEST

Whiteboard: MGA4TOO => MGA4TOO has_procedure

Comment 5 Olivier Delaune 2015-05-14 08:49:24 CEST

Testing on Mga 4 64-bits. Bug confirmed before updating.
Issue solved after updating.

CC: (none) => olivier.delaune

Comment 6 Rémi Verschelde 2015-05-14 12:10:24 CEST

Thanks Olivier, adding the corresponding whiteboard tag.

Whiteboard: MGA4TOO has_procedure => MGA4TOO has_procedure MGA4-64-OK

Comment 7 Etienne Etienne 2015-05-14 16:39:43 CEST

Hello,

I tested the update on Mageia4 64bit. It's OK. After to be modified, my jpg image is now saving with quality 95.

Thanks

CC: (none) => etienne15

Comment 8 Rémi Verschelde 2015-06-06 15:36:57 CEST

Mageia 5 update was freeze pushed a while ago, assigning to QA for Mageia 4.

Version: Cauldron => 4
Assignee: rverschelde => qa-bugs
Whiteboard: MGA4TOO has_procedure MGA4-64-OK => has_procedure MGA4-64-OK

Comment 9 Rémi Verschelde 2015-06-06 15:39:00 CEST

Validating, advisory uploaded. Please push to 4 core/updates.

Keywords: (none) => validated_update
Whiteboard: has_procedure MGA4-64-OK => has_procedure MGA4-64-OK advisory
CC: (none) => sysadmin-bugs

Comment 10 Samuel Verschelde 2015-06-06 15:40:47 CEST

You shouldn't have validated it yourself, but I think it will do for this time.

Version: 4 => Cauldron

Rémi Verschelde 2015-06-06 15:41:24 CEST

Version: Cauldron => 4

Comment 11 Mageia Robot 2015-06-08 23:18:35 CEST

An update for this issue has been pushed to Mageia Updates repository.

http://advisories.mageia.org/MGAA-2015-0053.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED