Bug 15767

Summary:	M5RC In a multi HDD system with GPT and MSDos partitioning schemes, the MSdos /swap partition is presented as a system (/) at installation bootloader configuration when installing to the GPT HDD
Product:	Mageia	Reporter:	Ben McMonagle <westel>
Component:	Installer	Assignee:	Mageia Bug Squad <bugsquad>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	thierry.vignaud
Version:	Cauldron	Keywords:	PATCH
Target Milestone:	Mageia 6
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	Mageia-5-RC-i586-DVD, Wed Apr 15 08:55:11 CEST 2015	CVE:
Status comment:
Attachments:	my MSDos partitioned HDD layout, with /sda1 as a swap My GPT HDD partition layout configure bootloader menu page at end of installation highlighted entry showing /dev/sda1 as a proposed system partition /root/drakx/report.bug.xz /root/drakx/report.bug.xz skip swap in the list of partitions

Description Ben McMonagle 2015-04-25 00:58:48 CEST

Description of problem:In a multi HDD system with GPT and MSDos partitioning schemes, the MSdos /swap partition is presented as a system (/) at installation bootloader configuration page when the installation is onto the GPT disk 


Version-Release number of selected component (if applicable):


How reproducible:every time I run an installation


Steps to Reproduce:
1.have at least 2 HDD system, 1 in MSDos partioning scheme with at least /swap,/, /home, the other in GPT partitioning with at least /swap, /efi, and sufficient partitions to complete an install
2.install a new Mageia5 system onto the HDD with GPT partitioning
3.inspect bootloader configuration page


Reproducible: 

Steps to Reproduce:

Ben McMonagle 2015-04-25 00:59:31 CEST

Summary: M5RC In a multi HDD system with GPT and MSDos partitioning schemes, the MSdos /swap partition is presented as a system / at installation bootloader configuration => M5RC In a multi HDD system with GPT and MSDos partitioning schemes, the MSdos /swap partition is presented as a system (/) at installation bootloader configuration

Comment 1 Ben McMonagle 2015-04-25 01:02:10 CEST

Created attachment 6348 [details]
my MSDos partitioned HDD layout, with /sda1 as a swap

my MSDos partitioned HDD layout, with /sda1 as a swap

Comment 2 Ben McMonagle 2015-04-25 01:03:20 CEST

Created attachment 6349 [details]
My GPT HDD partition layout

Comment 3 Ben McMonagle 2015-04-25 01:05:59 CEST

Created attachment 6350 [details]
configure bootloader menu page at end of installation

Comment 4 Ben McMonagle 2015-04-25 01:08:38 CEST

Created attachment 6351 [details]
highlighted entry showing /dev/sda1 as a proposed system partition

Ben McMonagle 2015-04-25 01:09:22 CEST

Summary: M5RC In a multi HDD system with GPT and MSDos partitioning schemes, the MSdos /swap partition is presented as a system (/) at installation bootloader configuration => M5RC In a multi HDD system with GPT and MSDos partitioning schemes, the MSdos /swap partition is presented as a system (/) at installation bootloader configuration when installing to the GPT HDD

Comment 5 Samuel Verschelde 2015-04-25 09:29:01 CEST

Setting release blocker for final.

Priority: Normal => release_blocker
Blocks: (none) => 14069

Comment 6 Thierry Vignaud 2015-04-27 12:01:59 CEST

Please attach your /root/drakx/report.bug.xz

Keywords: (none) => NEEDINFO
Priority: release_blocker => Normal
CC: (none) => thierry.vignaud

Comment 7 Thierry Vignaud 2015-04-27 12:04:34 CEST

BTW you can use "F2" next time in order to take screenshots instead of using a camera for photos....

Comment 8 Ben McMonagle 2015-04-28 10:49:56 CEST

Created attachment 6386 [details]
/root/drakx/report.bug.xz

hopefully this is the required one

Ben McMonagle 2015-04-28 10:50:37 CEST

Keywords: NEEDINFO => (none)

Comment 9 Ben McMonagle 2015-04-28 12:36:23 CEST

Created attachment 6387 [details]
/root/drakx/report.bug.xz

the first one was the wrong one, this is the correct one

Attachment 6386 is obsolete: 0 => 1

Comment 10 Thierry Vignaud 2015-04-28 13:00:06 CEST

BTW There's an issue with GPT on sdb as it doesn't use the proper GUIDs for swap/... (Microsoft basic data).

BTW(2) your /boot/grub/device.map is swaping sda & sdb:
(hd0) /dev/sdb
(hd1) /dev/sda

Then, if you look at the popup menu, you'll see it's showing all mount points from fstab (swap being considered as such)


For the entry you're seeing, as you see in logs, it failed to identify one OS:* "could not recognise the distribution for  in "
Thus, it has no "root" entry, and thus the popup menu default to the first entry.

That's not a release blocker issue

Comment 11 Thierry Vignaud 2015-04-28 13:00:11 CEST

Created attachment 6388 [details]
skip swap in the list of partitions

This patch filters out swaps from the  list of partitions

Thierry Vignaud 2015-04-28 13:01:36 CEST

Blocks: 14069 => (none)

Thierry Vignaud 2015-04-30 22:16:11 CEST

Keywords: (none) => PATCH

Comment 12 Samuel Verschelde 2015-05-21 10:35:54 CEST

(In reply to Thierry Vignaud from comment #11)
> Created attachment 6388 [details]
> skip swap in the list of partitions
> 
> This patch filters out swaps from the  list of partitions

This patch was not committed, should it be?

Comment 13 Thierry Vignaud 2015-05-21 10:41:12 CEST

No, I've queued it for mga6 as it's a cosmetic.

Samuel Verschelde 2015-05-21 10:42:27 CEST

Whiteboard: (none) => FOR_ERRATA

Comment 14 Thierry Vignaud 2015-05-21 12:53:48 CEST

(Tbe real issue being having not detected the right parameters for an other OS)

Comment 15 Samuel Verschelde 2015-06-05 14:42:47 CEST

Removing FOR_ERRATA since it's a minor and specific issue.

Whiteboard: FOR_ERRATA => (none)

Samuel Verschelde 2015-06-06 02:17:05 CEST

Target Milestone: --- => Mageia 6

Comment 16 Mageia Robot 2016-01-02 15:01:05 CET

commit 3769edb5f1f083d748437c7367d99a4b86271e88
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Thu Apr 30 22:26:43 2015 +0200

    skip swap in the list of partitions (mga#15767)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=3769edb5f1f083d748437c7367d99a4b86271e88

Comment 17 Mageia Robot 2016-01-02 15:01:31 CET

commit 1036468080af2a5da1c6a1b39eef65a985d6bbfc
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Thu Apr 30 22:26:43 2015 +0200

    skip swap in the list of partitions (mga#15767)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=1036468080af2a5da1c6a1b39eef65a985d6bbfc

Comment 18 Thierry Vignaud 2016-01-02 15:04:26 CET

Fixed

Comment 19 Thierry Vignaud 2016-01-02 15:04:37 CET

Really closing

Status: NEW => RESOLVED
Resolution: (none) => FIXED