Bug 15698

Summary: Cannot create a vfat filesystem, when installing in UEFI mode
Product: Mageia Reporter: Dave Hodgins <davidwhodgins>
Component: InstallerAssignee: Thierry Vignaud <thierry.vignaud>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: eeeemail, ennael1, tmb, wilcal.int
Version: CauldronKeywords: PATCH
Target Milestone: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: FOR_ERRATA
Source RPM: CVE:
Status comment:
Attachments: fix being able to create vfat on UEFI (mga#15698)
fix being able to create vfat on UEFI (mga#15698)

Description Dave Hodgins 2015-04-14 21:16:49 CEST 
During installation partitioning, vfat is not listed as an option for the
filesystem type.. If a user wants to create a vfat filesystem (for exchanging
data with a windows install, not for use as an esp), they can not.


Reproducible: 

Steps to Reproduce:
Comment 1 Dave Hodgins 2015-04-14 21:18:47 CEST 
Marking as a release blocker, as this cannot be fixed after release.

Priority: Normal => release_blocker
CC: (none) => eeeemail, ennael1, tmb, wilcal.int
Blocks: (none) => 14069
Assignee: bugsquad => thierry.vignaud

Comment 2 Thomas Backlund 2015-04-14 21:22:55 CEST 
Lets not invent blocker bugs here...

This is no way a release_blocker as you dont need a vfat "data sharing partition" during install.

And if drakxtools cant create vfat after install, then it's a bug an in worst case can be fixed after release...

Priority: release_blocker => Normal
Blocks: 14069 => (none)

Comment 4 Thomas Backlund 2015-04-15 07:32:24 CEST 
Looking at the code we still list a separate vfat for fat32

    my @list_types = (
        important => [
  0x82 => 'swap',     'Linux swap',
  0x83 => 'ext2',     'Linux native',
  0x83 => 'ext3',     'Journalised FS: ext3',
  0x83 => 'ext4',     'Journalised FS: ext4',
  0x83 => 'btrfs',    'Journalised FS: Btrfs',
if_(is_uefi(),
  0xef => 'vfat',     'EFI System Partition',
),
if_(arch() =~ /i.86|x86_64/,
  0x83 => 'xfs',      'Journalised FS: XFS',
  0x83 => 'jfs',      'Journalised FS: JFS',
  0x0b => 'vfat',     'FAT32',
  0x07 => 'ntfs-3g',  'NTFS-3G',
  0x07 => 'ntfs',     'NTFS',
),
        ],

But maybe we are doing "sort -u" on that fs list so the second one goes missing...

We also need to check if it's gone in advanced partitioning mode...
Thierry Vignaud 2015-06-02 15:26:26 CEST

Summary: Cannot create a vfat filesystem, when installing in uefi mode => Cannot create a vfat filesystem, when installing in UEFI mode

Comment 5 Samuel Verschelde 2015-06-06 02:11:21 CEST 
Still valid I suppose?

Whiteboard: (none) => FOR_ERRATA

Thierry Vignaud 2016-06-29 17:24:35 CEST

Keywords: (none) => PATCH

Comment 6 Thierry Vignaud 2016-06-29 17:28:46 CEST 
Created attachment 8089 [details]
fix being able to create vfat on UEFI (mga#15698)

This patch fixes it but needs to be tested with LVM
Comment 7 Thierry Vignaud 2016-06-29 17:37:06 CEST 
Created attachment 8091 [details]
fix being able to create vfat on UEFI (mga#15698)

Better version

Attachment 8089 is obsolete: 0 => 1

Comment 8 Mageia Robot 2016-06-30 16:32:08 CEST 
commit b14b860a8e92c36767b519de516128b3d7847628
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Wed Jun 29 17:23:29 2016 +0200

    fix being able to create vfat on UEFI (mga#15698)
    
    and explain the purpose of the uniq_() call
    see commit 56b573476e2ea63a509ab2f8ec0683397ae7c85e
    
    Rationale: use_pt_type() now returns 0 for common disks (eg: GPT ones)
    Under GPT+UEFI, we've 2 important "FS" having vfag as the real FS:
    ESP & FAT32
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=b14b860a8e92c36767b519de516128b3d7847628
Comment 9 Thierry Vignaud 2016-06-30 16:35:57 CEST 
Closing

Status: NEW => RESOLVED
Resolution: (none) => FIXED