Bug 15692

Summary:	install.sh in UEFI has useless parameters
Product:	Mageia	Reporter:	Barry Jackson <zen25000>
Component:	Installer	Assignee:	Thierry Vignaud <thierry.vignaud>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	thierry.vignaud
Version:	Cauldron
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	drakx	CVE:
Status comment:
Attachments:	just run grub2-install for UEFI

Description Barry Jackson 2015-04-13 22:13:42 CEST

Description of problem:
As summary.
The grub2-install command in install.sh contains the following in a clean UEFI install:

"grub2-install --grub-setup=/bin/true /dev/sda --directory /usr/lib/grub/x86_64-efi"

AFAIK none of those parameters are required (or valid) in UEFI mode.

grub2-install

is enough.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.


Reproducible: 

Steps to Reproduce:

Comment 1 Thierry Vignaud 2015-04-13 22:34:52 CEST

Created attachment 6263 [details]
just run grub2-install for UEFI

So you would advice this?

CC: (none) => thierry.vignaud

Comment 2 Barry Jackson 2015-04-14 00:50:42 CEST

Yes, to quote Andrei Borzenkov (a grub2 dev) in reference to my query relating to next line:

> grub2-install --grub-setup=/bin/true /dev/sda4

"Both arguments are redundant. Install device is ignored on EFI,
grub-setup is never called there either."

Thierry Vignaud 2015-04-14 06:01:07 CEST

Summary: install.sh in UEFI has invalid parameters => install.sh in UEFI has useless parameters

Comment 3 Mageia Robot 2015-04-14 22:21:08 CEST

commit 8c3bec9a1c13fed19839e8a85a97ddadfaf17315
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Mon Apr 13 22:32:32 2015 +0200

    do not pass useless parameters (mga#15692)
    
    ... to grub2 under UEFI
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=8c3bec9a1c13fed19839e8a85a97ddadfaf17315

Comment 4 Thierry Vignaud 2015-04-15 06:07:52 CEST

Fixed

Status: NEW => RESOLVED
Resolution: (none) => FIXED