Bug 15638

Summary:	on multi-NIC computers (e.g. ethernet+wifi) network devices are labelled "unknown" in stage1 since mga4 (b/c udev preload the drivers)
Product:	Mageia	Reporter:	Samuel Verschelde <stormi-mageia>
Component:	Installer	Assignee:	Thierry Vignaud <thierry.vignaud>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	mageia, thierry.vignaud
Version:	Cauldron	Keywords:	USABILITY
Target Milestone:	Mageia 6
Hardware:	i586
OS:	Linux
Whiteboard:
Source RPM:	drakx-installer-binaries	CVE:
Status comment:
Attachments:	output of lspcidrake -v from my mga4 system Screen photo

Description Samuel Verschelde 2015-04-06 23:39:25 CEST

At stage 1 (I think) during a network install via boot.iso, or rather boot-
nonfree.iso (it's the one I tested), I must choose a network device because I have an ethernet port + wifi.

The screen is not easy to understand if you're not familiar with module names,  because the only additional information it gives is: (unknown), instead of device name. 

Attached are output of lspcidrake -v and a picture of the screen.

--

tv said about it: "It might have been broken by the switch to Predictable Network Interface Names:
http://www.freedesktop.org/wiki/Software/systemd/PredictableNetworkInterfaceNames/"

Reproducible: 

Steps to Reproduce:

Comment 1 Samuel Verschelde 2015-04-06 23:40:17 CEST

Created attachment 6205 [details]
output of lspcidrake -v from my mga4 system

Comment 2 Samuel Verschelde 2015-04-06 23:40:50 CEST

Created attachment 6206 [details]
Screen photo

Samuel Verschelde 2015-06-06 02:20:30 CEST

Target Milestone: --- => Mageia 6

Comment 3 Thierry Vignaud 2016-06-17 12:41:06 CEST

Is this still valid?

Keywords: (none) => NEEDINFO
CC: (none) => thierry.vignaud

Thierry Vignaud 2016-06-17 12:41:21 CEST

Source RPM: (none) => drakx-installer-binaries

Comment 4 Thierry Vignaud 2016-07-01 17:21:56 CEST

For some reason, we fail to retrieve the adapter description.
That was OK in mga3 but is broken since mga4.

Comparing both shows that:
- in mga3, we were manually loading the driver and thus we know which driver corresponded to the newly created intf.
- since mga4, the driver already has been loaded by udev and thus we fail to associate the intf with the right driver and thus we failed to get the driver description.

The solution is to do what I did in stage2 13 years ago, using the ethtool IOCTL:
http://gitweb.mageia.org/software/drakx/tree/perl-install/c/stuff.xs.pl#n430
http://gitweb.mageia.org/software/drakx/commit/perl-install/c/stuff.xs.pl?id=58776de07de819cb962aa35e76c8379d96f03e6b

Keywords: NEEDINFO => USABILITY
Status: NEW => ASSIGNED
CC: (none) => mageia
Assignee: bugsquad => thierry.vignaud
Summary: on multi-NIC computers (e.g. ethernet+wifi) network devices are labelled "unknown" in stage1 => on multi-NIC computers (e.g. ethernet+wifi) network devices are labelled "unknown" in stage1 since mga4 (b/c udev preload the drivers)

Comment 5 Mageia Robot 2016-07-01 17:41:22 CEST

commit dca3a0bf7c1b807b8a568c436b0225f7c1c2762c
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Jul 1 17:33:43 2016 +0200

    fix description of network interfaces (mga#15638)
    
    It got broken when switching stage1 to udev: previously we were manually
    loading the driver and thus we knew which driver corresponded to the
    newly created intf.
    
    Since mga4, the driver has already been loaded by udev and thus we fail
    to associate the intf with the right driver and thus we failed to get
    the driver description.
    
    => let's use the ethtool IOCTL like the stage2 does
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=dca3a0bf7c1b807b8a568c436b0225f7c1c2762c

Comment 6 Thierry Vignaud 2016-07-01 17:45:40 CEST

Fixed in git

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED