Bug 15622

Summary:	websockify missing a require on python-pkg-resources
Product:	Mageia	Reporter:	claire robinson <eeeemail>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	stormi-mageia, sysadmin-bugs
Version:	4	Keywords:	validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	has_procedure advisory mga4-64-ok mga4-32-ok
Source RPM:	websockify	CVE:
Status comment:

Description claire robinson 2015-04-03 19:02:52 CEST

Please see also bug 15481

Websockify is missing a require on python-pkg-resources. 
eg.

$ novnc_server
Warning: could not find self.pem
Starting webserver and WebSockets proxy on port 6080
Traceback (most recent call last):
  File "/usr/bin/websockify", line 5, in <module>
    from pkg_resources import load_entry_point
ImportError: No module named pkg_resources
Failed to start WebSockets proxy


Fixed by installing python-pkg-resources

Reproducible: 

Steps to Reproduce:

Comment 1 Thierry Vignaud 2015-04-03 21:01:43 CEST

Tidying bug report...

Keywords: (none) => Junior_job
Hardware: i586 => All
Source RPM: (none) => websockify

Comment 2 David Walser 2015-04-04 00:01:01 CEST

Freeze push requested for Cauldron.

Comment 3 David Walser 2015-04-04 17:18:11 CEST

Advisory:
----------------------------------------

The websockify program requires the pkg_resources Python module, but the
websockify package didn't require the package that contains this module.
This has now been corrected.

----------------------------------------

Updated packages in core/updates_testing:
----------------------------------------
python-websockify-0.5.1-3.1.mga4
websockify-0.5.1-3.1.mga4
python3-websockify-0.5.1-3.1.mga4

from python-websockify-0.5.1-3.1.mga4.src.rpm

Keywords: Junior_job => (none)
Assignee: bugsquad => qa-bugs

Comment 4 claire robinson 2015-04-10 17:50:43 CEST

Testing complete mga4 64

Before
------
# urpmq --requires python-websockify | grep pkg
--requires behaviour changed, use --requires-recursive to get the old behaviour


After
-----
# urpmq --requires python-websockify --media Testing | grep pkg
--requires behaviour changed, use --requires-recursive to get the old behaviour
python-websockify: python-pkg-resources

Whiteboard: (none) => mga4-64-ok

Comment 5 claire robinson 2015-04-10 17:58:09 CEST

In fact, the require is added to the python-websockify package but /usr/bin/websockify is provided by the websockify package, which itself has no requires.

So this looks to add the require to the wrong one. 

Adding feedback marker.

Whiteboard: mga4-64-ok => feedback

Comment 6 David Walser 2015-04-10 22:08:46 CEST

D'oh, the SRPM name confused me.  Thanks for catching that.  I just fixed it in SVN and asked for another freeze push in Cauldron.

Comment 7 David Walser 2015-04-13 22:48:04 CEST

python-websockify-0.5.1-3.1.mga4 has now been submitted (also the same fix is in Cauldron).

Whiteboard: feedback => (none)

Comment 8 Samuel Verschelde 2015-04-14 00:33:07 CEST

Once madb will have synced, an easy way to check is to use the RPMs page from the update candidate list. The diff links will show every change. We should see only added requires. 

http://mageia.madb.org/tools/listRpmsForQaBug/bugnum/15622/application/0

CC: (none) => stormi

Comment 9 claire robinson 2015-04-24 17:46:54 CEST

Testing complete mga4 64

Verified the altered require and tested with novnc as comment 0

Whiteboard: (none) => has_procedure mga4-64-ok

Comment 10 claire robinson 2015-04-24 18:00:35 CEST

Advisory uploaded.

Whiteboard: has_procedure mga4-64-ok => has_procedure advisory mga4-64-ok

Comment 11 claire robinson 2015-04-25 14:34:37 CEST

Testing complete mga4 32

Validating.

Please push to 4 updates

Thanks

Keywords: (none) => validated_update
Whiteboard: has_procedure advisory mga4-64-ok => has_procedure advisory mga4-64-ok mga4-32-ok
CC: (none) => sysadmin-bugs

Comment 12 Mageia Robot 2015-04-25 22:15:45 CEST

An update for this issue has been pushed to Mageia Updates repository.

http://advisories.mageia.org/MGAA-2015-0039.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED