Bug 15127

Summary: mageiawelcome generates an error on exit
Product: Mageia Reporter: Stephane <stephane_oss>
Component: RPM PackagesAssignee: Daniel Napora <napcok>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: Normal CC: anaselli, thierry.vignaud
Version: CauldronKeywords: PATCH
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard: MGA5TOO
Source RPM: mageiawelcome CVE:
Status comment:
Attachments: patch tested in mga4

Description Stephane 2015-01-24 19:33:07 CET
Description of problem:
Click on exit button on MageiaWelcome window and read .xsession-errors file.

Error message found in .xsession-errors file :
Traceback (most recent call last):
  File "/usr/share/mageiawelcome/mageiawelcome.py", line 241, in <module>
    my_quit_wrapper(main)()
  File "/usr/share/mageiawelcome/mageiawelcome.py", line 232, in fun2
    x = fun(*args, **kwargs) # equivalent to "apply"
  File "/usr/share/mageiawelcome/mageiawelcome.py", line 174, in main
    my_quit_wrapper()
TypeError: my_quit_wrapper() takes exactly 1 argument (0 given)

Version is mageiawelcome-0.8.10-1.mga5vwith Magiea5 beta5 updated.


This error has no impact because the window closes correctly.
David Walser 2015-01-26 21:50:36 CET

Assignee: bugsquad => napcok

Comment 1 Samuel Verschelde 2015-05-31 22:28:17 CEST
If still valid, valid in Mageia 5 too.

Whiteboard: (none) => MGA5TOO

Angelo Naselli 2015-07-17 10:02:40 CEST

CC: (none) => anaselli

Comment 2 Angelo Naselli 2015-07-17 10:14:21 CEST
Created attachment 6851 [details]
patch tested in mga4

my_quit_wrapper should be already called to invoke main, so there is no
need to clean up all again, a return should be enough i think.
I'm not a python developer though.
Thierry Vignaud 2015-09-16 11:41:27 CEST

Keywords: (none) => PATCH
CC: (none) => thierry.vignaud
Source RPM: (none) => mageiawelcome

Comment 3 Mageia Robot 2016-01-22 11:22:25 CET
commit 49335ed66f470a71b648f62a2fc0ba54ef7d5279
Author: Daniel Napora <napcok@...>
Date:   Fri Jan 22 11:22:14 2016 +0100

    no error on exit (mga#15127)
---
 Commit Link:
   http://gitweb.mageia.org/software/mageiawelcome/commit/?id=49335ed66f470a71b648f62a2fc0ba54ef7d5279
Comment 4 Daniel Napora 2016-01-22 11:23:37 CET
Closing, thanks Angelo.

Status: NEW => RESOLVED
Resolution: (none) => FIXED