| Summary: | mcc: port to WebKit2 | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Olav Vitters <olav> |
| Component: | RPM Packages | Assignee: | Thierry Vignaud <thierry.vignaud> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | mageia |
| Version: | Cauldron | Keywords: | PATCH, Triaged |
| Target Milestone: | Mageia 6 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | drakconf | CVE: | |
| Status comment: | |||
|
Description
Olav Vitters
2015-01-13 11:48:27 CET
David Walser
2015-01-13 16:49:46 CET
Assignee:
bugsquad =>
thierry.vignaud
Samuel Verschelde
2015-05-21 11:56:41 CEST
Keywords:
(none) =>
Triaged Yeah I should git push my gtk+3 conversion of mcc but I never finished the app start animation conversion to gtk+3 Source RPM:
drakx =>
drakconf
Thierry Vignaud
2015-05-27 11:04:55 CEST
Summary:
drakx: port to WebKit2 =>
mcc: port to WebKit2
Thierry Vignaud
2015-05-27 11:05:01 CEST
Keywords:
(none) =>
PATCH
Samuel Verschelde
2015-06-06 16:50:03 CEST
Target Milestone:
--- =>
Mageia 6 How much of an effort is left? Could you push your changes to a branch? I'm terrible with git, so probably cannot assist on a branch. Still, pretty curious about what changes need to be made and what is left. (In reply to Olav Vitters from comment #2) > I'm terrible with git, so probably cannot assist on a branch. I'm sure you'd handle it, you just need to checkout the branch: $ git checkout topic/webkit2 do stuff $ git commit -a -m 'did stuff' $ git push I'll try to push a clean gtk3 branch, just disabling what's broken I thought I'd find this in control-center or drakx module. Am I blind? http://gitweb.mageia.org/software/drakx/refs/heads http://gitweb.mageia.org/software/drakx-net/refs/heads http://gitweb.mageia.org/software/control-center/refs/heads Cannot find this branch? Or you mean I should create one? To start, I'd like to see what you already did so I don't have to start from scratch. I think Thierry hasn't pushed the said branch yet, and my "topic/webkit2" was just an example for git syntax, it doesn't exist either (yet). Rémi: I thought tv made both comments (3+4)! Assumed there was a hacky branch and in future a clean one. I guess I'm tired :P I've been the easy way: I've put my WIP about the animations, and committed what's clean/OK and released it in mcc I'd to disable startup animations as those are not yet completely converted and checkitem in menu is disabled. Closing Status:
NEW =>
RESOLVED Though about original comment "GNOME uses WebKit2". Well, gimp still pulls webkit1... :-) Thierry: Yeah, I noticed only recently (never imagined an image editor using webkit). I'm wondering whether to push 2.9.x; though 1) think it still uses webkit1 and 2) we'd as distribution on our own (all the others still have 2.8.x) 3) don't expect 2.10.x before Mageia 6 (it is going so slow!) An a photo editor it is pretty difficult to use, so maybe to save space on the live image we should replace it if still with webkit1. commit 883dfa207653b88aeaa8514b0283295775efa62f
Author: Thierry Vignaud <thierry.vignaud@...>
Date: Fri Mar 18 12:58:46 2016 +0100
port to WebKit2 (mga#15031)
---
Commit Link:
http://gitweb.mageia.org/software/control-center/commit/?id=883dfa207653b88aeaa8514b0283295775efa62f
Actually the work I did was only porting from gtk2 to gtk3. I've now ported it to WebKit2 too. It would be good to get this into Mageia 5 as well, as the security issues in webkit1 aren't going away. Bug 18015 talks about other packages affected by this. (In reply to Thierry Vignaud from comment #13) > Actually the work I did was only porting from gtk2 to gtk3. > I've now ported it to WebKit2 too. Thanks!! (In reply to David Walser from comment #14) > It would be good to get this into Mageia 5 as well, as the security issues > in webkit1 aren't going away. Bug 18015 talks about other packages affected > by this. We just need to backport my wekbkit2 patch in perl-Gtk3-WebKit and then to backport drakconf-13.3: http://svnweb.mageia.org/packages?view=revision&revision=976182 http://svnweb.mageia.org/packages/cauldron/perl-Gtk3-WebKit/current/SOURCES/WebKit2.diff?revision=976182&view=markup Actually we still need to port display_help (used for help in mcc) The thing is, the post is easy (already done here locally) but would need to port blino's patch from webkit1 to webkit2 (webkit-2.1.90-allowScriptsToCloseWindows.patch ) CC:
(none) =>
mageia or maybe not we can just hook on the "close" signal. But I don't where I can test it commit 0102ac3d9d7b57898b8e493a6c2ade90ee14d395
Author: Thierry Vignaud <thierry.vignaud@...>
Date: Mon Mar 21 16:23:23 2016 +0100
add bug ID (mga#15031)
---
Commit Link:
http://gitweb.mageia.org/software/drakx/commit/?id=0102ac3d9d7b57898b8e493a6c2ade90ee14d395
commit a24768779fe1adfd53c0b1d9a8cacc3d9fefbb03
Author: Thierry Vignaud <thierry.vignaud@...>
Date: Mon Mar 21 16:23:58 2016 +0100
port from WebKit1 to WebKit2 (mga#15031)
---
Commit Link:
http://gitweb.mageia.org/software/drakx/commit/?id=a24768779fe1adfd53c0b1d9a8cacc3d9fefbb03
|