| Summary: | switch_themes script in bootsplash should rebuild the initrd when updating plymouth theme | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Rémi Verschelde <rverschelde> |
| Component: | RPM Packages | Assignee: | All Packagers <pkg-bugs> |
| Status: | NEW --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | marja11, shlomif, tmb, watersnowrock, zen25000 |
| Version: | Cauldron | ||
| Target Milestone: | Mageia 7 | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | MGA5TOO | ||
| Source RPM: | bootsplash-3.3.11-4.mga5 | CVE: | |
| Status comment: | |||
CC'ing shlomi who is the maintainer of bootsplash. WDYT? CC:
(none) =>
shlomif
Rémi Verschelde
2015-01-10 14:37:10 CET
CC:
(none) =>
zen25000 Hello Rémi, (In reply to Rémi Verschelde from comment #1) > CC'ing shlomi who is the maintainer of bootsplash. WDYT? no idea about that - I just adopted bootsplash because it was an orphan and I'm not knowledgeable about it. If you want, I can revoke my maintainer status of it. Regards, -- Shlomi Fish
Samuel Verschelde
2015-05-31 23:19:31 CEST
Whiteboard:
(none) =>
MGA5TOO Adding to the Mageia 6 tracker so that we don't forget about it (though the whole theme scripts should probably be completely reworked for Mageia 6, thus obsoleting this report). Blocks:
(none) =>
15527
Samuel Verschelde
2015-06-02 10:01:55 CEST
Target Milestone:
--- =>
Mageia 6 Rémi, is this worth an ERRATA entry? I think so, at least if installing a custom theme (e.g. plymouth-theme-glow) does not trigger a rebuild of the initrd. I'll try that to confirm. Whiteboard:
MGA5TOO =>
MGA5TOO FOR_ERRATA Actually no, custom plymouth themes do trigger a rebuild of the initrd when installed. It's only if you update mageia-theme-Default that no rebuild is done, so it shouldn't affect Mageia 5 users (unless we provide an update to mageia-theme and forget about this bug). Whiteboard:
MGA5TOO FOR_ERRATA =>
MGA5TOO (In reply to Rémi Verschelde from comment #4) > Adding to the Mageia 6 tracker so that we don't forget about it (though the > whole theme scripts should probably be completely reworked for Mageia 6, > thus obsoleting this report). And? Did the scripts get reworked, too? CC:
(none) =>
marja11 Not that I know of, but it's not critical for Mageia 6 as long as the initrd is properly rebuilt for the new theme before making the ISOs. Blocks:
15527 =>
18932 Assigning to all packagers collectively since Shlomi has no idea how to fix it. Blocks:
18932 =>
(none) This should be added, while it's unlikely that an update to Mageia-theme would be shipped, the penalty for having this is small. Rebuilding the initrd should take too long and while the regularity of kernel updates flush this out to a large degree, it is surely still good form to have the the initrd rebuild to show any theme changes in case we get another Mageia 2 like incident. CC:
(none) =>
watersnowrock If you restrict it to rebuilding current initrd it could be ok. But its not ok to rebuild all found initrds as it could cause a previous working kernel/initrd to becomu unbootable in case there is some bugs, rendering the recovery processes unusable... |
As pointed out in 14864, updating mageia-theme-Default (which calls among others /usr/share/bootsplash/scripts/switch_themes Mageia-Default in its %posttrans) should rebuild the initrd. Barry experienced that it's necessary at least for grub2 users (I did not need to do so here on a system with grub legacy). Currently in its "update" function switch_themes calls: if [[ -z $update ]]; then /usr/sbin/plymouth-set-default-theme $theme fi /usr/sbin/plymouth-set-default-theme has a --rebuild-initrd switch: -R, --rebuild-initrd Rebuild initrd (necessary after changing theme) Adding this switch to the switch_themes instruction should do the trick. Reproducible: Steps to Reproduce: