| Summary: | silicon-empire segfaults and can not detect optical drive (missing buildrequires) | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Oleg Bosis <olegbosis> |
| Component: | RPM Packages | Assignee: | Matteo Pasotti <matteo.pasotti> |
| Status: | RESOLVED OLD | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | geiger.david68210, herman.viaene, lewyssmith, matteo.pasotti, olegbosis, qa-bugs |
| Version: | 5 | Keywords: | Junior_job, PATCH, feedback |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | silicon-2.0.0-3.mga5.src.rpm | CVE: | |
| Status comment: | |||
| Attachments: | The fixed spec file for silicon 2.0.0 | ||
|
Description
Oleg Bosis
2015-01-06 12:49:29 CET
Thanks for the patch, sorry that it got overlooked. Assigning to maintainer. Keywords:
(none) =>
Junior_job, PATCH Hello, there's an updated package for silicon empire (silicon-2.0.0-3.1.mga5) inside core/updates_testing waiting for validation. The updated package provides missing plugins by adding the build requirements previously noted. New plugins will be provided with this update: - plugin-eraser - plugin-mkisofs - plugin-udisks - plugin-fuseiso - plugin-mpg123 - plugin-audio-cd-record - plugin-cd-record - plugin-mkdiscfs - plugin-read-cd I made some local test and it seems to properly work. Regards Matteo, please assign to the QA team and write an advisory with list of RPMs and SRPMs if you want the update validated: https://wiki.mageia.org/en/Updates_policy#Maintainer_.28or_any_interested_packager.29 I have uploaded a patched package for Mageia 5. You can test this by installing the new plugins and by trying to enter data disc application in CD or DVD sections. Suggested advisory: ======================== Updated silicon empire packages fix the reported bug by providing plugins previously not built. New plugin packages will be provided alongside this update: - plugin-eraser - plugin-mkisofs - plugin-udisks - plugin-fuseiso - plugin-mpg123 - plugin-audio-cd-record - plugin-cd-record - plugin-mkdiscfs - plugin-read-cd ======================== Updated packages in core/updates_testing: ======================== silicon-2.0.0-3.1.mga5 silicon-plugin-audio-cd-record-2.0.0-3.1.mga5 silicon-plugin-cd-record-2.0.0-3.1.mga5 silicon-plugin-eraser-2.0.0-3.1.mga5 silicon-plugin-fuseiso-2.0.0-3.1.mga5 silicon-plugin-lyric-browser-2.0.0-3.1.mga5 silicon-plugin-mkdiscfs-2.0.0-3.1.mga5 silicon-plugin-mkisofs-2.0.0-3.1.mga5 silicon-plugin-mpg123-2.0.0-3.1.mga5 silicon-plugin-now-playing-2.0.0-3.1 silicon-plugin-read-cd-2.0.0-3.1.mga5 silicon-plugin-single-inner-dialog-2.0.0-3.1.mga5 silicon-plugin-system-tray-2.0.0-3.1.mga5 silicon-plugin-tagarg-audio-disc-2.0.0-3.1.mga5 silicon-plugin-udisks-2.0.0-3.1.mga5 Source RPMs: silicon-2.0.0-3.1.mga5.src.rpm Assignee:
matteo.pasotti =>
qa-bugs
David Walser
2016-05-18 03:30:37 CEST
Version:
Cauldron =>
5
Matteo Pasotti
2016-05-18 09:38:32 CEST
CC:
(none) =>
matteo.pasotti @Oleg Trying M5 x64, real hardware with a DVD drive. I installed issued Silicon & the 5 avaiable plugins: silicon-2.0.0-3.mga5 silicon-plugin-lyric-browser-2.0.0-3.mga5 silicon-plugin-now-playing-2.0.0-3.mga5 silicon-plugin-single-inner-dialog-2.0.0-3.mga5 silicon-plugin-system-tray-2.0.0-3.mga5 silicon-plugin-tagarg-audio-disc-2.0.0-3.mga5 Launching it from the menu (in Tools, NO icon at least under XFCE) shows: - a left pane with 'Favourites' and 'Discs & Images', - the main pane empty, - two buttons at the bottom 'View' & 'Search'; clicking Search pops up an input field. The top left Silicon icon does nothing; the top right Tool icon raises a proper menu of various things - but not those cited. I am at a loss as to how to apply the simple manoeuvres described in Comment 0 Steps 2-3. Please explain to a complete newbie. This should be easy to test if one knows how to drive the program. CC:
(none) =>
lewyssmith (In reply to Lewis Smith from comment #6) > I am at a loss as to how to apply the simple manoeuvres described in Comment > 0 Steps 2-3. Please explain to a complete newbie. This should be easy to > test if one knows how to drive the program. You have not installed reqired plugins. Required plugins to reproduce problems are: silicon-audio-disc-2.0.0-3.mga5 silicon-copy-disc-2.0.0-3.mga5 silicon-data-disc-2.0.0-3.mga5 silicon-disc-details-2.0.0-3.mga5 silicon-disc-eraser-2.0.0-3.mga5 silicon-disc-imaging-2.0.0-3.mga5 silicon-disc-scanner-2.0.0-3.mga5 silicon-image-burner-2.0.0-3.mga5 Install them and try to use. Trying M5 x64 Oleg: thanks for your advice in Comment 7. I installed the extra issued pkgs you cited, to give me in total, BEFORE the update: silicon-2.0.0-3.mga5 silicon-audio-disc-2.0.0-3.mga5 silicon-copy-disc-2.0.0-3.mga5 silicon-data-disc-2.0.0-3.mga5 silicon-disc-details-2.0.0-3.mga5 silicon-disc-eraser-2.0.0-3.mga5 silicon-disc-imaging-2.0.0-3.mga5 silicon-disc-scanner-2.0.0-3.mga5 silicon-image-burner-2.0.0-3.mga5 silicon-plugin-lyric-browser-2.0.0-3.mga5 silicon-plugin-now-playing-2.0.0-3.mga5 silicon-plugin-single-inner-dialog-2.0.0-3.mga5 silicon-plugin-system-tray-2.0.0-3.mga5 silicon-plugin-tagarg-audio-disc-2.0.0-3.mga5 Now the LH panel shows both CD and DVD items, and clicking those shows in the main pane (among other things) Data Disc, Disk Imaging, Image Burner options. Double-clicking these as per the Comment 0 tests gave the negative results expected: crashes or empty optical device combo choice. Updated all these to, AFTER update: silicon-2.0.0-3.1.mga5 silicon-audio-disc-2.0.0-3.1.mga5 silicon-copy-disc-2.0.0-3.1.mga5 silicon-data-disc-2.0.0-3.1.mga5 silicon-disc-details-2.0.0-3.1.mga5 silicon-disc-eraser-2.0.0-3.1.mga5 silicon-disc-imaging-2.0.0-3.1.mga5 silicon-disc-scanner-2.0.0-3.1.mga5 silicon-image-burner-2.0.0-3.1.mga5 silicon-plugin-lyric-browser-2.0.0-3.1.mga5 silicon-plugin-now-playing-2.0.0-3.1.mga5 silicon-plugin-single-inner-dialog-2.0.0-3.1.mga5 silicon-plugin-system-tray-2.0.0-3.1.mga5 silicon-plugin-tagarg-audio-disc-2.0.0-3.1.mga5 Note that the new plugins cited in Comment 5 are not pulled in by the update; presumably they would have to be explicitly installed. The simple tests were *not* successful: - CD or DVD/ Data Disc still crashed. - CD OR DVD / Disc Imaging gives a combo box with the (source?) device list above, still empty; whose selection arrow on the right is overlaid by a tool which pops up a small menu. The lower 'Please select a disc image' field is headed 'To'; the destination. - CD or DVD / Image Burner combo box has the source 'Please select a Disc Image' field at the top, with the same tool menu icon overlaid on the RH side - which impedes raising the file selection dialogue. The lower 'To' device combo list is still empty - whether there is a disc in it or not, and whether a disc (ISO) image has been selected or not. I will re-try after logging out/in in case that has an effect. (In reply to Lewis Smith from comment #8) > Trying M5 x64 > > The simple tests were *not* successful: > - CD or DVD/ Data Disc still crashed. > - CD OR DVD / Disc Imaging gives a combo box with the (source?) device list > above, still empty; Probably you are right. This is because of the wrong BR on pkgconfig(udisks) instead of udisks (1.0.x) itself. The program do not use udisks libs, instead it uses the tool 'udisks' directly and checks its presence on building. Oleg So what are we going to do about this? It is a substantial update, and we cannot simply leave it not resolving the issues for which it was raised. It could not be pushed in its current state. (In reply to Lewis Smith from comment #10) > So what are we going to do about this? It is a substantial update, and we > cannot simply leave it not resolving the issues for which it was raised. It > could not be pushed in its current state. What's the problem? All the plugins are currently in repository (broken ones). Fixing them just requires correcting BRs. What is substantial here? It's just fixing broken functionality, no any new features, no any new packages, nothing new at all... BTW silicon seems to be abandonware. The latest official version was released almost three years ago, official site ( Getsilicon.org ) died, lauchpad ( https://launchpad.net/silicon ) has greatly outdated version, latest commit in gitorious ( https://gitorious.org/silicon/empire ) is dated back to May 2014 (marked as Qt5 port) and repository is read-only. This bug report was filled by me 1,5 years ago... Is it worth to fix the package and keep it in repository (even if it's possible to fix)? Oleg I should have asked this before: re Comment 9 & Comment 11, what is "BR"? Why does the update work for you, but not for me? When I said in Comment 10 "It is a substantial update", I meant it involves a lot of packages. I am unclear of the difference between the plugins you cited in Comment 7 (which do not carry the name 'plugin'), and all those in the update Comment 5 (which do). In the light of: > BTW silicon seems to be abandonware. The latest official version was released > almost three years ago, official site ( Getsilicon.org ) died, lauchpad > ( https://launchpad.net/silicon ) has greatly outdated version, latest commit > in gitorious ( https://gitorious.org/silicon/empire ) is dated back to May 2014 > (marked as Qt5 port) and repository is read-only. This bug report was filled by > me 1,5 years ago... Is it worth to fix the package and keep it in repository > (even if it's possible to fix)? it certainly looks as if this could be dropped. Is it in Mageia 6? (In reply to Lewis Smith from comment #12) > I should have asked this before: re Comment 9 & Comment 11, what is "BR"? > Why does the update work for you, but not for me? > BR means BuildRequires )) Update '2.0.0-3.1.mga5' won't work for me as well (I even won't waste my time trying to run it because I see the wrong BR in it). I've made my own build with proper BRs back in 2015 and that build worked. To make 3.1 work you need to replace BuildRequires: pkgconfig(udisks) with BuildRequires: udisks as stated in my very first comment. This change should fix most crashes and make the program work. Just try it. > I am unclear of the difference between the plugins you cited in Comment 7 > (which do not carry the name 'plugin'), and all those in the update Comment 5 > (which do). I don't know. I guess it's original packager's decision to separate main functionality (CD/DVD operations) and optional features (audio playing, system tray & Ko). I'd packaged all main stuff into the main package 'silicon' and all additional stuff into second package 'silicon-plugins'. That would be enough. But now it doesn't matter any more. Oleg Thanks for you explanation above; I agree with your end summary - ideally 2 packages. This looks like a packaging issue, not my territory at all; and why your earlier comments meant nothing to me. I thought *you* were the packager! If you are, then can you do what you suggest (and update the version)? If not - can we find someone? silicon-2.0.0-3.2.mga5 is now available from the repo core/updates_testing. This last subrelease was built against the proper BR (i.e. udisks). Why replace BuildRequires pkgconfig(udisks) to udisks? as pkgconfig(udisks) requires already udisks, this change has no sense. And why use "BuildRequires: udisks" if it is for use after "Requires: udisks2", this has no sense too. There are two separate packages udisks and udisks2. I think the only one real fix is to add "Requires: udisks" CC:
(none) =>
geiger.david68210 David you're perfectly right, I'm already reverting the last commit and gonna submit the new package within the next few hours. @ Matteo: Also don't forget to add another Requires on "fuseiso" :) silicon-2.0.0-3.3.mga5 is now available from mga5's core/updates_testing. Testing M5 x64 with one DVD R/W device Having already updated to 2.0.0-3.1.mga5 Comment 8, I UNinstalled all Silicon packages, and re-installed from issued repos: silicon-2.0.0-3.mga5 silicon-audio-disc-2.0.0-3.mga5 silicon-copy-disc-2.0.0-3.mga5 silicon-data-disc-2.0.0-3.mga5 silicon-disc-details-2.0.0-3.mga5 silicon-disc-eraser-2.0.0-3.mga5 silicon-disc-imaging-2.0.0-3.mga5 silicon-disc-scanner-2.0.0-3.mga5 silicon-image-burner-2.0.0-3.mga5 silicon-plugin-lyric-browser-2.0.0-3.mga5 silicon-plugin-now-playing-2.0.0-3.mga5 silicon-plugin-single-inner-dialog-2.0.0-3.mga5 silicon-plugin-system-tray-2.0.0-3.mga5 silicon-plugin-tagarg-audio-disc-2.0.0-3.mga5 the basis of the errors described in Comment 0. Note that the 9 new plugins Comment 5: silicon-plugin-audio-cd-record-2.0.0-3.1.mga5 silicon-plugin-cd-record-2.0.0-3.1.mga5 silicon-plugin-eraser-2.0.0-3.1.mga5 silicon-plugin-fuseiso-2.0.0-3.1.mga5 silicon-plugin-mkdiscfs-2.0.0-3.1.mga5 silicon-plugin-mkisofs-2.0.0-3.1.mga5 silicon-plugin-mpg123-2.0.0-3.1.mga5 silicon-plugin-read-cd-2.0.0-3.1.mga5 silicon-plugin-udisks-2.0.0-3.1.mga5 were not available for installation; being only in Updates Testing. Then UPDATED all the installed pkgs from Updates Testing to: silicon-2.0.0-3.3.mga5 silicon-audio-disc-2.0.0-3.3.mga5 silicon-copy-disc-2.0.0-3.3.mga5 silicon-data-disc-2.0.0-3.3.mga5 silicon-disc-details-2.0.0-3.3.mga5 silicon-disc-eraser-2.0.0-3.3.mga5 silicon-disc-imaging-2.0.0-3.3.mga5 silicon-disc-scanner-2.0.0-3.3.mga5 silicon-image-burner-2.0.0-3.3.mga5 silicon-plugin-lyric-browser-2.0.0-3.3.mga5 silicon-plugin-now-playing-2.0.0-3.3.mga5 silicon-plugin-single-inner-dialog-2.0.0-3.3.mga5 silicon-plugin-system-tray-2.0.0-3.3.mga5 silicon-plugin-tagarg-audio-disc-2.0.0-3.3.mga5 which, like Comment 8, *still* failed the simple tests described in Comment 0. So the update in itself achieves nothing for already installed Silicon. I then enabled Updates Tesing as an *installation* medium, and *installed* directly from there the 9 new plugins: silicon-plugin-audio-cd-record-2.0.0-3.3.mga5 silicon-plugin-cd-record-2.0.0-3.3.mga5 silicon-plugin-eraser-2.0.0-3.3.mga5 silicon-plugin-fuseiso-2.0.0-3.3.mga5 silicon-plugin-mkdiscfs-2.0.0-3.3.mga5 silicon-plugin-mkisofs-2.0.0-3.3.mga5 silicon-plugin-mpg123-2.0.0-3.3.mga5 silicon-plugin-read-cd-2.0.0-3.3.mga5 silicon-plugin-udisks-2.0.0-3.3.mga5 giving a total installed set of: silicon-2.0.0-3.3.mga5 silicon-audio-disc-2.0.0-3.3.mga5 silicon-copy-disc-2.0.0-3.3.mga5 silicon-data-disc-2.0.0-3.3.mga5 silicon-disc-details-2.0.0-3.3.mga5 silicon-disc-eraser-2.0.0-3.3.mga5 silicon-disc-imaging-2.0.0-3.3.mga5 silicon-disc-scanner-2.0.0-3.3.mga5 silicon-image-burner-2.0.0-3.3.mga5 silicon-plugin-audio-cd-record-2.0.0-3.3.mga5 silicon-plugin-cd-record-2.0.0-3.3.mga5 silicon-plugin-eraser-2.0.0-3.3.mga5 silicon-plugin-fuseiso-2.0.0-3.3.mga5 silicon-plugin-lyric-browser-2.0.0-3.3.mga5 silicon-plugin-mkdiscfs-2.0.0-3.3.mga5 silicon-plugin-mkisofs-2.0.0-3.3.mga5 silicon-plugin-mpg123-2.0.0-3.3.mga5 silicon-plugin-now-playing-2.0.0-3.3.mga5 silicon-plugin-read-cd-2.0.0-3.3.mga5 silicon-plugin-single-inner-dialog-2.0.0-3.3.mga5 silicon-plugin-system-tray-2.0.0-3.3.mga5 silicon-plugin-tagarg-audio-disc-2.0.0-3.3.mga5 silicon-plugin-udisks-2.0.0-3.3.mga5 And this lot did indeed resolve the described faults: - CD or DVD -> Data disc does *not* crash, but continues. - CD or DVD -> Disk Imaging top combo box shows the DVD device. - CD or DVD -> Image Burner bottom combo box shows the DVD device. However, as previously noted, in both the pop-up dialogues for the last two, the right-hand control of the top combo box is hidden behind a tool pop-up menu, making their use for selection difficult but not impossible. That would be a bug for a maintained package, but this one is dead. This update seems to need to 'push' unilaterally the 9 new plugins - or possibly just 'silicon-plugin-udisks' - to resolve the problems described. Is this possible? Once itself pushed to standard repos, the new plugins would then be available for a new Silicon installation, and avoid the earlier faults *if* all are chosen. OTOH I suspect that just 'silicon-plugin-udisks' is the one that matters. If so, and it is essential, should that be made a dependancy of the base 'silicon' package? Yes, I confirm that it doesn't crash but... The reason for crashes was silicon-plugin-udisks-2.0.0. This "plugin" is a hard requirement for all other CD/DVD tools. If it's missing those tools do crash. So it has to be made "Requires" for every CD/DVD tool or (much better) for the main package itself. Or, even better, this subpackage should be removed and its content (single library libUDisks.so) should be packaged into main package. @Matteo, Oleg, DavidG This has become a farce. If I understand things correctly: - 'silicon-plugin-udisks' is *required* to make silicon work overall. - That is *not* currently available for installation, being *only* available as part of this update. - The currently available silicon pkg + all extras cannot entirely work, since it does not even offer 'silicon-plugin-udisks'. - Just updating any installed silicon will not (as the update stands) pull in the *new* 'silicon-plugin-udisks', so will achieve nothing. - 'silicon-plugin-udisks' needs to be force-fed as part of the update so that silicon works overall, whether updated or subsequently freshly installed. It is just a packaging issue. The simplest seems to be to make 'silicon-plugin-udisks' a requirement of the main 'silicon' package. It should be such that updating from currently issued 2.0.0-3 will pull it in; also that installing silicon after the update is pushed will also pull it in. Can this be done? Is it worth it considering Comment 11? I dare not comment on the neater packaging options mentioned earlier. Why the whole lot is not offered as one 'silicon' pkg baffles me; but presumably that would require this update (if it ever happens) to remove all the extra ones. Yes I agree too for adding "silicon-plugin-udisks" as a Requires in the main package on silicon. @Matteo: also Cauldron needs the same change. Done! should be fixed for Cauldron and for mga5 too adding silicon-plugin-udisks as a requires in the main package. Great! Thanks. But I think this is not the last problem with plugin dependencies in this program. For example I see two subpackages called silicon-plugin-mkdiscfs and silicon-plugin-mkisofs. Are they required for writing disks? Will disk writing or imaging really work if these plugins are missing? I have not tested it so I don't know the answer. Also what's the use of fuseiso plugin? What is the use of silicon-plugin-audio-cd-record and silicon-plugin-cd-record plugins? All these plugins were not available initially and I do suspect they require additional changes to "Requires" sections of silicon subpackages. Yes, I've made a quick test and found that writing to image file doesn't work without silicon-plugin-mkisofs. MGA5-32 on AcerD620 Xfce No installation issues, apart from the fact it is a tedious operation having to select all plugins manually one by one. Once done, silicon starts from CLI, CLI is immediately free, and gives no feedback whatsoever. All I could do was display the info of the DVD player and the DVD inserted. I tried to make an image of the DVD or to copy the DVD, but the interface, how does it work???? Single click on the operation icon does not do anything, double click starts it twice, You get the list of processes, so you can delete one of them, but then afterwards nothing happens, no disk activity, nothing. Yes, all packages t(and a few more) from Comment 20 were installed. CC:
(none) =>
herman.viaene (In reply to Herman Viaene from comment #27) > I tried to make an image of the DVD or to copy the DVD, but the interface, > how does it work???? Single click on the operation icon does not do > anything, double click starts it twice, You get the list of processes, so > you can delete one of them, but then afterwards nothing happens, no disk > activity, nothing. Thanks for your input. I found that double-clicking icons in the RH panel fired them up OK. I am asking for feedback because this needs packaging decisions. Whiteboard:
(none) =>
feedback Assigning Matteo again. Please reassign when ready. Thanks. CC:
(none) =>
qa-bugs
Frédéric "LpSolit" Buclin
2017-09-06 16:10:25 CEST
Keywords:
(none) =>
feedback Sorry that we weren't able to fix this. Resolution:
(none) =>
OLD |