Bug 14953

Summary:	Review Request: chksession should handle DesktopNames key
Product:	Mageia	Reporter:	Luc Menut <lmenut>
Component:	RPM Packages	Assignee:	Luc Menut <lmenut>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	release_blocker	CC:	mageia, olav, pterjan, thierry.vignaud
Version:	Cauldron	Keywords:	PATCH
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	desktop-common-data-3.7-4.mga5	CVE:
Status comment:
Attachments:	add DesktopNames key support in chksession

Description Luc Menut 2015-01-05 14:43:02 CET

Created attachment 5786 [details]
add DesktopNames key support in chksession

As spotted by Olav Vitters on dev mailing list, chksession should write DesktopNames key in session desktop files, so that display managers can set XDG_CURRENT_DESKTOP from this key as it is expected nowadays (cf. references and mail from David Faure on the kde-packager mailing list).

The attached patch add this support to chksession.
As I'm not a perl dev, I ask review for this patch from devs that know perl far better than me.

References:
https://ml.mageia.org/l/arc/dev/2015-01/msg00077.html
https://bugzilla.gnome.org/show_bug.cgi?id=727546
https://git.gnome.org/browse/gdm/commit/?id=af384da3c72efee40dcba48bb0e3e2ad6a08f6e4
https://git.reviewboard.kde.org/r/117400/
http://quickgit.kde.org/?p=kde-workspace.git&a=commit&h=e7ce8adc506068491c8545a1990992267598bd33

-------- Message transféré --------
Sujet : kdm/gdm and DesktopNames
Date : Wed, 09 Apr 2014 10:07:47 +0200
De : David Faure <faure@kde.org>
Organisation : KDE
Pour : kde-packager@kde.org

Dear packagers,

as of this week, both gdm and kdm will read the DesktopNames entry in the 
sessions desktop files (e.g. /usr/share/xsessions/*.desktop) and set 
XDG_CURRENT_DESKTOP from that string, when logging in.

See https://git.reviewboard.kde.org/r/117400/ for more details.

I have added DesktopNames keys to the desktop files shipped by kdm, but I 
think most distributions provide their own, as part of the various DEs and 
WMs. In that case, please make sure to add a DesktopNames key to these files.
You can find examples of spelling for DesktopNames in the desktop entry spec, 
since it matches the spelling in OnlyShowIn in application .desktop files.


BTW the reason for it to be a list is the gnome forks, e.g.
DesktopNames=GNOME-Classic;GNOME;
i.e. it inherits the GNOME stuff.
Good thing we don't have such forks in KDE :)

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5
--------

Comment 1 Mageia Robot 2015-01-07 19:47:33 CET

commit 8f83679473fe87962325bd6ab8a9ba0877db54e8
Author: Luc Menut <lmenut@...>
Date:   Wed Jan 7 19:48:02 2015 +0100

    sbin/chksession: add support for DesktopNames
    
    write DesktopNames in session desktop files if DESKTOPNAMES is defined
    in the session config file (mga#14953)
---
 Commit Link:
   http://gitweb.mageia.org/software/desktop/common-data/commit/?id=8f83679473fe87962325bd6ab8a9ba0877db54e8

Comment 2 Luc Menut 2015-01-09 01:01:08 CET

I added the support of DesktopNames in chksession. It's available in desktop-common-date 3.9 .
If DESKTOPNAMES is defined in the config session file (in /etc/X11/wmsession.d), chksession adds the DesktopNames key to the generated session desktop file.
eg. for KDE
http://svnweb.mageia.org/packages?view=revision&revision=809144

Status: NEW => RESOLVED
Resolution: (none) => FIXED