Bug 14839

Summary:	In custom disk partitioning the buttons on the right hand side are only partially displayed
Product:	Mageia	Reporter:	Dick Gevers <dvgevers>
Component:	Installer	Assignee:	Thierry Vignaud <thierry.vignaud>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	normal
Priority:	release_blocker	CC:	eeeemail, ennael1, g.sprik, lewyssmith, mageia, rverschelde
Version:	Cauldron	Keywords:	NEEDINFO
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	5rc
Source RPM:	drakx-installer-stage2	CVE:
Status comment:
Attachments:	buttons Custom partitioning in 5beta3 dual ISO, 2015-02-05 Custom partitioning in 5beta3 dual ISO, in English this time Custom partitioning with stage2 16.62

Description Dick Gevers 2014-12-18 15:01:50 CET

Description of problem:

Until 5beta2 build2 no problem.
At introduction of new graphics, custom disk partitioning behaves didferently: the buttons on the right hand side (expert mode) are only partially displayed.

In made a screenshot with a camera and will attach it. Or from the installer screenshot if I find it.



Reproducible: 

Steps to Reproduce:

Dick Gevers 2014-12-18 15:02:42 CET

Source RPM: (none) => drakx-installer-stage2
Whiteboard: (none) => 5beta2
Assignee: bugsquad => ennael1

Comment 1 Dick Gevers 2014-12-18 15:08:14 CET

Created attachment 5729 [details]
buttons

Anne Nicolas 2014-12-20 12:47:05 CET

Assignee: ennael1 => thierry.vignaud

Comment 2 Dick Gevers 2014-12-21 23:19:27 CET

On a next try (next build, 64 bits), I notice that each partition being handled by diskdrake, makes the GUI grow in size a little, so after several drives, the GUI is of such size that the buttons on the right hand side fall off the screen.

So if less paritions were used than here (see screenshot) it will be less bad or not visible. If more, worse.

Hardware: i586 => All

Comment 3 Dick Gevers 2014-12-21 23:20:51 CET

Sorry the screenshot does not show it. But I was using 7 partitions.

Comment 4 Gerald 2015-01-25 10:56:39 CET

(In reply to Dick Gevers from comment #2)

> On a next try (next build, 64 bits), I notice that each partition being
> handled by diskdrake, makes the GUI grow in size a little, so after several
> drives, the GUI is of such size that the buttons on the right hand side fall
> off the screen.
> 
> So if less paritions were used than here (see screenshot) it will be less
> bad or not visible. If more, worse.

I have the same experience on a harddisk with "many" partitions. A custom disk partitioning is not possible.

CC: (none) => g.sprik

Comment 5 Martin Whitaker 2015-01-26 00:04:08 CET

This is an old bug that has reappeared - see bug 11988 for history. As I note there, I think it should be considered a release blocker, as it makes it impossible to install using custom disk partitioning when you have more than a few partitions.

Note also the associated problem of the window "jumping" to the left hand side (bug 12369) which was never fixed.

CC: (none) => mageia

Comment 6 Dick Gevers 2015-01-30 10:41:34 CET

Still valid. Making it release blocker, IMHO not acceptable for release of final. Change as needed.

Priority: Normal => release_blocker
Whiteboard: 5beta2 => 5beta3

Comment 7 Rémi Verschelde 2015-02-06 14:42:45 CET

Created attachment 5862 [details]
Custom partitioning in 5beta3 dual ISO, 2015-02-05

It's fixed in some way with the classical ISOs from 2015-02-05.
There are still some pixels missing from the buttons, but there is now a horizontal scrollbar, see the attached screenshot.

It would be great if the buttons could be made a couple of pixels smaller though to get rid of the useless scrollbar.

CC: (none) => remi

Comment 8 Rémi Verschelde 2015-02-06 14:55:18 CET

Created attachment 5863 [details]
Custom partitioning in 5beta3 dual ISO, in English this time

Same screenshot as previously, but with the English locale (it was Danish previously).

Here the buttons fit in the UI, there is no scrollbar, but it still looks a bit cramped. I think we should reduce the internal padding in the buttons, so that their minimal size fits in better in the UI.

Then for languages with really long button labels, it's ok to have a scrollbar IMO (but not if there are 40px internal padding on each sides of the button).

Comment 9 Mageia Robot 2015-02-17 23:43:43 CET

commit 32a9e3c6366361c1c6e6fce1594e2fc01da299ba
Author: unknown <ex.thierry.vignaud@...>
Date:   Thu Feb 12 15:38:30 2015 +0100

    switch to logarithm sizing of partition buttons
    
    instead of using a ratio to the total disk size in order to compute width
    share, we now  use the log of the partition size to the smallest one.
    
    this reduce the risk of having too small buttons, fixes several issues
    in the installer:
    - buttons being too big causing their box & thus the dialog to increase
      which triggers a gtk+ bug which makes the window to jump (mga#12422)
    - as well as several other related issues (mga#11988, mga#14839, mga#15272)
    
    (from Rosa but simplified)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=32a9e3c6366361c1c6e6fce1594e2fc01da299ba

 Bug links:
   Mageia
      https://bugs.mageia.org/14839
      https://bugs.mageia.org/15272
      https://bugs.mageia.org/12422
      https://bugs.mageia.org/11988

Comment 10 Mageia Robot 2015-02-19 10:31:55 CET

commit 1d57ba59bedf6fae41301720e71839eb91db3cce
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Thu Feb 19 09:41:04 2015 +0100

    use an horizontal scrolling bar when needed
    
    gtk+ sometimes doesn't respect our sizing which causes the container to
    enlarge (see previous commit)
    
    with previous commit, this reduce the risk of having too small buttons,
    and fixes several issues in the installer:
    - buttons being too big causing their box & thus the dialog to increase
      which triggers a gtk+ bug which makes the window to jump (mga#12422)
    - as well as several other related issues (mga#11988, mga#14839,
      mga#15272, mga#15264)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=1d57ba59bedf6fae41301720e71839eb91db3cce

 Bug links:
   Mageia
      https://bugs.mageia.org/14839
      https://bugs.mageia.org/15272
      https://bugs.mageia.org/12422
      https://bugs.mageia.org/15264
      https://bugs.mageia.org/11988

Comment 11 Thierry Vignaud 2015-02-19 10:37:33 CET

You can try Cauldron once your favorite mirror has this morning's installer (16.62).
Check install/stage2/VERSION
eg: http://distrib-coffee.ipsl.jussieu.fr/pub/linux/Mageia/distrib/cauldron/x86_64/install/stage2/VERSION
(not yet up to date)

Keywords: (none) => NEEDINFO

Comment 12 Rémi Verschelde 2015-02-19 11:44:42 CET

Created attachment 5931 [details]
Custom partitioning with stage2 16.62

Still not fixed, though as stated previously this is not a major blocker anymore IMO.

Attachment 5863 is obsolete: 0 => 1
Attachment 5862 is obsolete: 0 => 1

Comment 13 Thierry Vignaud 2015-02-19 11:59:54 CET

The buttons are properly displayed.
Window that jumps is bug #12422

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 14 Rémi Verschelde 2015-02-19 12:24:34 CET

(In reply to Thierry Vignaud from comment #13)
> The buttons are properly displayed.
> Window that jumps is bug #12422

Yes, what I meant is that the buttons are still somewhat too big for the window (like 10px), and if you chose a locale with longer strings than the English ones, then the buttons expand even more and you get an horizontal scrollbar.

But that's a minor issue IMO.

Comment 15 Thierry Vignaud 2015-02-19 13:01:07 CET

button sizing is done by gtk+ according to the theme which imposes some borders.
We cannot do anything about it.

Comment 16 Rémi Verschelde 2015-02-19 13:04:42 CET

Ok, then I'm fine with RESOLVED FIXED :-)

Comment 17 Dick Gevers 2015-02-26 16:44:19 CET

Beg pardon, but seeing this still in rc and I think the comment closing this bug earlier is too easy. Why not take it upstream, or choose an alternative. After all this makes Mageia installer look bad. Why do we swallow that?

I don't mean to offend anyone, but see if this can be reconsidered? Thanks.

I do not dare to reopen, but it should be thought about anyway.

CC: (none) => eeeemail, ennael1

Comment 18 claire robinson 2015-02-26 16:56:50 CET

The buttons being off screen is preventing installation, this should be reopened.

See eg. https://bugs.mageia.org/show_bug.cgi?id=15264#c9

Keywords: NEEDINFO => (none)
Status: RESOLVED => REOPENED
CC: (none) => lewyssmith
Resolution: FIXED => (none)
Whiteboard: 5beta3 => 5rc

Comment 19 Dick Gevers 2015-02-26 17:03:35 CET

To me it does not prevent installation: i can read all the buttons when handling the first partition. But after handling successive partitions the buttons are legible less and less. If adwaita cannot handle this, it is IMHO time to throw away adwaita. I di not want to see M5 released with all these graphical glitches: there just are too many making Mageia installer look bad :((

Comment 20 Thierry Vignaud 2015-02-26 18:02:09 CET

screenshot of RC1?

Keywords: (none) => NEEDINFO

Comment 21 Dick Gevers 2015-02-26 18:33:17 CET

Not available at this moment. but looking exactly the same as first attachment to this bug!

Comment 22 claire robinson 2015-02-26 18:36:06 CET

Lewis can you add one for your missing buttons please

Comment 23 Lewis Smith 2015-02-26 19:51:00 CET

(In reply to claire robinson from comment #22)
> Lewis can you add one for your missing buttons please
Need to find & re-open my own bug about 'missing' partition action buttons (& others overflowing the window) for GPT disc with many partitions Custom partitioning. I cannot find it with any search, even my own bugs. It had screen photographs. I think it was marked as duplicate of *this* bug.

This problem *is* serious in that it prevents installation of Mageia 5 if you hit it. It seems to be more a case of the buttons (mount point etc) being displaced beyond the window, rather than them simply being too big.

Comment 24 Mageia Robot 2015-02-27 20:06:02 CET

commit a674dfbf7d84330dca4f3bf58f61f4ef35fd15fc
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Feb 27 20:02:20 2015 +0100

    fix too wide buttons
    
    closing mga#12422, mga#13471, mga#14839, mga#15379
    
    issue introduced in commit 1d4957dddcbf98c3a985186b8b61be2b3f004b3c
    but was showing only in some cases
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=a674dfbf7d84330dca4f3bf58f61f4ef35fd15fc

 Bug links:
   Mageia
      https://bugs.mageia.org/12422
      https://bugs.mageia.org/13471
      https://bugs.mageia.org/14839
      https://bugs.mageia.org/15379

Comment 25 Thierry Vignaud 2015-02-27 21:04:15 CET

Duplicate

*** This bug has been marked as a duplicate of bug 12422 ***

Status: REOPENED => RESOLVED
Resolution: (none) => DUPLICATE

Comment 26 Mageia Robot 2015-04-27 17:58:44 CEST

commit 77cd051688f1e8aae47aed0c8ac40ea45360461a
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Feb 27 20:02:20 2015 +0100

    fix too wide buttons
    
    closing mga#12422, mga#13471, mga#14839, mga#15379
    
    issue introduced in commit 1d4957dddcbf98c3a985186b8b61be2b3f004b3c
    but was showing only in some cases
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=77cd051688f1e8aae47aed0c8ac40ea45360461a

 Bug links:
   Mageia
      https://bugs.mageia.org/12422
      https://bugs.mageia.org/13471
      https://bugs.mageia.org/14839
      https://bugs.mageia.org/15379