| Summary: | Phototonic - an image viewer and organizer written on GNU/Linux in C++ and Qt 5 | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Pavel Fric <pavelfric> |
| Component: | New RPM package request | Assignee: | Barry Jackson <zen25000> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | Normal | CC: | geiger.david68210, zen25000 |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | CVE: | ||
| Status comment: | |||
| Attachments: |
spec file of phototonic
barjac's spec |
||
|
Description
Pavel Fric
2014-08-10 10:47:43 CEST
Working on it. Currently testing a preliminary package build locally and it looks good so far. CC:
(none) =>
zen25000 Created attachment 5337 [details]
spec file of phototonic
@ Barry Jackson
I've also working on it. :)
There is just two issues with the desktop file :
- a missing trailing symbol (;) on MimeType key
- a duplicate key on StartupNotify
See my attached spec file. :pCC:
(none) =>
geiger.david68210 Created attachment 5339 [details]
barjac's spec
Hi David,
Yes - I think the missing colon is a desktop-file-utils bug and I was considering the best way to report it. Remove it and it complains there should be one, add it and it complains that there should not be one :\
In git master the duplicated startup notify is fixed.
These are not needed:
BuildRequires: pkgconfig(Qt5Svg)
BuildRequires: qtimageformats5-devel
What is needed though is:
Suggests: %{_libdir}qtsvg5
Suggests: qtimageformats5
No idea about qttools5 ?? - I only have 3 buildrequires:
BuildRequires: pkgconfig(exiv2)
BuildRequires: pkgconfig(Qt5Core)
BuildRequires: pkgconfig(Qt5Widgets)
It builds in iurt and I have used it without problems.
My main concern now is how on earth are the translations supposed to be used/packaged? - Oh yes and docs :\
I will attach my current spec (it uses git master snapshot)
BTW - please feel free to take this if you wish, as I am short on time these days. Maybe pick the best of both specs :) (The %description formats nicely in rpmdrake as I have it) The build logs for the spec attached above are here: http://mtf.no-ip.co.uk/pub/linux/barjac/distrib/cauldron/x86_64/log/phototonic-1.03-0.206git.1.mga5.src.rpm/ OK I have taken the best bits from both specs and a working release version (not git master) is now in svn (not pushed). I have reported the missing license file upstream: https://github.com/oferkv/phototonic/issues/96 If they respond quickly, we can add it to the first build. @ Barry Jackson,
Why use %{_libdir}qtsvg5 on Suggests package ? rather it should be %{_lib}qtsvg5, no ?
Why not use '%makeinstall_std' macro ?
For me 'PREFIX=%{_prefix}' is really not needed.
I've also reported the 'missing trailing symbol (;) on the desktop file (MimeType key)' issue:
https://github.com/oferkv/phototonic/issues/95
(In reply to David GEIGER from comment #6) > @ Barry Jackson, > > Why use %{_libdir}qtsvg5 on Suggests package ? rather it should be > %{_lib}qtsvg5, no ? > True, silly typo/brain malfunction. > Why not use '%makeinstall_std' macro ? > No particular reason except that it seemed a bit overkill. It makes no difference that I can see here, but I'm happy to use it. > For me 'PREFIX=%{_prefix}' is really not needed. > True - It now seems not needed however at one early stage during testing I did find it was needed. OK, I guess it can go. I have committed the above changes silently. > > I've also reported the 'missing trailing symbol (;) on the desktop file > (MimeType key)' issue: > https://github.com/oferkv/phototonic/issues/95 OK good. Ah! - now I know who you are :) I'll leave it alone now. You can make any more tweaks and push it so you will get to maintain it :) Sorry if I trod on your toes :\ Oh I forgot to mention - I notice what appears to be a problem with the program.
When attempting to colour adjust an image ('c' while viewing), the image is dimmed, so the effect of the changes cannot be judged.
I see a few bug reports self-assigned by the developers which 'just might' be related to new features to overcome this, but it's unclear from the comments.
Do you see this effect or is it possibly theme/desktop-effects related I wonder?
(In reply to Barry Jackson from comment #7) > > > > Why use %{_libdir}qtsvg5 on Suggests package ? rather it should be > > %{_lib}qtsvg5, no ? > > > True, silly typo/brain malfunction. Ah Ok, good now :) > > Why not use '%makeinstall_std' macro ? > > > No particular reason except that it seemed a bit overkill. It makes no > difference that I can see here, but I'm happy to use it. True, there is no difference except that Mageia would like it is used to the extent possible. > Sorry if I trod on your toes :\ Oh no!! not at all, no problem for me. We're here to help each other :) Since you've already worked hard on the project phototonic, I prefer to leave it to you to maintain it. Besides, I have not tested the software as you and find bugs, so it would be better that you stay on the moves of the project progress. OK - thanks for your help, in that case :) I see both our bugs are fixed now in svn - nice to see a keen upstream :) I have patched both those issues in one patch so we can simply drop the patch when the next release comes along. So pushing to Cauldron and closing this bug. Status:
NEW =>
RESOLVED |