| Summary: | Diskdrake shows no partitions for sda (initially) when custom partitioning in 5alpha1 i586 live installer | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Barry Jackson <zen25000> |
| Component: | Installer | Assignee: | Thierry Vignaud <thierry.vignaud> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | release_blocker | CC: | eeeemail, ennael1, mageia, mageia, marja11, olav, rverschelde, unruh, westel |
| Version: | Cauldron | Keywords: | PATCH |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | 5RC | ||
| Source RPM: | CVE: | ||
| Status comment: | |||
| Attachments: | Screenshot | ||
|
Description
Barry Jackson
2014-07-04 18:42:33 CEST
Barry Jackson
2014-07-04 18:42:52 CEST
Whiteboard:
(none) =>
5alpha1 Created attachment 5254 [details]
Screenshot
Guessing this is probably to do with the ongoing gtk updates too. Might help to see what's going on if you could attach a report.bug from tty2 in the installer Barry. Try the 'bug' command to dump it onto a usb stick. Thanks CC:
(none) =>
eeeemail, olav I have done lots more testing tonight on this using: Mageia-5-alpha1-LiveCD-KDE4-en-i586-CD.iso (round 3) Mageia-5-alpha1-LiveDVD-KDE4-x86_64-DVD.iso (round 3) Mageia-5-alpha1-x86_64-DVD.iso Despite originally seeing this on the full DVD classical installer (unless I made a mistake on the pad), I can now only reproduce it using the i586 Live iso, and only when installing directly (not from live mode). @Claire - I tried using 'bug' command but it seems not to be available in the live install. Hardware:
x86_64 =>
i586
Barry Jackson
2014-07-05 00:56:42 CEST
Summary:
Diskdrake shows no partitions for sda (initially) when custom partitioning in 5alpha1 installer =>
Diskdrake shows no partitions for sda (initially) when custom partitioning in 5alpha1 i586 live installer Humm, that's a very old bug that strikes again (see eg: bug #5661 & bug #11988) I have seen it recently installing Mga5-RC. sda is blank until sdb tab is clicked and sda is clicked - from then on it works OK. I don't know what happens with only one drive as have only been testing multi-drive installs. I've seen it happening with mga4.1 classical installer and with mga5b3 live installer. Both were done with USB stick, so I was able to click on sdb and then again on sda. CC:
(none) =>
mageia
Sander Lepik
2015-03-12 10:04:18 CET
Priority:
Normal =>
release_blocker seen with pre-RC CC:
(none) =>
marja11 I've traced what's causing this behaviour.
When running on the desktop, the first switch_page signal received by the diskdrake notebook widget has a page index of 0. This causes the partition buttons and info for the first device (sda) to be generated and displayed once the widget is drawn.
When running in the installer, the first switch_page signal has a page index of 1 (this is with two devices present - I'd guess it would be the last page index with more devices). This causes the partition buttons and info for the second device (sdb) to be generated. However, when the widget is drawn, it is the first page that is displayed, hence no partition buttons and info.
This patch fixes the bug for me:
--- mdkinst/lib/libDrakX/diskdrake/hd_gtk.pm.orig 2015-03-18 21:24:09.126965475 +0000
+++ mdkinst/lib/libDrakX/diskdrake/hd_gtk.pm 2015-03-18 21:24:39.269821371 +0000
@@ -113,6 +113,7 @@
# ensure partitions bar is properly sized on first display:
$notebook_widget->signal_connect(realize => $update_all);
$w->sync;
+ $notebook_widget->set_current_page(0);
# workaround for $notebook_widget being realized too early:
if (!$done_button) {
$notebook_widget->set_current_page(-1);
P.S. In my case, sdb is the USB stick I'm using for the installation. Should this appear as an installation destination?
(In reply to Martin Whitaker from comment #10) > I've traced what's causing this behaviour. Nice! > P.S. In my case, sdb is the USB stick I'm using for the installation. Should > this appear as an installation destination? In that view it's not actually being suggested "as an installation destination" is it, so I would say yes it should be shown as it's part of the system at that time.
Rémi Verschelde
2015-03-19 15:22:39 CET
Keywords:
(none) =>
PATCH apparent in Mageia-5-RC-x86_64-DVD multiple HDDs system CC:
(none) =>
westel Thierry, can you review the patch and apply if it seems OK? Thanks for your patch Martin! As for bug 13894, I've added the proposed patch to the drakx-installer-stage2 package for now (drakx-installer-stage2-16.68-3.mga5). I'll let Thierry review the patch and commit it to the git repo if it's the good fix. (In reply to Rémi Verschelde from comment #14) > Thanks for your patch Martin! > > As for bug 13894, I've added the proposed patch to the > drakx-installer-stage2 package for now > (drakx-installer-stage2-16.68-3.mga5). I'll let Thierry review the patch and > commit it to the git repo if it's the good fix. I've tested "DrakX v16.68_3_Akien"-stage2 *5* times on a 64bits efi system where I've seen the bug several times, including on recent installs, but probably not in every install I did. Tested with and without ext. HD attached, directly going into Custom or first choosing to use existing partitions and then returning to the doPartitionDisks screen and then selecting "Custom", etc. ..... in all cases, the partitions were immediately visible after selecting "Custom" commit a6bbd53b018cff4c36b31347d72b8b915ffa8583
Author: Thomas Backlund <tmb@...>
Date: Fri Mar 20 22:33:54 2015 +0159
fix initial display in diskdrake (Martin Whitaker, mga#13679)
---
Commit Link:
http://gitweb.mageia.org/software/drakx/commit/?id=a6bbd53b018cff4c36b31347d72b8b915ffa8583
Fixed in last set of isos including this patch Status:
NEW =>
RESOLVED Thanks to all for fixing this. |