Bug 13640

Summary:	"Journalised FS: Btrfs" entry in diskdrake should be placed after "Linux swap" and "Linux native"
Product:	Mageia	Reporter:	Rémi Verschelde <rverschelde>
Component:	Installer	Assignee:	Mageia Bug Squad <bugsquad>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	Normal	CC:	thierry.vignaud
Version:	Cauldron	Keywords:	PATCH
Target Milestone:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:	5alpha1
Source RPM:	diskdrake-16.34-1.mga5	CVE:
Status comment:
Attachments:	improve fs sorting

Description Rémi Verschelde 2014-07-01 21:52:27 CEST

In diskdrake (and the custom partitioning tool in draklive-install), when creating a new partition, the drop-down list of filesystem types reads as follows:
- Linux swap
- Journalised FS: Btrfs
- Linux native
- Journalised FS: ext3
- Journalised FS: ext4
- Journalised FS: ReiserFS
... and so on.

The "Journalised FS: Btrfs" entry should be placed between the "Linux native" and "Journalised FS: ext3" (or someplace else, but I think it should be among the bloc of "Journalised FS" filesystem types.

Unless there is a reason why the list is displayed in this order?

Reproducible: 

Steps to Reproduce:

Rémi Verschelde 2014-07-01 21:52:37 CEST

Whiteboard: (none) => 5alpha1

Thierry Vignaud 2014-07-02 10:25:10 CEST

Keywords: (none) => PATCH
CC: (none) => thierry.vignaud

Comment 1 Thierry Vignaud 2014-07-02 10:25:47 CEST

Created attachment 5238 [details]
improve fs sorting

Comment 2 Rémi Verschelde 2014-07-02 19:18:41 CEST

Thanks for the patch Thierry!

Looking at it, I thought maybe another utility improvement could be to change the "Linux native" tag to "Linux native (ext2)"? I always wondered what that "Linux native" was, and if less advanced users were tempted to use because hey, it has Linux in the name :-)

Comment 3 Mageia Robot 2014-07-03 07:23:40 CEST

commit a16ea78775da43c9bd23c91fac21b3b7071e9226
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Thu Jul 3 07:22:40 2014 +0200

    improve fs sorting in combo box (mga#13640)
    
    was "misplaced" in commit 58bbc1fb86132ac8ca16bef41fb0e8c91960846f
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=a16ea78775da43c9bd23c91fac21b3b7071e9226

Comment 4 Thierry Vignaud 2014-07-03 07:23:55 CEST

fixed in git

Status: NEW => RESOLVED
Resolution: (none) => FIXED