Bug 13534

Also valid in cauldron, 64bits, drakxtools-16.32-1.mga5

Whiteboard: (none) => MGA4TOO
CC: (none) => marja11
Hardware: i586 => All
Version: 4 => Cauldron

What's the restult of the following command:
rpm -q perl-{Glib{,-Object-Introspection},Gtk3}

Keywords: (none) => NEEDINFO

As you apparently noticed, my perl-Glib was out of date.  I upgraded it and still get the same crash, but the message about "Can't locate object method" no longer appears, instead I get this message:

undefined value for mandatory argument 'str' encountered at /usr/libexec/drakclock line 49.

The Perl trace is exactly the same as before.

Sorry about the outdated package, they're all current now.

Please provide the requested info

Keywords: (none) => NEEDINFO

As if you don't know what the current versions are :P

perl-Glib-1.303.0-9.mga4
perl-Glib-Object-Introspection-0.18.0-2.mga4
perl-Gtk3-0.15.0-3.mga4

Maybe Marja can answer for her case (being Cauldron, it might actually be useful)

Keywords: NEEDINFO => (none)

I asked b/c the message obviously showed you'd some kind of broken system and b/c I cannot reproduce the next error.
Anyway that's a different issue

Status: NEW => RESOLVED
Resolution: (none) => INVALID

OK, so it was reported to me because it also happens in omdv which shares our code, and I verified that it happens in Mandriva as well.  Even with the packages you requested being up to date, it still happens.  Marja said it even happens in Cauldron.  I'm surprised you can't reproduce it, given how easy it is to reproduce it, but if you really can't, then I guess there's nothing you can do.

Resolution: INVALID => WONTFIX

Oops, I meant I verified it happens in Mageia as well.  I tested on Mageia 4, and yes there were originally outdated packages on it, but I update it.

(In reply to Thierry Vignaud from comment #2)
> What's the restult of the following command:
> rpm -q perl-{Glib{,-Object-Introspection},Gtk3}

[root@localhost marja]# rpm -q perl-{Glib{,-Object-Introspection},Gtk3}
perl-Glib-1.305.0-2.mga5
perl-Glib-Object-Introspection-0.23.0-2.mga5
perl-Gtk3-0.16.0-1.mga5
[root@localhost marja]# 

And I confirm having seen this in fully updated Mga4 and cauldron

I agree with "WONTFIX", though. It is a very minor issue.

For the record, the cauldron trace isn't exactly the same. line numbers are different:


The "drakclock" program has crashed with the following error:

  undefined value for mandatory argument 'str' encountered at /usr/libexec/drakclock line 49.
  Perl's trace:
  standalone::bug_handler() called from /usr/lib/perl5/vendor_perl/5.18.2/Gtk3.pm:292
  Gtk3::__ANON__() called from /usr/lib/libDrakX/mygtk3.pm:1530
  mygtk3::main() called from /usr/lib/libDrakX/ugtk3.pm:859
  ugtk3::main() called from /usr/libexec/drakclock:235

Used theme: oxygen-gtk

confirming mga4 crash.

Sorry Marja, I don't agree with the wontfix... A crash is a crash imho.

CC: (none) => anaselli

Created attachment 5198 [details]
patch to avoid the crash

David could you please test this patch and see if it has regression?

Angelo,

Thanks, the fix makes sense (and it works), and I played around with it a bit and don't see any regressions.

Status: RESOLVED => REOPENED
Resolution: WONTFIX => (none)

(In reply to David Walser from comment #12)
> Angelo,
> 
> Thanks, the fix makes sense (and it works), and I played around with it a
> bit and don't see any regressions.

OK I found another bug.  Not really a regression, you just couldn't do this before because of the crash.  If you hit Cancel and then hit Change Time Zone again, it selects the very first one (Africa > Abidjan) instead of your current time zone.

Also if you do change the time zone to something else (or it happens by accident as I described in Comment 13) and hit OK on the pop-up dialog, but then hit Cancel to exit drakclock itself, it really should not actually save that change, but it does.

Created attachment 5199 [details]
new patch to fix the problem

Attachment 5198 is obsolete: 0 => 1

on Comment #14
You are right:
timezone::write($timezone);
this line should be performed only at last Ok pressed not after time zome changes.
But I'm too tired to look where i leave this fixing to other hands...

Thanks, this is good progress.  With the updated patch it fixes the original bug and Comment 13's bug.  Comment 14 can wait for another day I guess :o)

That cannot be a proper fix.
If the user pick a TZ, it shouldn't be null.

On second though:
1) what desktop are you using?
2) are you just starting drakclock without even selecting a TZ?

Keywords: (none) => NEEDINFO

Created attachment 5202 [details]
workaround gtk+ firing signals too early w/o any reason

Does this patch fix it?

(In reply to Angelo Naselli from comment #10)
> confirming mga4 crash.
> 
> Sorry Marja, I don't agree with the wontfix... A crash is a crash imho.

I closed the bug b/c the initially reported error was obviously a not up to date system mixing mga4 with earlier packages, so when I ask not to mix different issues in the same report and to open a new bug report, please don't reopen it :-( !

Too late for this one now...

Created attachment 5203 [details]
fix crash on cancel

Created attachment 5204 [details]
complete fix including keeping old TZ value on cancel then reclick

Thierry i don't understand comment #18 sorry.
I'm using kde but that should not matter if I'm configuring clock souldn't it?

On comment #20, i believe that the not up2date system just hid the problem, that
indeed is present in 4 as well, in the sense that the bt was different, but the undef value was the same....

commit 2d150597360738d6fdecd24a21d4ce076469b1df
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Jun 20 09:28:52 2014 +0200

    fix crash on clicking Cancel after TZ selection (mga#13534)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=2d150597360738d6fdecd24a21d4ce076469b1df

commit d55fa70f6c5e3b2212e2eba7d9d97141efe3a4c4
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Jun 20 09:30:04 2014 +0200

    fix loosing TZ choice when canceling TZ selection (mga#13534)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=d55fa70f6c5e3b2212e2eba7d9d97141efe3a4c4

I think Comment #22 is the right fix as we thought last night via IRC (e.g. porting the line into the if cluase and avoid two if tests)

Thierry i think you could move the timezone::write($timezone); line properly
to fix also the last problem.

What do you mean?
The write() call is already in the if branch

What's last problem? Selecting 1st TZ after canceling? That's covered by the second commit above.

Comment #14, select a time zone, press ok. Then press Cancel into the main dialog.
The time zone is saved as soon as the user has pressed the first ok despite of he chooses to press ok or cancel later.

Please open a seperate bug report for this one.
This one already mixes several issues and begins to be too long.

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED

hmm Thierry, a package for mga4 should be provided, and pass this bug to QA team
If I'm not wrong beofore closing this anyway...

Humm this report is about Cauldron.
I think it's better I opened a new bug about the package when I build a new mga4 package.

Whiteboard: 	MGA4TOO

@ Angelo

I'm the one who hijacked Luigi12's Mga4 bug report and set it to cauldron. If he can't wait until tv opens a new one for Mga4, then I'll do it tonight.

I prefer a separate report for Mga4, too. This report already has 34 comments now, a new report is much nicer for QA testers.

commit aeda3f38b3235dc2f60fd144b32561f746b544aa
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Jun 20 09:28:52 2014 +0200

    fix crash on clicking Cancel after TZ selection (mga#13534)
    
    Conflicts:
    	perl-install/NEWS
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=aeda3f38b3235dc2f60fd144b32561f746b544aa

commit 38acef524421072eb1e4ddb589335db44c268400
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Fri Jun 20 09:30:04 2014 +0200

    fix loosing TZ choice when canceling TZ selection (mga#13534)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=38acef524421072eb1e4ddb589335db44c268400

*** Bug 12758 has been marked as a duplicate of this bug. ***

CC: (none) => yves.brungard_mageia

*** Bug 13328 has been marked as a duplicate of this bug. ***

CC: (none) => mojrv

*** Bug 13058 has been marked as a duplicate of this bug. ***

CC: (none) => gerzalnet