| Summary: | pmbr_boot should be off in EFI partition | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Nicolas Brouard <nicolas.brouard> |
| Component: | Installer | Assignee: | Thierry Vignaud <thierry.vignaud> |
| Status: | RESOLVED OLD | QA Contact: | |
| Severity: | major | ||
| Priority: | Normal | CC: | marja11, pterjan, thierry.vignaud, tmb, zen25000 |
| Version: | Cauldron | Keywords: | NEEDINFO |
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.mageia.org/show_bug.cgi?id=12740 | ||
| Whiteboard: | |||
| Source RPM: | CVE: | ||
| Status comment: | |||
|
Description
Nicolas Brouard
2014-02-19 20:26:41 CET
Manuel Hiebel
2014-02-28 16:13:29 CET
CC:
(none) =>
tmb
Thierry Vignaud
2015-03-16 12:57:28 CET
CC:
(none) =>
thierry.vignaud Pascal I think you know better where this is set... CC:
(none) =>
pterjan We could add a new gpt_clear_pmbr_flafg() function to the c module that would call ped_disk_set_flag() in order to remove PED_DISK_GPT_PMBR_BOOT eg:
int
set_disk_flag(char * device_path, PedDiskFlag flag, int state)
CODE:
PedDevice *dev = ped_device_get(device_path);
RETVAL = 0;
if(dev) {
PedDisk* disk = ped_disk_new_fresh(dev, type);
if(disk) {
RETVAL = ped_partition_set_flag(part, flag, state);
ped_disk_destroy(disk);
}
}
}
OUTPUT:
RETVAL
Thierry, tmb, is this bug fixed by what you did for Mageia 5RC and EFI support? Keywords:
(none) =>
NEEDINFO I don't know but this needs testing anyway... Nicolas, please test with Mageia 5RC so that we can know if the problem is still present. Humm, FC does remove it on EFI: https://github.com/rhinstaller/anaconda/commit/e22421be32db7c93d99915bc4d https://bugzilla.redhat.com/show_bug.cgi?id=844551 (this code is now in blivet) Hardware:
i586 =>
All See: https://github.com/rhinstaller/anaconda/commit/0880c84628ae673f467ed46acc https://github.com/rhinstaller/blivet/blob/master/blivet/blivet.py#L193 # GPT labeled disks should only have bootable set on the # EFI system partition (parted sets the EFI System GUID on # GPT partitions with the boot flag) https://github.com/rhinstaller/blivet/blob/master/blivet/formats/disklabel.py#L159 (when writing changes to disk) # Set the boot flag on the GPT PMBR, this helps some BIOS systems boot if self._partedDisk.isFlagAvailable(parted.DISK_GPT_PMBR_BOOT): # MAC can boot as EFI or as BIOS, neither should have PMBR boot set if arch.isEfi() or arch.isMactel(): self._partedDisk.unsetFlag(parted.DISK_GPT_PMBR_BOOT) log.debug("Clear pmbr_boot on %s", self._partedDisk) else: self._partedDisk.setFlag(parted.DISK_GPT_PMBR_BOOT) log.debug("Set pmbr_boot on %s", self._partedDisk) else: log.debug("Did not change pmbr_boot on %s", self._partedDisk) Assignee:
tmb =>
thierry.vignaud parted maps: - its boot flag to partition having ESP GUID - its pmbr_boot flag to partition record having bootindicator set to 0x80 We don't do anything explicitely for none. Since we tell libparted ESP is of ESP types, it sets the proper GUID which is good. As for pmbr_boot, we don't do anything. Can you try Mga5 RC? Ping? According to Colin, https://bugs.mageia.org/show_bug.cgi?id=12740#c8, it could be grub2 that set the flag: "I suspect grub2 is at fault here for setting the flag" CC:
(none) =>
zen25000 Closing as OLD, because the requested feedback wasn't given @ Nicolas Brouard Please reopen this report if this bug still happens with a Mageia 6 install. Status:
NEW =>
RESOLVED |