Bug 12714

Summary:	[candidate] allow undef for booleans
Product:	Mageia	Reporter:	Thierry Vignaud <thierry.vignaud>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	Normal	CC:	mageia, rverschelde, stormi-mageia, sysadmin-bugs, tmb
Version:	4	Keywords:	validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	has_procedure mga4-32-ok mga4-64-ok advisory
Source RPM:	perl-Glib-Object-Introspection-0.18.0-2.mga4.src.rpm	CVE:
Status comment:
Bug Depends on:	12390, 12625
Bug Blocks:

Description Thierry Vignaud 2014-02-11 07:27:02 CET

packages:
perl-Glib-Object-Introspection-0.18.0-2.mga4.src.rpm
perl-Glib-Object-Introspection-0.18.0-2.mga4.i586.rpm
perl-Glib-Object-Introspection-0.18.0-2.mga4.x86_64.rpm

Advisory:
=========
This update allow undef for booleans, thus fixing various "undefined value for mandatory argument 'XYZ' encountered" crashes  such as #12390 or #12625

Test:
=====
1) Before:
$ perl -MGtk3 -e 'Gtk3->init; $w=Gtk3::Window;$w->set_modal(undef)'; echo $?
undefined value for mandatory argument 'modal' encountered at -e line 1.
255

2) After:
$ perl -MGtk3 -e 'Gtk3->init; $w=Gtk3::Window;$w->set_modal(undef)'; echo $?
(-e:16250): Gtk-CRITICAL **: gtk_window_set_modal: assertion 'GTK_IS_WINDOW (window)' failed
0

(We now got a gtk+ warning as our one liner example didn't show the window & b/c it's empty)

Reproducible: 

Steps to Reproduce:

Thierry Vignaud 2014-02-11 07:27:17 CET

Depends on: (none) => 12390, 12625

Comment 1 Thierry Vignaud 2014-02-11 07:28:47 CET

A better test:

1) Before:
$ perl -MGtk3 -e 'Gtk3->init; $w=Gtk3::Window->new; $w->add(Gtk3::Label->new("Test")); $w->show_all; $w->set_modal(undef)';echo $?
324.
undefined value for mandatory argument 'modal' encountered at -e line 1.
255

2) After:
$ perl -MGtk3 -e 'Gtk3->init; $w=Gtk3::Window->new; $w->add(Gtk3::Label->new("Test")); $w->show_all; $w->set_modal(undef)';echo $?
0

Comment 2 Sander Lepik 2014-02-11 08:41:24 CET

Tested on 64 bit system, works.

CC: (none) => mageia
Hardware: i586 => All
Whiteboard: (none) => has_procedure mga4-64-ok

Comment 3 Samuel Verschelde 2014-02-11 09:38:27 CET

(In reply to Sander Lepik from comment #2)
> Tested on 64 bit system, works.

Have you tested also some of the applications that depend on it? (rpmdrake, drakclock...).

CC: (none) => stormi

Comment 4 Sander Lepik 2014-02-11 09:45:10 CET

Hmm, nope, I didn't as the procedure didn't ask me to do so :) I believe in Thierry =P

Comment 5 Samuel Verschelde 2014-02-11 09:47:18 CET

Well, testing bugfixes is :
1) testing the bug fix (which is what Thierry gave us as a procedure)
2) testing for regressions

Comment 6 Rémi Verschelde 2014-02-11 13:46:12 CET

Testing Mageia i586. I couldn't reproduce either bug 12390 or 12625 prior to the update.

The update candidate does not seem to introduce any regression in rpmdrake, nor in drakclock. Thierry's testing procedure in comment 1 was also successful.

--

Validating update.

Could someone push the advisory from comment 0, and a sysadmin push the update to Mageia 4 core/updates?

Keywords: (none) => validated_update
Whiteboard: has_procedure mga4-64-ok => has_procedure mga4-32-ok mga4-64-ok
CC: (none) => remi, sysadmin-bugs

Comment 7 Rémi Verschelde 2014-02-11 18:49:22 CET

Advisory pushed to svn.

Whiteboard: has_procedure mga4-32-ok mga4-64-ok => has_procedure mga4-32-ok mga4-64-ok advisory

Comment 8 Thomas Backlund 2014-02-11 23:57:37 CET

Update pushed:
http://advisories.mageia.org/MGAA-2014-0033.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED