Bug 12695

Summary: mate-session-manager package provides duplicate and untranslated register.desktop
Product: Mageia Reporter: Atilla ÖNTAŞ <tarakbumba>
Component: RPM PackagesAssignee: QA Team <qa-bugs>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Normal CC: lewyssmith, loginov_alex, rverschelde, stormi-mageia, sysadmin-bugs, tmb
Version: 4Keywords: validated_update
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard: has_procedure MGA4-32-OK MGA4-64-OK advisory
Source RPM: mate-session-manager CVE:
Status comment:
Bug Depends on:    
Bug Blocks: 12667    

Description Atilla ÖNTAŞ 2014-02-09 23:17:58 CET
Root of the original bug:
(Alex Loginov from comment #0)
> Description of problem:
> register.desktop was in desktop-common-data before only, but now in 3
> packages, and I see different register.desktop, and all are with i18n
> problems.
> 
> In all register.desktop must be:
> Name[ru]=СообÑеÑÑво Mageia
> 
> There is no commit in desktop-common-data:
> http://gitweb.mageia.org/software/desktop/common-data/commit/
> ?id=82a6d795fc02f2a93136fb4628ec6f9d74497e6b
> and there is old translation in desktop-common-data-3.5-2.mga4.noarch.rpm.
> 
> In mageia-lxde-config-Default, mate-session-manager no:
> Name[ru]=СообÑеÑÑво Mageia
> 
> Version-Release number of selected component (if applicable):
> mageia-lxde-config-Default-0.6.2-5.mga4.noarch.rpm
> desktop-common-data-3.5-2.mga4.noarch.rpm
> mate-session-manager-1.6.1-6.mga4.i586.rpm
> 
> How reproducible: always
> 
> 
> Steps to Reproduce:
> 1. Install KDE, MATE, LXDE in Russian
> 2. See the Desktop
> 3. In KDE - old translation
> 4. In MATE and LXDE - no Russian translation

mate-session-manager provides an register.desktop while it also provided by desktop-common-data package. This is wrong. mate-session-manager should use register.destop from desktop-common-data package. This report addresses this issue.

I have already uploadad an update to Cauldron. Working on Mageia 4 one.
Atilla ÖNTAŞ 2014-02-09 23:18:40 CET

CC: (none) => loginov_alex

Comment 1 Atilla ÖNTAŞ 2014-02-10 00:15:32 CET
I have uploaded an updated  mate-session-manager-1.6.1-6.1.mga4 package for Mageia 4.

Suggested advisory:
========================

Updated  mate-session-manager-1.6.1-6.1.mga4 fixes:

Currently register.desktop file which displayed by default at all DE's desktop; provided by desktop-common-data with full translations support through our i18n team work.

mate-session-manager package was providing another register.desktop file which have no translations at all instead using desktop-common-data package one. This update removes register.desktop file from the package and make it use explained default one.
========================

Updated packages in core/updates_testing:
========================
mate-session-manager-1.6.1-6.1.mga4

Source RPMs: 
========================
mate-session-manager-1.6.1-6.1.mga4.src.rpm

Assignee: tarakbumba => qa-bugs

Comment 2 Atilla ÖNTAŞ 2014-02-11 15:49:34 CET
Test case:
1- Please remove register.desktop from your Desktop
2- Install provided update from updates/testing
3- Logout and login.
4- Test if register.desktop is created at your Desktop.

Thanks.
Comment 3 Alex Loginov 2014-02-12 13:10:22 CET
MGA4-32-OK: file register.desktop was used from desktop-common-data package in MATE.
Atilla, thank you for fast fixing.
Atilla, why do you think file register.desktop must be created at the Desktop after removing and logout? If it would be so, it's wrong. If user will delete something from the Desktop, deleted file/directory must not autoreturn at the Desktop.

Correct test:
1 - Install provided update from updates/testing
2 - Create new user
3 - Log in as new user
4 - See your Desktop

Whiteboard: (none) => MGA4-32-OK

Comment 4 Atilla ÖNTAŞ 2014-02-12 13:14:59 CET
(In reply to Alex Loginov from comment #3)
> MGA4-32-OK: file register.desktop was used from desktop-common-data package
> in MATE.
> Atilla, thank you for fast fixing.
> Atilla, why do you think file register.desktop must be created at the
> Desktop after removing and logout? If it would be so, it's wrong. If user
> will delete something from the Desktop, deleted file/directory must not
> autoreturn at the Desktop.
> 
> Correct test:
> 1 - Install provided update from updates/testing
> 2 - Create new user
> 3 - Log in as new user
> 4 - See your Desktop

Yes, you' re right. Correct test is what you wrote. mate-session-manager won't re-create deleted file from Desktop.
Samuel Verschelde 2014-02-12 19:50:39 CET

CC: (none) => stormi
Whiteboard: MGA4-32-OK => MGA4-32-OK has_procedure

Comment 5 Lewis Smith 2014-02-13 12:17:22 CET
Testing on real 64-bit hardware.

Followed procedure in coment 3.
    mate-session-manager-1.6.1-6.1.mga4
The desktop appeared OK with 4 of its 8 icons translated. However, I think it was like this with mate-session-manager-1.6.1-6.mga4.
The file ~/Desktop/register.desktop is the same as /usr/share/dist/desktop-files/default/register.desktop, so

MGA4-64-OK

CC: (none) => lewyssmith
Whiteboard: MGA4-32-OK has_procedure => MGA4-32-OK has_procedure MGA4-64-OK

Comment 6 Rémi Verschelde 2014-02-13 12:30:27 CET
Validating update, advisory has been uploaded. Please push to 4 core/updates.

Keywords: (none) => validated_update
Whiteboard: MGA4-32-OK has_procedure MGA4-64-OK => has_procedure MGA4-32-OK MGA4-64-OK advisory
CC: (none) => remi, sysadmin-bugs

Comment 7 Thomas Backlund 2014-02-13 21:09:52 CET
Update pushed:
http://advisories.mageia.org/MGAA-2014-0043.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED