Bug 12599

Summary:	Add i18n support in dosbox
Product:	Mageia	Reporter:	Alex Loginov <loginov_alex>
Component:	RPM Packages	Assignee:	Damien Lallement <mageia>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	Keywords:	Triaged
Version:	Cauldron
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	dosbox-0.74-7	CVE:
Status comment:
Attachments:	patch for spec dosbox-0.74.conf DOSBox-russian-lang.zip dosbox.diff

Description Alex Loginov 2014-02-05 08:06:46 CET

Description of problem: No Russian/English tools in dosbox


Version-Release number of selected component (if applicable): dosbox-0.74-7


How reproducible: always


Steps to Reproduce:
1. run dosbox
2. only English, no useful mechanism to change language

Solution: merge with dosbox from Mageia Russian Community repo http://packages.mageialinux.ru/mageia3/SRPMS/dosbox-0.74-17.mga3.mrc.src.rpm or fully to change on my modified version.

Reproducible: 

Steps to Reproduce:

Manuel Hiebel 2014-02-05 11:38:18 CET

Keywords: (none) => Triaged
Assignee: bugsquad => mageia

Comment 1 Alex Loginov 2014-02-07 17:16:31 CET

Created attachment 4957 [details]
patch for spec

Comment 2 Alex Loginov 2014-02-07 17:17:26 CET

Created attachment 4958 [details]
dosbox-0.74.conf

Comment 3 Alex Loginov 2014-02-07 17:17:56 CET

Created attachment 4959 [details]
DOSBox-russian-lang.zip

Comment 4 Alex Loginov 2014-02-07 17:23:48 CET

I merged packages. Please commit and submit in updates for mga4 also.

For QA:

dosbox-set-lang ru
dosbox

dosbox-set-lang en
dosbox

Comment 5 Damien Lallement 2014-02-07 17:36:27 CET

WIP in progress on my side.
For now, as the maintainer of this package, I'm against this modification for one language as on http://www.dosbox.com/download.php?main=1, it's explained how to have the software in its mother tongue.
Why not having a modification for FR, DE, ES, ...?
It will be hard to maintain...
Better would be for you to ask upstream a better i18n support for next version of dosbox.
BTW, I will have a look at your specfile but I can't promise I will agree with your request for now guys.

Status: NEW => ASSIGNED

Comment 6 Alex Loginov 2014-02-07 18:04:14 CET

I don't see problem to add all languages if you want, my changes allow it.
You should add DOSBox-*-lang-0.74.zip in Source3,4,5... and add case in %{buildroot}/%{_bindir}/%{name}-set-lang in spec file.

Comment 7 Damien Lallement 2014-02-07 18:39:07 CET

Great.
I didn't saw your specfile for now. So...
I will tonight at home. ;-)

Alex Loginov 2014-02-08 20:56:58 CET

Summary: Add Russian support in dosbox => Add i18n support in dosbox

Comment 8 Alex Loginov 2014-02-09 08:17:12 CET

Damien, what do you think about continue modification and to add auto determine locale when the first start?

Exec=script in bosbox.desktop

Script must determine locale and if the first start (there is no config in ~/.dosbox) to run
dosbox-set-lang language
dosbox

and if the second start, then to run
dosbox

Comment 9 Damien Lallement 2014-02-13 04:18:06 CET

Done for cauldron Alex, sorry for the delay.
Please test dosbox-0.74-8.mga5 :-)

Comment 10 Alex Loginov 2014-02-13 12:31:20 CET

Created attachment 4984 [details]
dosbox.diff

Changed version in dosbox-set-locale_config.sh on variable
More exactly detect for language and keyboardlayout in config
Fixed Comment
Added Russian Comment
Added drag and drop support
Added README.video as doc

Attachment 4957 is obsolete: 0 => 1
Attachment 4959 is obsolete: 0 => 1

Comment 11 Alex Loginov 2014-02-13 12:33:49 CET

Thank you, Damien
I tested and sent to you new patch in attachment.

Comment 12 Damien Lallement 2014-04-02 22:27:01 CEST

Fixed. Thanks Alex!
dosbox-0.74-9.mga5 now available.

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED