Bug 12472

Summary:	MageiaUpdate add only updates media when proposed
Product:	Mageia	Reporter:	Manuel Hiebel <manuel.mageia>
Component:	RPM Packages	Assignee:	Thierry Vignaud <thierry.vignaud>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	rverschelde, stephane_oss
Version:	Cauldron	Keywords:	PATCH
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	rpmdrake	CVE:
Status comment:

Description Manuel Hiebel 2014-01-29 13:19:16 CET

Description of problem:

When only cdrom are listed as media, if you open MageiaUpdate, a popup come and ask if it can acces to the api, then we get the list of mirror. 

As a result it adds only updates media and not the core too. This should not happens (cf qa bugs)

Reproducible: 

Steps to Reproduce:

Comment 1 Manuel Hiebel 2014-01-29 13:26:15 CET

could it be in the lines add_distrib_update_media "only_updates" set 0 instead of 1 ?

http://gitweb.mageia.org/software/rpmdrake/tree/Rpmdrake/edit_urpm_sources.pm

Comment 2 Manuel Hiebel 2014-01-29 13:38:28 CET

just tried, looks not that

Comment 3 Manuel Hiebel 2014-03-08 20:29:38 CET

Found it, it's here: http://gitweb.mageia.org/software/rpmdrake/tree/Rpmdrake/pkg.pm#n289 

changing "only_updates => 1" to "only_updates => 0" make it to add all source.

Maybe something there is also a little issue as I never saw "You have no configured update media. MageiaUpdate cannot operate without any update media."

Ah and I forget to say that this also happen when no media are present. (so comment 0 was a bit wrong)

Keywords: (none) => PATCH

Comment 4 Thierry Vignaud 2015-02-11 09:27:47 CET

Feel free to commit this change in git

Comment 5 Manuel Hiebel 2015-02-11 17:51:40 CET

I have no access ;)

Comment 6 Mageia Robot 2015-02-14 15:26:14 CET

commit ac8c6f381131034ea0dbf3ac26f392cbe1cd550d
Author: Rémi Verschelde <remi@...>
Date:   Sat Feb 14 15:25:49 2015 +0100

    MageiaUpdate: add all mirrors instead of only updates mirrors when no updates mirrors are defined (mga#12472)
    
    Fix by Manuel Hiebel.
---
 Commit Link:
   http://gitweb.mageia.org/software/rpmdrake/commit/?id=ac8c6f381131034ea0dbf3ac26f392cbe1cd550d

Comment 7 Rémi Verschelde 2015-02-14 15:30:55 CET

On a second thought I could have probably just pushed the patch without releasing a new version so quickly, sorry about that.

I'll think twice next time :)

CC: (none) => remi

Comment 8 Mageia Robot 2015-02-14 19:27:05 CET

commit 869ab3f21ef71028b557b64a3357cb92e60a9a9b
Author: Angelo Naselli <anaselli@...>
Date:   Sat Feb 14 19:25:14 2015 +0100

    From rpmdrake - Rémi Verschelde - MageiaUpdate: add all mirrors instead of only updates mirrors when no updates mirrors are defined (mga#12472)
---
 Commit Link:
   http://gitweb.mageia.org/software/adminpanel/commit/?id=869ab3f21ef71028b557b64a3357cb92e60a9a9b

Comment 9 Stephane 2015-02-22 21:06:27 CET

I am not sure to really understand "description of problem of this bug".

I have rpmdrake-6.15-1.mga5 installed.
If I execute mgaupdate from commandline under a non privilege user I get the pop to require root access.
But when my list of update media are empty mgaupdate doesn't find update and didn't ask to add new media source.
When I go throw MCC I need to open "configure source media" (approximately I use FR localization) and then click add to get a popup to ask if I want to contact mirror to get a list of mirrors.

What it would be better is to get this popup when you try to update and no update mirror are configured.
By default, there are only cdrom media configured. So it would be useful to get this popup to add automatically update mirror (and other mirrors as mentioned in previous posts).

CC: (none) => stephane_oss

Comment 10 Stephane 2015-02-22 21:09:57 CET

Just to link Bug #15048 with my comment 9.

Comment 11 Manuel Hiebel 2015-02-22 22:31:35 CET

not related to this bug which now fixed

Status: NEW => RESOLVED
Resolution: (none) => FIXED