Bug 12412

Summary:	dosfstools FAT corruption with fsck on 64-bit
Product:	Mageia	Reporter:	David Walser <luigiwalser>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	Normal	CC:	stormi-mageia, sysadmin-bugs, tmb
Version:	3	Keywords:	validated_update
Target Milestone:	---
Hardware:	x86_64
OS:	Linux
URL:	http://freecode.com/projects/dosfstools/releases/360772
Whiteboard:	has_procedure mga3-64-ok mga3-32-ok advisory
Source RPM:	dosfstools-3.0.16-1.mga3.src.rpm	CVE:
Status comment:

Description David Walser 2014-01-24 03:20:57 CET

dosfstools 3.0.25 was released on January 17, fixing fsck errors on 64-bit.
http://daniel-baumann.ch/software/dosfstools/

The exact ChangeLog entries are as follows:
commit 21fe921
Author: Andrew Tridgell <tridge@samba.org>
Date:   Tue Jan 14 09:37:51 2014 +1100

    Fixed remaining 64 bit build warnings.
    
    Some of these may be real bugs.
    
    Signed-off-by: Daniel Baumann <mail@daniel-baumann.ch>

commit 9e3a2b1
Author: Andrew Tridgell <tridge@samba.org>
Date:   Tue Jan 14 09:25:28 2014 +1100

    Prevent corruption of FAT during fsck on 64 bit platforms.
    
    unsigned long is 64 bit on x86-64, which means set_fat was writing two
    entries, which corrupts the next entry. This can cause loss of data in
    another file.


I've backported these fixes to Mageia 3.

Advisory:
----------------------------------------

The dosfsck command in dosfstools before 3.0.25 could cause corruption in
FAT filesystems when used on 64-bit platforms.  This has been fixed.

References:
http://daniel-baumann.ch/software/dosfstools/
----------------------------------------
Updated packages in core/updates_testing:
----------------------------------------
dosfstools-3.0.16-1.1.mga3

from dosfstools-3.0.16-1.1.mga3.src.rpm

Reproducible: 

Steps to Reproduce:

David Walser 2014-01-24 03:23:09 CET

Hardware: i586 => x86_64

Comment 1 claire robinson 2014-01-24 08:16:23 CET

Testing complete mga3 64

Created some files on a vfat usb stick

$ for (( i=100;i<200;i++ )) do echo "File ok" > /run/media/claire/USBSTICK/file$i; done

$ cat /run/media/claire/USBSTICK/file*
$ cat /run/media/claire/USBSTICK/file* | wc -l
100

Before
------

# dosfsck -vr /dev/sdd
dosfsck 3.0.16 (01 Mar 2013)
dosfsck 3.0.16, 01 Mar 2013, FAT32, LFN
Logical sector size (56113 bytes) is not a multiple of the physical sector size.

$ cat /run/media/claire/USBSTICK/file*
$ cat /run/media/claire/USBSTICK/file* | wc -l
100

After
-----

# dosfsck -vr /dev/sdd
dosfsck 3.0.16 (01 Mar 2013)
dosfsck 3.0.16, 01 Mar 2013, FAT32, LFN
Logical sector size (56113 bytes) is not a multiple of the physical sector size.

$ cat /run/media/claire/USBSTICK/file*
$ cat /run/media/claire/USBSTICK/file* | wc -l
100

Nothing unusual to note, before or after.

Whiteboard: (none) => has_procedure mga3-64-ok

Comment 2 Samuel Verschelde 2014-01-24 12:01:28 CET

Is there

CC: (none) => stormi

Comment 3 Samuel Verschelde 2014-01-24 12:02:13 CET

Trying again: is there a way to reproduce the filesystem corruption?

Testing mga3 32 in progress.

Comment 4 Samuel Verschelde 2014-01-24 12:41:39 CET

mga3 32 testing complete.

Whiteboard: has_procedure mga3-64-ok => has_procedure mga3-64-ok mga3-32-ok

Comment 5 David Walser 2014-01-24 12:51:43 CET

(In reply to Samuel VERSCHELDE from comment #3)
> Trying again: is there a way to reproduce the filesystem corruption?

I think in general, fsck doesn't write to a filesystem unless it thinks it needs to (other than marking it as having been checked in some cases), so it might have to already be corrupted a bit to trigger this, but I'm not sure.

Comment 6 Samuel Verschelde 2014-01-28 18:28:29 CET

Advisory added

Whiteboard: has_procedure mga3-64-ok mga3-32-ok => has_procedure mga3-64-ok mga3-32-ok advisory

Comment 7 Samuel Verschelde 2014-01-28 18:36:39 CET

Update validated and advisory in SVN.

Could sysadmin please push from core/updates_testing to core/updates.

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs

Comment 8 Thomas Backlund 2014-01-31 18:10:12 CET

Update pushed:
http://advisories.mageia.org/MGAA-2014-0013.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED