Bug 12358

Summary:	Mageia soft haves cutted icons
Product:	Mageia	Reporter:	Alex Loginov <loginov_alex>
Component:	RPM Packages	Assignee:	Thierry Vignaud <thierry.vignaud>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	aurelienmurith, thierry.vignaud
Version:	Cauldron	Keywords:	PATCH, USABILITY
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	gtk+3.0, drakxtools	CVE:
Status comment:
Bug Depends on:
Bug Blocks:	11778
Attachments:	Picture with problem (rpmdrake)

Description Alex Loginov 2014-01-19 09:52:27 CET

Description of problem: Many Mageia tools haves cutted icons


Version-Release number of selected component (if applicable): all Mageia soft


How reproducible:always


Steps to Reproduce:
1. for example, to run rpmdrake
2. to see cutted icon


Reproducible: 

Steps to Reproduce:

Comment 1 Alex Loginov 2014-01-19 09:54:50 CET

Created attachment 4819 [details]
Picture with problem (rpmdrake)

Comment 2 Manuel Hiebel 2014-01-21 01:10:20 CET

on what for desktop ?

(btw in english an imperative sentence does not begin with "to" ;) )

CC: (none) => thierry.vignaud

Comment 3 Manuel Hiebel 2014-01-21 01:22:21 CET

indeed, (doesn't depends of the environment) but I didn't found any other drakx with it.

Blocks: (none) => 11778
Assignee: bugsquad => thierry.vignaud
Summary: Mageia soft haves cutted icons => rpmdrake haves cutted icons
Source RPM: (none) => rpmdrake

Comment 4 Alex Loginov 2014-01-21 09:13:03 CET

I found: rpmdrake, drakrpm-update, drakuser, draksambashare, draknfs, draknetcenter, logdrake (Mail Alert only).

Alex Loginov 2014-02-02 18:55:06 CET

Summary: rpmdrake haves cutted icons => Mageia soft haves cutted icons
Source RPM: rpmdrake => rpmdrake, drakrpm-update, drakuser, draksambashare, draknfs, draknetcenter, logdrake

Comment 5 Alex Loginov 2014-02-19 17:42:07 CET

Thierry, will you find a bit of time?
Maybe it will fix easy, but would look nice.

Thierry Vignaud 2014-06-27 16:17:58 CEST

Keywords: (none) => USABILITY

Comment 6 Aurélien Murith 2014-10-08 21:47:40 CEST

Would it be possible to fix this before Mageia 5 is released ?
I'm sorry to say that but this bug really makes the distro look "badly polished"â¦

In the Alpha 2 it still has not been fixed. It appears in any desktop (KDE, GNOME, Xfce, â¦).

It would really be great if the developers could worry a little more about aesthetics from time to time ;)

CC: (none) => aurelienmurith

Comment 7 Manuel Hiebel 2014-10-20 22:49:08 CEST

if I remove 

$icon_img->set_margin_top(($blue_part->get_height-$icon_w->get_height)/2-4); 

(equivalent in mga4) it works, but it certainly break something else (no ideas what it really do)

http://gitweb.mageia.org/software/drakx/tree/perl-install/ugtk3.pm#n1548

Comment 8 Aurélien Murith 2015-01-29 21:18:20 CET

The problem is still present in Mageia 5 beta 2.

Manuel, I think you found where the problem is.
In my opinion it should not break anything elsewhere. After all, if this is fixed but another icon is broken, the situation will be same as now, so why not trying what you suggested ?

I believe this problem appears since the MCC has been ported to GTK+3, but I don't know much about GTK+ so I can't tell more.

Hardware: i586 => All

Thierry Vignaud 2015-05-19 11:45:28 CEST

Keywords: (none) => PATCH

Comment 9 Thierry Vignaud 2015-05-19 12:19:20 CEST

Fixed in my local git

Status: NEW => RESOLVED
Resolution: (none) => FIXED
Source RPM: rpmdrake, drakrpm-update, drakuser, draksambashare, draknfs, draknetcenter, logdrake => gtk+3.0, drakxtools

Comment 10 Mageia Robot 2015-05-19 18:41:19 CEST

commit 7dbb2f4624e9df80b2aec3ad476347d2ea37e0ef
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Tue May 19 06:17:23 2015 -0400

    fix setting banner icon top margin (mga#12358)
    
    Gtk3's gtk_widget_set_margin_top() really is buged when margin < 0
    
    bug introduced in commit f5ed08a589bc9081c68188c464a5a978557d0b2a
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=7dbb2f4624e9df80b2aec3ad476347d2ea37e0ef

Comment 11 Mageia Robot 2015-05-19 19:37:20 CEST

commit b268870a7af9c251a9e4e61488fe1ee5eb35191f
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Tue May 19 06:17:23 2015 -0400

    fix setting banner icon top margin (mga#12358)
    
    Gtk3's gtk_widget_set_margin_top() really is buged when margin < 0
    
    bug introduced in commit f5ed08a589bc9081c68188c464a5a978557d0b2a
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=b268870a7af9c251a9e4e61488fe1ee5eb35191f