Bug 1190

Summary:	some kde4-firstsetup.sh fixes and improvements
Product:	Mageia	Reporter:	Luc Menut <lmenut>
Component:	RPM Packages	Assignee:	John Balcaen <balcaen.john>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	ahmadsamir3891, marcello.anni
Version:	Cauldron
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:
Source RPM:	mageia-kde4-config-1-0.31.mga1.src.rpm	CVE:
Status comment:
Attachments:	kde4-firstsetup.sh patch kde4-firstsetup.sh patch v2

Description Luc Menut 2011-05-07 17:58:26 CEST

Description of problem:
Comments on the changes I propose for kde4-firstsetup.sh in the patch in attachment:
- remove CFGFILE= ...: it is not used,
- migrate [Mandriva]PowersaveApplet=true to [Mageia]PowersaveApplet=true on migration Mdv -> Mga (for consistency with Mga install),
- rename PSAVE to MGADESK for MageiaDesktopFiles, for a better script's lisibility,
- really migrate iaora-qt to iaorakde: due to typo, Mdv has never done this migration!! (with [ ! "$IAORAKDE" = "false" ] , the test is always false),
- migrate mandriva-drakconf.desktop to mageia-drakconf.desktop in favorites menu on migration Mdv -> Mga, from Ahmad's suggestion #916,
- move the main fi at the end of the script, and add a comment.

Send here for review and comments!!

Comment 1 Luc Menut 2011-05-07 17:59:26 CEST

Created attachment 359 [details]
kde4-firstsetup.sh patch

Comment 2 Luc Menut 2011-05-12 00:50:08 CEST

Created attachment 390 [details]
kde4-firstsetup.sh patch v2

new version of the patch, after discussion with mikala on irc.
we try to migrate more stuff:
- save the origin config file (suffix .MdvToMga)
- migrate all mandriva-*.desktop to mageia-*.desktop in favorites menu, and icons on taskbar,
- migrate openoffice .desktop to libreoffice .desktop in favorites menu, and icons on taskbar,
- migrate default lancelot config; mandriva-drakconf to mageia-drakconf in system application tab, and writer, impress and calc new documents to libreoffice one's.

Send here for review and comments!!

Attachment 359 is obsolete: 0 => 1

Luc Menut 2011-05-12 00:53:46 CEST

CC: (none) => ahmadsamir3891

Comment 3 Marcello Anni 2011-05-14 16:00:02 CEST

can you apply also the changes required by this bug? 

https://bugs.mageia.org/show_bug.cgi?id=916


thank you

CC: (none) => marcello.anni

Comment 4 Ahmad Samir 2011-05-14 22:24:52 CEST

(In reply to comment #3)
> can you apply also the changes required by this bug? 
> 
> https://bugs.mageia.org/show_bug.cgi?id=916
> 
> 
> thank you

Already done in the proposed patch.

Comment 5 John Balcaen 2011-05-15 14:20:24 CEST

Ok changes are included with mageia-kde4-config-1-3.mga1.src.rpm
I just did a minor change for lancelot using cp instead of ln -sf ( lancelot is in fact copying the desktop file & not using ln for thoses desktop files)

Status: NEW => RESOLVED
Resolution: (none) => FIXED