Bug 11886

Summary:	Update Request: ndiswrapper-1.59-1.mga3
Product:	Mageia	Reporter:	Thomas Backlund <tmb>
Component:	RPM Packages	Assignee:	QA Team <qa-bugs>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	Normal	CC:	sysadmin-bugs
Version:	3	Keywords:	validated_update
Target Milestone:	---
Hardware:	All
OS:	Linux
Whiteboard:	has_procedure advisory mga3-32-ok mga3-64-ok
Source RPM:	ndiswrapper-1.59-1.mga3	CVE:
Status comment:
Bug Depends on:	11463
Bug Blocks:

Description Thomas Backlund 2013-12-05 20:47:56 CET

This update provides ndiswrapper 1.59 which provides the following:
- adds support for  3.9-3.12
- includes a fix for a kernel hang if the NDIS driver loader exits with an error. 

List of RPMS

SRPM:
ndiswrapper-1.59-1.mga3.src.rpm

i586:
dkms-ndiswrapper-1.59-1.mga3.noarch.rpm
ndiswrapper-1.59-1.mga3.i586.rpm

x86_64:
dkms-ndiswrapper-1.59-1.mga3.noarch.rpm
ndiswrapper-1.59-1.mga3.x86_64.rpm


Reproducible: 

Steps to Reproduce:

Thomas Backlund 2013-12-05 20:48:21 CET

Depends on: (none) => 11463

Thierry Vignaud 2013-12-05 23:30:51 CET

CC: (none) => thierry.vignaud
Version: 3 => Cauldron
Whiteboard: (none) => MGA3TOO

Thierry Vignaud 2013-12-05 23:31:16 CET

Version: Cauldron => 3
Whiteboard: MGA3TOO => (none)

Thierry Vignaud 2013-12-05 23:31:36 CET

CC: thierry.vignaud => (none)

Comment 1 claire robinson 2013-12-18 14:55:59 CET

Testing i586 with a random broadcom from the ndiswrapper "known working" list.
http://sourceforge.net/apps/mediawiki/ndiswrapper/index.php?title=Broadcom_BCM4318

Before
------
# ndiswrapper -i bcmwl5a.inf
installing bcmwl5a ...
forcing parameter IBSSGMode from 0 to 2
forcing parameter IBSSGMode from 0 to 2

# ndiswrapper -l
bcmwl5a : driver installed

# ndiswrapper -r bcmwl5a
# ndiswrapper -l
# 

# modprobe ndiswrapper
modprobe: FATAL: Module ndiswrapper not found.

The ndiswrapper dkms module isn't built on install, meaning the machine has to be rebooted to use it. Rebooting now.

Comment 2 claire robinson 2013-12-18 15:04:35 CET

Noob error, sorry. I forgot to install it :D

Comment 3 claire robinson 2013-12-18 15:10:37 CET

Current version gives an error though. I'll try with the update.

installing dkms-ndiswrapper-1.58-1.mga3.noarch.rpm from /var/cache/urpmi/rpms    
Preparing...                     ###############################################
      1/1: dkms-ndiswrapper      ###############################################

Creating symlink /var/lib/dkms/ndiswrapper/1.58-1.mga3/source ->
                 /usr/src/ndiswrapper-1.58-1.mga3

DKMS: add Completed.

Preparing kernel 3.10.24-1.mga3 for module build:
(This is not compiling a kernel, just preparing kernel symbols)
Storing current .config to be restored when complete
Running Generic preparation routine
make mrproper.........
using /proc/config.gz
make oldconfig......
make prepare....

Building module:
cleaning build area....
make KERNELRELEASE=3.10.24-1.mga3 KVERS=3.10.24-1.mga3 -C /var/lib/dkms/ndiswrapper/1.58-1.mga3/build.......(bad exit status: 2)

Error! Bad return status for module build on kernel: 3.10.24-1.mga3 (i586)
Consult the make.log in the build directory
/var/lib/dkms/ndiswrapper/1.58-1.mga3/build/ for more information.

Error! Could not locate ndiswrapper.ko.xz for module ndiswrapper in the DKMS tree.
You must run a dkms build for kernel 3.10.24-1.mga3 (i586) first.



The make.log is below...

DKMS make.log for ndiswrapper-1.58-1.mga3 for kernel 3.10.24-1.mga3 (i586)
Wed 18 Dec 14:04:38 GMT 2013
make: Entering directory `/var/lib/dkms/ndiswrapper/1.58-1.mga3/build'
make -C /usr/src/kernel-linus-devel-3.10.24-1.mga3 M=/var/lib/dkms/ndiswrapper/1.58-1.mga3/build
make[1]: Entering directory `/usr/src/kernel-linus-devel-3.10.24-1.mga3'
  LD      /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/built-in.o
  MKEXPORT /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/crt_exports.h
  MKEXPORT /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/hal_exports.h
  MKEXPORT /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/ndis_exports.h
  MKEXPORT /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/ntoskernel_exports.h
  MKEXPORT /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/ntoskernel_io_exports.h
  MKEXPORT /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/rtl_exports.h
  MKEXPORT /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/usb_exports.h
  CC [M]  /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/crt.o
  CC [M]  /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/hal.o
  CC [M]  /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/iw_ndis.o
  CC [M]  /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/loader.o
/var/lib/dkms/ndiswrapper/1.58-1.mga3/build/loader.c: In function âload_user_space_driverâ:
/var/lib/dkms/ndiswrapper/1.58-1.mga3/build/loader.c:578:3: error: too few arguments to function âadd_taintâ
In file included from include/linux/cache.h:4:0,
                 from include/linux/time.h:4,
                 from include/linux/ktime.h:24,
                 from include/linux/timer.h:5,
                 from /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/ntoskernel.h:20,
                 from /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/ndis.h:19,
                 from /var/lib/dkms/ndiswrapper/1.58-1.mga3/build/loader.c:16:
include/linux/kernel.h:404:13: note: declared here
make[2]: *** [/var/lib/dkms/ndiswrapper/1.58-1.mga3/build/loader.o] Error 1
make[1]: *** [_module_/var/lib/dkms/ndiswrapper/1.58-1.mga3/build] Error 2
make[1]: Leaving directory `/usr/src/kernel-linus-devel-3.10.24-1.mga3'
make: *** [modules] Error 2
make: Leaving directory `/var/lib/dkms/ndiswrapper/1.58-1.mga3/build'

Comment 4 claire robinson 2013-12-18 15:19:44 CET

The update builds fine so I guess this needed to be pushed with the kernel update.

# lsmod | grep ndis
# modprobe ndiswrapper
# lsmod | grep ndis
ndiswrapper           192980  0 
usbcore               189409  5 uhci_hcd,ndiswrapper,ehci_hcd,ehci_pci,usbhid

# ndiswrapper -i bcmwl5a.inf 
installing bcmwl5a ...
forcing parameter IBSSGMode from 0 to 2
forcing parameter IBSSGMode from 0 to 2

# ndiswrapper -l
bcmwl5a : driver installed

# ndiswrapper -r bcmwl5a

# ndiswrapper -l
# 


I have no hardware to test functionality with but the module loads ok and the windows driver is loaded into it ok. Testing mga3 64 too in just a moment so this can be pushed ASAP.

Whiteboard: (none) => has_procedure mga3-32-ok

Comment 5 claire robinson 2013-12-18 15:37:01 CET

Testing complete mga3 64

Validating. Advisory uploaded.

Could sysadmin please urgently push from 3 core/updates_testing to updates

Release package does not build with the kernels which were recently pushed.
Could leave people without wifi, unable to update.

Thanks!

Keywords: (none) => validated_update
Whiteboard: has_procedure mga3-32-ok => has_procedure advisory mga3-32-ok mga3-64-ok
CC: (none) => sysadmin-bugs

Comment 6 Thomas Backlund 2013-12-18 23:57:51 CET

Update pushed:
http://advisories.mageia.org/MGAA-2013-0134.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED